Right way to delete the idle threads from a smart thread pool

Question

2.00/5 (1 vote)

See more:

I have been using the C# smart thread pool to do some work but found the current smart thread pool release DOES NOT anything about the removed "idle threads". This may or may not cause smart thread pool memory leaks.

In the smartthreadpool.ProcessQueueItem() method there are several times the method calls InforComleted() method when a idle thread(s) is timed out. But the InformCompleted() just removes the thread from the dictionary and didn't the delete these threads:

C#

private void InformCompleted()
{
   if(_workerThreads.Contains(Thread.CurrentThread))
   {
      _workerThreads.Remove(Thread.CurrentThread);
   }
}

I'm wondering if there is anyone out there already solved this problem and test it out.

Thank you very much.

Best regards,
CodeBeetle123

Posted 13-May-13 10:31am

CodeBeetle123

Updated 13-May-13 10:33am

RaisKazi

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 13-May-13 16:41pm

Why? This is not how Thread Pool is used.
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2013-05-13T12:27:00

Solution 1

Normally, you DON'T remove threads from the pool. They sit there idle, waiting for work to do so you don't incur the rather large overhead of spinning a new thread up!

If you've got questions about a particular library, you contact the author of that library. Just because you saw it in an article here does NOT mean that everyone around here knows exactly what you're talking about and has used every bit of code in every article.

Posted 13-May-13 12:27pm

Dave Kreskowiak

Comments

CodeBeetle123 14-May-13 13:14pm

Thanks for the comments. Actually the author of this librsry makes it configurable for deleting idle thread or not to.

Here I just bring it to attention there is an issue in the library if someone decides to delete the "TIMEED OUT" idle threads.

I posted the same question in the smart thread pool discussion section hoping the author will response.