How to solve this error ?

Question

1.00/5 (1 vote)

See more:

I've a windows form containing Id,GroupName,MemberName,Date,InstallmentAmount.
when I'm adding data to database it shows "Incorrect Syntax near '1000'."(1000 is the amount of installment which I inserted in textbox.)
In database type of this field is numeric(8,2).
I'm not understanding why I'm getting this error. Please Help.

Here is my code:

C#

private void btnSAdd_Click(object sender, EventArgs e)
       {
           cmbSGID = Convert.ToInt16(cmbSGrpName.SelectedValue);
           cmbSMId=Convert.ToInt32(cmbSMName.SelectedValue);
           SavingsDetails sd = new SavingsDetails(lblSTId.Text,cmbSGID,cmbSMId,dtpInstallmentDate.Value.Date,Convert.ToInt32(txtInstallmentAmt.Text));
           sd.Add();
           setSavingsGridView();
           resetSavingsDetails();
       }

C#

public SavingsDetails(string _STId, int _GId, int _MId, DateTime _SDate, int _Amt)
        {
            con = new Connection();
            STId = Convert.ToInt16(_STId);
            GId = _GId;
            MId = _MId;
            SDate = _SDate;
            Amt = _Amt;
        }

        public void Add()
        {
            con.Execute("insert into tblSavingsDetails(STId,STDate,GId,MId,SavingInstallment) values("+ STId +","+ SDate.ToShortDateString() +","+ GId +","+ MId +","+ Amt +"");
            
        }

Posted 12-Jul-14 23:02pm

Sneha_10

Add a Solution

Comments

Kornfeld Eliyahu Peter 13-Jul-14 5:08am

1. Never use string concatenation to create SQL query from code, use parameterized query...
2. What the actual SQL query you got? All the values are escaped as needed (enclosed in quotes)?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DamithSL · Accepted Answer · 2014-07-12T23:06:00

Solution 1

I think you missed final ")"

C#

con.Execute("insert into tblSavingsDetails(STId,STDate,GId,MId,SavingInstallment) values("+ STId +","+ SDate.ToShortDateString() +","+ GId +","+ MId +","+ Amt +")");

as a best practice, don't concatenate and build the sql statement, use Parameters [^]

Posted 12-Jul-14 23:06pm

DamithSL

Updated 12-Jul-14 23:09pm

v2

Comments

Sneha_10 13-Jul-14 5:48am

It was so obvious....Silly me.....Thank you for the correction.