How To Solve The Problem At When I Will Not Browse The File For Sending Email....?

Question

0.00/5 (No votes)

See more:

I am doing how to send the emails,The below code is successfully work but when i am not browse any file to send then it occures a run time exception...so how to solve it...thanks in advance......

private void btnsendnow_Click(object sender, EventArgs e)
{

//email_send
try
{
SmtpClient client = new SmtpClient("smtp.gmail.com", 587);
client.EnableSsl = true;
client.Timeout = 100000;
client.DeliveryMethod = SmtpDeliveryMethod.Network;
client.UseDefaultCredentials = false;
client.Credentials = new NetworkCredential("EMAIL-ID", "PASSWORD");
MailMessage msg = new MailMessage();
msg.To.Add(txtto.Text);
msg.From = new MailAddress("EMAIL-ID");
msg.Subject = txtsubject.Text;
msg.Body = txtmessage.Text;
Attachment data = new Attachment(txtattachment.Text);
if (txtattachment.Text == "")
{
msg.Attachments.Add(data);
client.Send(msg);
}
else
{
msg.Attachments.Add(data);
client.Send(msg);
}
// List<string> mail = txtto.Text.Trim().Split(',').ToList();
//client.Send(msg,mail);
MessageBox.Show("successfully send.....");

}
catch (Exception ex)
{

MessageBox.Show(ex.Message);
}
}

private void btnbrowse_Click(object sender, EventArgs e)
{
OpenFileDialog dlg = new OpenFileDialog();
if (dlg.ShowDialog() == DialogResult.OK)
{
txtattachment.Text = dlg.FileName.ToString();
}
}

Posted 30-Jan-15 2:00am

Member 11227519

Add a Solution

3 solutions

Solution 2

Thank u very much.......it works properly........

Posted 30-Jan-15 2:18am

Member 11227519

Solution 3

private void btnsendnow_Click(object sender, EventArgs e)
{
    //email_send
    try
    {
        SmtpClient client = new SmtpClient("smtp.gmail.com", 587);
        client.EnableSsl = true;
        client.Timeout = 100000;
        client.DeliveryMethod = SmtpDeliveryMethod.Network;
        client.UseDefaultCredentials = false;
        //client.Credentials = new NetworkCredential("EMAIL-ID", "PASSWORD");
        client.Credentials = new NetworkCredential("EMAIL-ID", "PASSWORD");
        MailMessage msg = new MailMessage();
        msg.To.Add(txtto.Text);
        msg.From = new MailAddress("EMAIL-ID");
        msg.Subject = txtsubject.Text;
        msg.Body = txtmessage.Text;

        if(!string.IsNullOrEmpty(txtattachment.Text))
        {
            if(System.IO.File.Exists(txtattachment.Text))
            {
                Attachment data = new Attachment(txtattachment.Text);
                msg.Attachments.Add(data);
            }
        }
        client.Send(msg);
        // List mail = txtto.Text.Trim().Split(',').ToList();
        //client.Send(msg,mail);
        MessageBox.Show("successfully send.....");

    }
    catch (Exception ex)
    {

        MessageBox.Show(ex.Message);
    }
}

private void btnbrowse_Click(object sender, EventArgs e)
{
    OpenFileDialog dlg = new OpenFileDialog();
    if (dlg.ShowDialog() == DialogResult.OK)
    {
        txtattachment.Text = dlg.FileName.ToString();
    }
}

Create the attachment after checking the file path is correct and attach it to the message, don't attach to the message if the file is not present

Posted 30-Jan-15 2:30am

balajidileepkumar

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2015-01-30T02:04:00

The problem is here:

C#

Attachment data = new Attachment(txtattachment.Text);
if (txtattachment.Text == "")
{
    msg.Attachments.Add(data);
    client.Send(msg);
}
else
{
    msg.Attachments.Add(data);
    client.Send(msg);
}

You're creating an Attachmment even if the user hasn't selected a file, which will throw an ArgumentNullException. You then have an if..else block to test whether the user has selected a file, but the content of both branches is identical.

Try this:

C#

if (!string.IsNullOrEmpty(txtattachment.Text))
{
    Attachment data = new Attachment(txtattachment.Text);
    msg.Attachments.Add(data);
}

client.Send(msg);