C / C++ / MFC

lastgen wrote:

Also either call
memset(m_FileName,0,(strlen(FileName)+1));
after the new,

or call
m_FileName[strlen(FileName)] = '/0';

after strcpy.

Cedric Moonen wrote:

Nope. strcpy will copy the terminating zero so you don't need to do it yourself.

class MemLeak
{
  char *pFile;
 public:

 void allocatemem()
{
pFile=new char[100];
}

~MemLeak()
{
  if(pFile)
  delete []pFile;
}

};

MemLeak a;
 a.allocatemem() ;// Allocated 100 byte

MemLeak a;
 a.allocatemem() ;// Allocated 100 byte
 a.allocatemem() ;// ohh allocated another 100 byte without deleting 
                     // previously held byte

 class MemLeak
{
  char *pFile;
 public:
 MemLeak()
{
pFile=NULL;
}

 void allocatemem()
{
 if(pFile)
  delete [] pFile;

  pFile=new char[100];
}

~MemLeak()
{
  if(pFile)
  delete []pFile;
}

};

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

Cedric Moonen wrote:

But still, your suggestion is good: memory leaks are a bad programming practice

I get a error at the delete keyword ,
Damage After normal Block 0x00000034
am i wrong some where 

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

ThatsAlok wrote:

this type of error/message usually occur when there is memroy leak...

ThatsAlok wrote:

Hows your Xmas prepartion going on.... Marry Xmas

Cedric Moonen wrote:

this type of error occur when the pointer of your array has been corrupted (there are some bytes in front of your data that contains information about your array, such as the size and things like that, and these bytes are being overwritten).

Cedric Moonen wrote:

Lot of things to do during these holidays (visiting families and things like that). Merry Christmas to you also !

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

class MyClass<br />
{<br />
   char Temp1[10];<br />
   char Temp2[10];<br />
}

vikas amin wrote:

many times i have just done it once

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

vikas amin wrote:

In my class the code is as


char *m_FileName;
m_FileName=new char[strlen(FileName)];
strcpy(m_FileName,FileName);

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

ThatsAlok wrote:

are you calling this code in Constructor or some where else... You have delete memory every time you allocate it.. it seems you allocating memory many times but deallocating only one time, at time of destruction.

lastgen wrote:

Good point using the example code I gave earlier the fix would be to add this to the MyClass class

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow