C / C++ / MFC

//in header.h
LPSTR pMyLpstr;
.
//in constructor
pMyLpstr = NULL;
.
//in your code
LPTSTR COperDialog::ConvertResourceStringIdToLptstr(UINT nResString)
{
   CString strLoad;
   strLoad.LoadString(nResString);
   pMyLpstr = new TCHAR[strLoad.GetLength()+1];
  CHECK_FOR_NULL(pMyLpstr)
   _tcscpy(pMyLpstr,strLoad);
   return pMyLpstr;
}
.
//
void COperDialog::AddProjectRootItem()
{
   TV_INSERTSTRUCT curTreeItem;

   curTreeItem.hParent =TVI_ROOT ;
   curTreeItem.hInsertAfter = TVI_ROOT ;
   curTreeItem.item.iImage = 0;
   curTreeItem.item.iSelectedImage = 0;

   curTreeItem.item.pszText = ConvertResourceStringIdToLptstr(IDS_PROJECT);
//once you dont need it anymore
   delete [] pMyLpstr;
   pMyLpstr = NULL;

   curTreeItem.item.cchTextMax=15;

   curTreeItem.item.mask = TVIF_IMAGE | TVIF_SELECTEDIMAGE | TVIF_TEXT;

   htrProjectRoot = m_Edit->InsertItem(&curTreeItem); 
}
.
// To be sure... in the destructor or destroywindow another time
delete [] pMyLpstr;
pMyLpstr = NULL;

Greetings.

--------
M.D.V.

If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
“The First Rule of Program Optimization: Don't do it. The Second Rule of Program Optimization (for experts only!): Don't do it yet.” - Michael A. Jackson

CPallini wrote:

Probably it would be better if both memory allocation and deallocation are delegated to the caller (e.g. the standard behaviour of Windows API).

const int SIZE = 256;
TCHAR * buffer = new TCHAR[SIZE];

if ( buffer)
{
  GetWindowText(hWnd, buffer, SIZE);
}

if (buffer) delete buffer;
buffer = NULL; // invalidate the pointer

LPTSTR COperDialog::ConvertResourceStringIdToLptstr(UINT nResString, LPSTR pStr)   //parameter added
{
   CString strLoad;
   strLoad.LoadString(nResString);
   pStr = new TCHAR[strLoad.GetLength()+1];
   CHECK_FOR_NULL(pStr)
   _tcscpy(pStr,strLoad);
   return pStr;
}
//
void COperDialog::AddProjectRootItem()
{
   TV_INSERTSTRUCT curTreeItem;
   curTreeItem.hParent =TVI_ROOT;
   curTreeItem.hInsertAfter = TVI_ROOT;
   curTreeItem.item.iImage = 0;
   curTreeItem.item.iSelectedImage = 0;
;  
   //New Version
   LPSTR pMyLpstr = NULL;   
   curTreeItem.item.pszText = ConvertResourceStringIdToLptstr(IDS_PROJECT, pMyLpstr);
;
   delete [] pMyLpstr;      pMyLpstr = NULL; //As it was
   curTreeItem.item.cchTextMax=15;
   curTreeItem.item.mask = TVIF_IMAGE | TVIF_SELECTEDIMAGE | TVIF_TEXT;
   htrProjectRoot = m_Edit->InsertItem(&curTreeItem);
}

Greetings.

--------
M.D.V.

If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
“The First Rule of Program Optimization: Don't do it. The Second Rule of Program Optimization (for experts only!): Don't do it yet.” - Michael A. Jackson

Nelek wrote:

Maybe something like this?

Nelek wrote:

LPTSTR COperDialog::ConvertResourceStringIdToLptstr(UINT nResString, LPSTR pStr) //parameter added

int GetWindowText( HWND hWnd,  LPTSTR lpString, int nMaxCount );

CPallini wrote:

int GetWindowText( HWND hWnd, LPTSTR lpString, int nMaxCount );

The above function doesn't allocate the buffer, it relies on the one allocated by the caller.

Greetings.

--------
M.D.V.

If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
“The First Rule of Program Optimization: Don't do it. The Second Rule of Program Optimization (for experts only!): Don't do it yet.” - Michael A. Jackson

Nelek wrote:

And what is the difference with my second option? That the new is inside the function that is being called?

CPallini wrote:

On the other hand, I insist on saying that yours is a viable solution.

Greetings.

--------
M.D.V.

If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
“The First Rule of Program Optimization: Don't do it. The Second Rule of Program Optimization (for experts only!): Don't do it yet.” - Michael A. Jackson

Nelek wrote:

I like to programm against idiots

Nelek wrote:

I actually studied electronic engineering not informatic. But that doesn't mean that I may not be able to be a good programer, if I learn with the bests.

...
CString strLoad;
strLoad.LoadString(nResString);
curTreeItem.item.pszText =(LPTSTR)(LPCTSTR) strLoad;
...

Priya_Sundar wrote:

I need to apply this for some 50 strings

int LoadString( HINSTANCE hInstance, UINT uID, LPTSTR lpBuffer, int nBufferMax);

{
  const int SIZE=1000; // whatever number you need
  TCHAR buffer[SIZE];

  // load string 1
  LoadString( hInstance, uID1, buffer, SIZE);
  // insert item 1
  ...  
 
  // load string 2
  LoadString( hInstance, uID2, buffer, SIZE);
  // insert item 2
  ...
  // load string N
  LoadString( hInstance, uIDN, buffer, SIZE);
  // insert item N
  ...
}

dadacncn wrote:

char regValue[20];

DWORD dwRegValueBack;

dadacncn wrote:

RegQueryValueEx(hkey,L"V1",0, &dataType,(LPBYTE)regValue,&nSize);

RegQueryValueEx(hkey,L"V1",0, &dataType,(LPBYTE)&dwRegValueBack,&nSize);

dadacncn wrote:

printf("\nregvalue: %d", atol(regValue)); //the output is: regvalue: 0

printf("\nregvalue: %d", dwRegValueBack);