|
Nothing.
The problem is, that items with nIDNewItem=0 (created by AppendMenu) are OK, but when i pass parameter greater then 0 to this function these items are disabled. This is the ONLY difference between these items. And more: I can add some items with nIDNewItem=0 and some with nIDNewItrm>0 in the same menu and only those with nIDNewItem>0 will be disabled (this is a popup menu with no submenus).
By the way - I've tested some negative ID values - -1000,-2000 and -3000 were enabled and -10000,-20000,-30000 were grayed. Funny thing, but it drives me crazy!
Is there any way to check the user's choice without processing the WM_COMMAND message? I didn't notice that CMenu class has any kind of GetSelectedItem method, so I doubt it, but it would be the simpliest way.
Anyway thanks for the answer. It's good that someone answered.
Greetings to all assembler dudes and especially for C64 demoscene!
|
|
|
|
|
Those IDs have to have some command handler associated with them. Are you processing, for instance, ID_INSERT_ATTRIBUTE in any way?
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
I was supposed to, but I don't do that now since these items are "disabled" - can this really be it?
I thought, that if I don't do the processing itself, these items will be available, but they will affect no action when clicked - just that. Do I have to "create" commands somehow?!?!? Right now i'ts only:
#define ID_INSERT_ATTRIBUTE <value>
And the parent window's OnCommand method is almost empty (processes only ID_INSERT_ATTRIBUTE for testing).
Greetings to all assembler dudes and especially for C64 demoscene!
|
|
|
|
|
Yes you have to create those commands. Define them as WM_USER plus some offset of your choice. To implement a handler, take a look at the documentation for ON_COMMAND.
Also, you can use FALSE as the second parameter of GfxCmdUIUpdateMenu (this won't make the commands be handled, but at least you'll see the menu entries enabled.)
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Didn't work too.
I had these commands defined with #define directive.
I've changed them to WM_USER+n, and tried it in few different ways - no effect.
Both using that function with bDisableIfNoHndler set to TRUE and FALSE and without that function.
I'm running out of ideas.
I'm gonna get some sleep (it's 23:30 in Poland and I've got back from the pub recently  ).
Bye.
I'll be back tomorrow.
Thanks for the effort.
Greetings to all assembler dudes and especially for C64 demoscene!
|
|
|
|
|
Not only do the commands have to be defined, there also must be handlers for them (with ON_COMMAND).
As for why bDisableIfNoHndler does not work, I don't know. I guess I'll have to get some sleep too.
Good night 
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Why not subclass CMenu with CMyCMenu and define the commands and define the handlers in it's message map?
Or in your mainframe class define a handler in the message map like:
ON_COMMAND(ID_APP_DOTHIS, DoFunction)
Would either of those be possible?
|
|
|
|
|
I guess this conversation led us to a dead end.
I'll just start it almost from beginning,cause the problem is unusual for me and from the answers I got, i haven't found out anything yet. Anyway thanks everybody for trying to help me. Here we go:
Take a look at my code, and see what is it all about:
Version 1:
#define ID_EDIT_ATTRIBUTE WM_USER+1
Menu->AppendMenu(MF_STRING | MF_ENABLED, ID_EDIT_ATTRIBUTE, "Edit criterion"); //item is grayed
Version 2:
Menu->AppendMenu(MF_STRING | MF_ENABLED, 0, "Edit criterion"); //item is not grayed but has no command assigned
I've used these two message boxes for testing:
if (Menu->GetMenuItemID(0)==ID_EDIT_ATTRIBUTE)
MessageBox(NULL, "OK", "Item ID", MB_OK);
if (Menu->EnableMenuItem(0, MF_ENABLED | MF_BYPOSITION)==MF_ENABLED)
MessageBox(NULL, "OK", "Enabled?", MB_OK);
Both of them are appearing before TrackPopupMenu, but "Enabled?" does not appear right after TrackPopupMenu.
Conclusion: TrackPopupMenu disables these items, but why does it not accept these command ID's?
By the way - I'm using that PopupMenu in a class not derieved from anything (so it's not a CWnd class), but i pass the parent window pointer:
Menu->TrackPopupMenu(TPM_LEFTALIGN | TPM_RIGHTBUTTON | TPM_LEFTBUTTON, Point.x, Point.y, ParentWindow);
Right now I'm processing only the ID_EDIT_ATTRIBUTE command in my OnCommand method (just for testing).
The question again: Why does it NOT accept my command ID? 
Greetings to all assembler dudes and especially for C64 demoscene!
|
|
|
|
|
Because, by default, MFC disables menu items that don't have command handlers implemented somewhere in the message map of the parent windows of the menu.
You need to add a proper command handler (preferably not in OnCommand, although you can do, you just have to make sure you handle all the parameters properly, including the extra pointer value, and return the correct value) in the window that you specify as a parent in TrackPopupMenu.
If you need to change the enabled state of the menu item based on program conditions, you should be using an UPDATE_COMMAND_UI handler as well.
For a very detailed explanation of the command routing architecture and command UI update handlers, see Meandering Through the Maze of MFC Message and Command Routing by Paul DiLascia, an excellent article that I've recommended here before.
"We are the knights who say Ni" (The Knights Who Say Ni)
|
|
|
|
|
I think I've solved the problem.
Thanks everybody for your effort. I appreciate it.
My solution:
1. throw out that dynamic creation of menu items
2. create all my popup menus as one resource
3. Use the following:
CMenu MenuGroup;
MenuGroup.LoadMenu(IDR_POPUP_MENUS);
Menu=MenuGroup.GetSubMenu(<number of="" popup="" menu="" to="" use="">);
Menu->TrackPopupMenu(...);
Now I can use the class wizard to handle my menu commands.
I still feel strange about these grayed items. I think disabling them should not be the default action when there is no message handler - it would be better (as for me) to leave them enabled and take no action when user clicks them.
Well, I guess I'll never understand Mircosoft's way of coding.
Thank you very much again. ![Rose | [Rose]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/rose.gif)
Greetings to all assembler dudes and especially for C64 demoscene!
|
|
|
|
|
It´s better to gray them out, so that even the managers know that it won´t work.
|
|
|
|
|
How the he@@ can I get the video adapter's name as shown in
'Display properties' dialog ( e.g.: 'Rege Fury/Xpert128/Xpert 2000' )???
Respect...
--BlackSmith--
"With the help of all mighty", 2001, Me.
|
|
|
|
|
With <a href="http://msdn.microsoft.com/library/default.asp?url=/library/en-us/gdi/devcons_2303.asp">EnumDisplayDevices</a> (not supported in Windows 95 and NT).
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
In certain situations I want to go right to a dialog after loading a dialog, and I'm wondering how to do this such that the parent dialog is drawn on screen first. For instance, I have dialog A with a button which, when clicked, loads another dialog B. In certain situations I want to pop up this child dialog B right away, as though the user clicked the button. If I set to true a member variable in dialog A, m_bPopupBRightAway, before calling DialogA::DoModal() and check this value at the end of DialogA::OnInitDialog(), dialog A isn't yet drawn on the screen when DialogB comes up. What's the best way to go about doing this so that I get the desired result?
Thanks!
- Jason
(SonorkID 100.611)
In the beginning, teachers taught the 5 W's: who, what, where, when, why. Now it's just a big damn G
|
|
|
|
|
void CMyDlg::OnPaint()
{
if (IsIconic())
{
...
}
else
{
CDialog::OnPaint();
if(m_bFirstTime){
m_bFirstTime=FALSE;
...
}
}
}Where m_bFirstTime is a member variable of the dialog initialized to TRUE.
Another method, suggested by Shog9, is to self-post a user-defined message from OnInitDialog in response to which the second dialog is launched.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Joaquín M López Muñoz wrote:
Another method, suggested by Shog9, is to self-post a user-defined message from OnInitDialog in response to which the second dialog is launched.
Ooh, I like it. Thanks a lot!
- Jason
(SonorkID 100.611)
In the beginning, teachers taught the 5 W's: who, what, where, when, why. Now it's just a big damn G
|
|
|
|
|
I thought I saw a thread on this once but couldnt track it down. I need to know how to get the height of the title bar of a CDialog dlg box. Is it the same function that will return the height for an MDI chld window?
Thanks,
ns
|
|
|
|
|
GetSystemMetrics(SM_CYCAPTION) should do, unless your dialog has somehow changed the default.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
If I call it from a certain dlg class (say in initdialog) this will then return the caption height of the object for that particular class? I guess I'm thinking I dont see something like:
pDlg->GetSystemMetrics, rather it looks like ::GetSystemMetrics, so I was wondering how it knows whose caption height to get. Is it the height of (this)?
Much appreciate your suggestions,
ns
|
|
|
|
|
To the best of my knowledge, all windows have the same caption height (or no caption at all). Windows with nonstandard captions are faking the effect by omitting the system-provided caption and painting something similar on the client area.
If I'm wrong, please someone correct me.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Howdy everyone,
Quick STL question for y'all...
I'm having lots of fun  converting some old code from C arrays to std::vectors.
I've got a bool *m_abMatched, and at the start of a function the array must be initialised to false. At the moment this is done with memset( m_abMatched, false, m_cbMatched*sizeof(bool) ).
If I replaced the array with a std::vector<bool> how would I set all the elements of the vector to false? Is m_abMatched::assign( m_abMatched.size(), false ) the correct approach?
TIA,
Pete
|
|
|
|
|
Yes, this is correct.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
|
|
|
|
|
Joaquin to the rescue again 
Thanks!
|
|
|
|
|
it may be correct. but it is an absolutely horrible thing to do, IMO.
To explain Donald Knuth's relevance to computing is like explaining Paul's relevance to the Catholic Church. He isn't God, he isn't the Son of God, but he was sent by God to explain God to the masses.
/. #3848917
|
|
|
|
|
how so? What would be a better technique???
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
