|
|
I just came across the following comment in some code I need to modify that was written in 2008:
Sigh  .
Software Zen: delete this;
|
|
|
|
|
I am not sure, given all that explanation, it it still qualifies as a magic number. Even the word 'sin' in heavy handed here, it's not like K&R bracing... runs and hides 
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
|
|
|
|
|
jeron1 wrote: K&R bracing
Everyone knows that Allman bracing is The One True Way.
Software Zen: delete this;
|
|
|
|
|
Amen!
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
|
|
|
|
|
I prefer K&R in C and C++
I prefer Allman in C# and most other high level languages.
Don't ask me why. I think it's just because I've gotten so used to *reading* code in those formats that I write it in those formats.
Check out my IoT graphics library here:
https://honeythecodewitch.com/gfx
And my IoT UI/User Experience library here:
https://honeythecodewitch.com/uix
|
|
|
|
|
I was a K&R guy until I started using C#. I use blank lines in my code to separate conceptual 'blocks'. It also helps reading code with my visual issues. Allman bracing provides that separation a lot of times without introducing extra vertical space. Using Allman for both languages just seems more natural for me now.
One of the reasons I keep VS2008 around is the macro language. I have a macro that does 99% of the work converting from K&R to Allman, without rewrapping text and expressions like the Visual Studio reformatters tend to do.
Software Zen: delete this;
|
|
|
|
|
You can do that with VS Code as well. It's a bit fiddly to change the C/C++ bracing and indent styles, but nothing a little google fu can't clear up. Then you just hit "Format Document" and bob's your uncle.
I guess since I'm used to using different case styles for different languages, it's not as much of a stretch for me to adapt to different bracing?
For me, C and C++ just seem more "natural" in K&R and C# just seems more natural to me in Allman. Feel and flow for me - the final form is just easier for me if I do it this way. I don't know WHY C# would be different than C or C++ for me that way, except exposure. I'm so used to seeing Allman C# and K&R C/C++ that it's familiar to me. That must be it, I think.
Check out my IoT graphics library here:
https://honeythecodewitch.com/gfx
And my IoT UI/User Experience library here:
https://honeythecodewitch.com/uix
|
|
|
|
|
|
Thank you very much, I'm so relieved, that I'm not the only one.
I think after 30 years I can fill much more than 50 pages of such comments 
The only excuse I have; it was always just to satisfy the customer.
But that doesn't really help when you come across it again 
|
|
|
|
|
I've always liked something Dan Saks, onetime Secretary of the ANSI/ISO C++ Standards Committee, once said: "If you can say it in code, then do so. Otherwise, say it in a comment."
To my mind that means comments should usually describe the why or the how code is doing something, and rarely what. My longer-winded comments are usually 'why'.
Software Zen: delete this;
|
|
|
|
|
|
I think I had foreknowledge(*) how dotty I would be in my old age.
(*) Cue the obvious Dune reference; "He who controls the spice, controls the universe!"
Software Zen: delete this;
|
|
|
|
|
But do you now know the "proper" way to do this and will you fix the issue?
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.
I’m begging you for the benefit of everyone, don’t be STUPID.
|
|
|
|
|
I have reached the stage in my career (3.75 years until retirement), plus given my typical workload, that fixing this would be a poor use of my time. It works well enough and has never caused an issue.
Besides, given how little love Microsoft has given WPF over the years, I doubt there is a better way to do it  .
Software Zen: delete this;
|
|
|
|
|
Gary Wheeler wrote: magic number 48
Isn't it 42?
|
|
|
|
|
This is actually a really good comment. It explains both the why and the what/how. I wouldn't call this a sin, but rather a reminder of why you did something the way you did.
|
|
|
|
|
Allman almost all the time.
"A little time, a little trouble, your better day"
Badfinger
|
|
|
|
|
I am rendering everything correctly so far in my tests, except gradients which I'm still implementing, and I hate the math. Oh, I hate the math.
But I've gotten to the point where I'm over the hump. SVGs I expect will render are rendering. Now it's just a matter of fleshing the rest out, with the gradients being probably the most difficult bit.
In part because gradient definitions are often (always?) declared across multiple tags, with xlink:href linking them in XML.
In part because you can limit the gradient positioning to the local bounding box of the shape, and specify widths, heights, radiuses, and offsets in things like percentages or even mm. It's basically like CSS.
In large part, because I have two reference implementations, but neither is going to quite work for the way I'm doing this, because I'm rendering strictly top-down, not keeping the XML nor the shapes I parse in memory. I render and I toss.
Anyway, it's a little bit overwhelming at the moment, but I still feel pretty good about the progress I've made.
Check out my IoT graphics library here:
https://honeythecodewitch.com/gfx
And my IoT UI/User Experience library here:
https://honeythecodewitch.com/uix
|
|
|
|
|
That's the first test I can remember failing since I was 10 or so.
According to the graph I have trouble hearing the frequencies that human voices mostly use. Clearly, I've been listening to the wrong people for years ... 
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
I've had the same problem + ringing in ears for 55 years.
My SO is just in the frequency range where I have a very hard time understanding her.
She's been very patient with me.
A home without books is a body without soul. Marcus Tullius Cicero
PartsBin an Electronics Part Organizer - Release Version 1.4.0 (Many new features) JaxCoder.com
Latest Article: EventAggregator
|
|
|
|
|
Same here, I've been wearing hearing aids for a couple of years now. At my latest test the graph even showed which letters of the alphabet were the problem.
|
|
|
|
|
So did mine, but it was all of them ...
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
OriginalGriff wrote: That's the first test I can remember failing since I was 10 or so.
Study harder.
I once studied an entire weekend for a urine test.
|
|
|
|
|
I wouldn't consider that a failure.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
