The Weird and The Wonderful

CIDev wrote:

Yes, the current developers always get the heat for things that may have been done years before they even started working at the company. Such is life

CIDev wrote:

I normally "tweak" or just plain replace old code that may work, but is really bad code. I don't always have enough time to replace as much bad code as I would like, but I do it whenever possible.

dojohansen wrote:

the additional semi-colons

function f() 
{
   a = 5;
   ++i;
}

var f = function()
{
   a = 5;
   ++i;
};

dojohansen wrote:

I declare war on copy-paste "programmers" the world over!

VentsyV wrote:

Whats wrong with the semi-colons; I put semi-colons everywhere; It is a C/C++ thing;

function copyChildNodes(srcNode, destNode, nodeList, ignoreMissingNodes)
{
   for (var i=0; i < nodeList.length; i++)
   {
      var node = srcNode.selectSingleNode(nodeList[i]);
      if (!node)
      {
         if (ignoreMissingNodes) 
            continue;
         else 
            throw {message: "No child node with name '" + nodeList[i] + "' exists in the source node."};
      }
      destNode.appendChild(node.cloneNode(true));
   }
}

var nodes = ["block_name", "block_type", "title", "list_id", "you", "get", "the", "point"];
copyChildNodes(oXMLBlock, oXMLRecord, nodes, true);

dojohansen wrote:

My real gripe however is the code redundancy. If you intend to perform the same operation 20 times over you should use the same implementation 20 times, so it's possible to change the darn thing without getting bored to death.

Graham Bradshaw wrote:

And when you add another button, and the seventeenth ID is already used for something else, you have a whole heap of work to do.