|
BobJanova wrote: Anyone spot any more?
No need to set a string to return from the function. A simple return "AM"; or return "PM"; would suffice.
I'm not a programmer but I play one at the office
|
|
|
|
|
That's not really so much a horror as a stylistic choice, though one which I would also change as you have suggested there. Some people say that a single point of return is better because you don't have to look through the whole function to find escape points, and though I disagree with that (for one thing your function should be short enough it isn't a problem) I can see what they're getting at.
|
|
|
|
|
I disagree with the single point of return as well. To me it requires some degree of convoluting the code just to reach that point. I tried that approach for a while but I found myself having to add code rather than getting straight to the purpose of it. But then I've always tried to avoid having to take those few extra CPU cycles to get from point A to point B if point A++ gets the job done faster.
I'm not a programmer but I play one at the office
|
|
|
|
|
This is why you should never work past 24.01h.
Giraffes are not real.
|
|
|
|
|
maybe the programmer was paid by the line
|
|
|
|
|
Dude
You got to be making that up!
"To alcohol! The cause of, and solution to, all of life's problems" - Homer Simpson
|
|
|
|
|
The AM/PM suffix only makes sense on a 12-hour system, not a 24-hour clock. If you use an 24-hours based day, you already know whether the time is in the morning or evening. Otherwise, the 8 O'Clock needs the AM/PM suffix to discriminate between 8:00 (8 AM) and 20:00 (8 PM).
It's a ridiculous format, and that mistake is as grave as the function is coded. It'd be best to use the date-format as specified in the users' settings, or to use a predefined format. Making up your own format requires owning a country.
Bastard Programmer from Hell
|
|
|
|
|
Eddy Vluggen wrote: The AM/PM suffix only makes sense on a 12-hour system
true
|
|
|
|
|
Or... Assuming the string has only military time with no date:
string strReturn = DateTime.Parse(DateTime.MinValue.ToString("MM/dd/yyyy ") + strTime).ToString("tt");
If it has date and time:
string strReturn = DateTime.Parse(strTime).ToString("tt");
Kevin Rucker, Application Programmer
QSS Group, Inc.
United States Coast Guard OSC
Kevin.D.Rucker@uscg.mil
"Programming is an art form that fights back." -- Chad Hower
|
|
|
|
|
your solution is different from original.
What if the parameter string is not a number or number any other than one in switch?
The original will return empty string while yours - eather throw or return PM instead.
|
|
|
|
|
I know what you mean mate... the solution I put was just to show that whole function can be redundant. If I have to code it I will make sure of all exception and validations on client and server...
Zen and the art of software maintenance : rm -rf *
Math is like love : a simple idea but it can get complicated.
|
|
|
|
|
You should focus on making it future-proof.
I wanna be a eunuchs developer! Pass me a bread knife!
|
|
|
|
|
This is a little game.
Someone in CodeProject wrote this:
I'll let you guess what this does and how it should be named:
static int f(int v)
{
unchecked
{
v--;
v |= v >> 1;
v |= v >> 2;
v |= v >> 4;
v |= v >> 8;
v |= v >> 16;
v++;
}
return v;
}
For the record when I posted this I promise did not realize that previous post was speaking about the exact same thing.
How extraordinary is this?
|
|
|
|
|
Pascal Ganaye wrote: guess what this does
Checks if Leslie Nielsen is dead or not?
Panic, Chaos, Destruction. My work here is done.
Drink. Get drunk. Fall over - P O'H
OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre
I cannot live by bread alone. Bacon and ketchup are needed as well. - Trollslayer
Have a bit more patience with newbies. Of course some of them act dumb - they're often *students*, for heaven's sake - Terry Pratchett
|
|
|
|
|
Round up to the next highest power of 2, written by Jacek Gajek, in the message bellow.
yes, i'm not funny
|
|
|
|
|
You should probably have waited until it wasn't the previous thread anymore
|
|
|
|
|
I can't really believe it.
I found this code in a string library I had downloaded from code project a few days before.
I had not read the previous post.
What are the odds? This is spooky.
|
|
|
|
|
Long back i saw this code chunk which was causing alot of issue once a while, unfortunately that code did not had proper logs/comments/exception catching mechanisms involved. So we did had to spend atleast half a day to find it..
class MyClass
{
static int value = 10;
static int Value { get { return Value; } }
}
At first it was a bit difficult to find where stackoverflow exception was occuring and then i was wondering what made the original developer do this stupid way and released with out even testing.
My Blog -> https://adventurouszen.wordpress.com/
|
|
|
|
|
I don't know if this also applies to static properties but I had once a similar case in a normal instance property. The main issue for me was that Visual Studio (I think it was 2003) crashed when I tried to debug code where this class was used. Why? Because the debugger tried to show the Value in the Watch-window and couldn't handle the StackOverflowException.
|
|
|
|
|
I've done that myself before. One of the reasons I like to use m_value and Value.
When it comes to pay the rent no matter what [...] I just blew a tranny [...] you do what you gotta do.
|
|
|
|
|
true and every mistake teaches us a lesson and this is one of those which changed my naming convention style of fields.
My Blog -> https://adventurouszen.wordpress.com/
|
|
|
|
|
Even Resharper advises you to use _value.
|
|
|
|
|
Pretty normal mistake although its kind of weird how it made it into release unless this bit of code is only run when some very obscure corner case or feature is hit...
I'm sure there is some good reason ($$$) why the C# team haven't implemented it but I still wonder why the compiler doesn't throw a warning in such cases...
modified 6-Jan-12 16:10pm.
|
|
|
|
|
well thats where one good programmer needs to improve his coding practices. Other wise such normal mistakes keep happening. Yep its true that it went to a production code.
Lets not depend fully over compiler, even programmers have to be a bit more smart too
My Blog -> https://adventurouszen.wordpress.com/
|
|
|
|
|
This often happens if you type the method before declaring the variable.
return value; will get corrected by the ide to:
return Value; when the ; is typed.
That does not excuse the original developer for not checking it.
It is also looks far too compressed to me having the entire property on one line, although that is a matter of formatting standards, I guess.
|
|
|
|