Click here to Skip to main content
16,011,680 members
Home / Discussions / Web Development
   

Web Development

 
GeneralRe: Refresh frame with javascript Pin
Sage16-Oct-03 8:42
Sage16-Oct-03 8:42 
GeneralRe: Refresh frame with javascript Pin
chubbysilk16-Oct-03 11:16
chubbysilk16-Oct-03 11:16 
GeneralDestroy all variables on exit Pin
Brendan Vogt13-Oct-03 3:20
Brendan Vogt13-Oct-03 3:20 
GeneralRe: Destroy all variables on exit Pin
ZoogieZork14-Oct-03 12:19
ZoogieZork14-Oct-03 12:19 
GeneralSERVER-SIDED VALIDATION CHECKUP PLS Pin
Brendan Vogt13-Oct-03 3:16
Brendan Vogt13-Oct-03 3:16 
GeneralRe: SERVER-SIDED VALIDATION CHECKUP PLS Pin
markkuk13-Oct-03 3:35
markkuk13-Oct-03 3:35 
GeneralRe: SERVER-SIDED VALIDATION CHECKUP PLS Pin
Brendan Vogt13-Oct-03 3:41
Brendan Vogt13-Oct-03 3:41 
GeneralRe: SERVER-SIDED VALIDATION CHECKUP PLS Pin
Mike Dimmick13-Oct-03 4:04
Mike Dimmick13-Oct-03 4:04 
Functionally it looks OK, but you have a number of potential security problems.

Firstly, you're storing your passwords in plain text in the database, which allows an attacker who can inspect your database to impersonate any user. It's typically better to use some form of hashing in order to prevent a direct attack. Look at the CAPICOM API for use of cryptographic hashing functions.

Your maximum limit on passwords seems quite short, and your minimum limit is very short. There are ways of computing the effective bit length of a password, which suggest that a 20 character password can only be considered equivalent to a 128-bit symmetric encryption key if the password includes both upper and lower case letters, digits and punctuation marks.

Your use of string concatenation to build a SQL string is very weak and could subject you to SQL injection attacks. For example, if an attacker typed
' DROP tblUser --
your strSQL would end up as
SELECT User_Username, User_Password FROM tblUser WHERE 
User_Username = '' DROP tblUser --';
The comment operator -- prevents the trailing quote mark from causing a syntax error. This would then cause a denial of service to all valid users. You should not trust user data in this way - any user data. It is generally better to use regular expressions to define the set of characters allowed in inputs.

You can mitigate the problem by using an ADO Command object with a collection of parameters, which will cause ADO and the database engine to perform any quoting necessary.

Finally, and I'll admit this one is a bit contentious, you may be giving too much information away in case of failure - you inform the user whether the username or the password was incorrect. This allows an attacker to narrow the problem set - first he has to find the username, then the password. If you don't indicate which is incorrect, the attacker has to generate all possible passwords for all possible usernames, or use some kind of social engineering to discover one or both.

If you decide to do this, you might decide to get the database to perform all the comparisons:
SELECT User_Username FROM tblUser WHERE User_Username = ? AND User_Password = ?
where the ? represent parameters.
GeneralRe: SERVER-SIDED VALIDATION CHECKUP PLS Pin
Brendan Vogt15-Oct-03 2:41
Brendan Vogt15-Oct-03 2:41 
GeneralRe: SERVER-SIDED VALIDATION CHECKUP PLS Pin
Mike Dimmick15-Oct-03 4:03
Mike Dimmick15-Oct-03 4:03 
General,Highliting text Pin
Srikar Y12-Oct-03 18:15
Srikar Y12-Oct-03 18:15 
GeneralPERL: changing file description Pin
brianwelsch12-Oct-03 15:17
brianwelsch12-Oct-03 15:17 
GeneralRe: PERL: changing file description Pin
ZoogieZork12-Oct-03 16:21
ZoogieZork12-Oct-03 16:21 
GeneralVS 6 Install Pin
AEKirin12-Oct-03 1:36
professionalAEKirin12-Oct-03 1:36 
GeneralRe: VS 6 Install Pin
ZoogieZork12-Oct-03 6:25
ZoogieZork12-Oct-03 6:25 
QuestionHow to retain the previous field value, when Pin
samhita11-Oct-03 1:34
samhita11-Oct-03 1:34 
AnswerRe: How to retain the previous field value, when Pin
Blake Coverett11-Oct-03 10:22
Blake Coverett11-Oct-03 10:22 
GeneralRe: How to retain the previous field value, when Pin
samhita12-Oct-03 18:09
samhita12-Oct-03 18:09 
GeneralRe: How to retain the previous field value, when Pin
Not Active14-Oct-03 8:29
mentorNot Active14-Oct-03 8:29 
GeneralDisplaying \ Pin
samhita11-Oct-03 1:28
samhita11-Oct-03 1:28 
GeneralRe: Displaying \ Pin
Mike Ellison11-Oct-03 18:20
Mike Ellison11-Oct-03 18:20 
GeneralRe: Displaying \ Pin
samhita12-Oct-03 20:20
samhita12-Oct-03 20:20 
GeneralRe: Displaying \ Pin
ZoogieZork14-Oct-03 12:30
ZoogieZork14-Oct-03 12:30 
QuestionHow do you convert localhost to a url? Pin
Leprosy9-Oct-03 7:06
Leprosy9-Oct-03 7:06 
AnswerRe: How do you convert localhost to a url? Pin
Amitux10-Oct-03 4:40
Amitux10-Oct-03 4:40 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.