Re: about ToolBar - C / C++ / MFC Discussion Boards

BigMouth12-Dec-01 1:47

12-Dec-01 1:47

- Thanks pal!

- I still have a question. Can you show me an example about the usage of TB_SETIMAGELIST message?

- Have a nice day,
BigMouth

Re: about ToolBar

Christian Graus12-Dec-01 10:27

Christian Graus

12-Dec-01 10:27

You can actually modify the imagelist directly - m_wndToolbar.GetToolbarCtrl().GetImageList() returns a pointer to the image list, and you can then use ExtractIcon to pull an image out, or Add or Replace to add an image or replace one respectively.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth12-Dec-01 18:41

BigMouth

12-Dec-01 18:41

- Thanks pal!

- I use the following codes, but it seems that it does not work.

void CMainFrame::OnEditCopy()
{
// TODO: Add your command handler code here
CImageList* list1=this->m_wndToolBar.GetToolBarCtrl().GetImageList();
list1->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));
}

- Can you help me out?

- Regards,
Maer

Re: about ToolBar

Christian Graus12-Dec-01 18:52

Christian Graus

12-Dec-01 18:52

I did this

m_wndToolBar.GetToolBarCtrl().GetImageList()->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));

CWindowDC w(NULL);
w.DrawIcon(0, 0, m_wndToolBar.GetToolBarCtrl().GetImageList()->ExtractIcon(list1->GetImageCount()-1));
AfxMessageBox("");

in OnCreate on a vanilla SDI app, and the icon is there, plain as day. You didn't expect to see it in the toolbar, did you ? It's in the image list, but you need to create a new button or change the image index of an existing button for the toolbar to show it.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth13-Dec-01 20:13

BigMouth

13-Dec-01 20:13

- Thanks pal!

- I use the following codes. But it has no effect.

int CMainFrame::OnCreate(LPCREATESTRUCT lpCreateStruct)
{
if (CMDIFrameWnd::OnCreate(lpCreateStruct) == -1)
return -1;

if (!m_wndToolBar.CreateEx(this, TBSTYLE_FLAT, WS_CHILD | WS_VISIBLE | CBRS_TOP
| CBRS_GRIPPER | CBRS_TOOLTIPS | CBRS_FLYBY | CBRS_SIZE_DYNAMIC) ||
!m_wndToolBar.LoadToolBar(IDR_MAINFRAME))
{
TRACE0("Failed to create toolbar\n");
return -1; // fail to create
}

if (!m_wndStatusBar.Create(this) ||
!m_wndStatusBar.SetIndicators(indicators,
sizeof(indicators)/sizeof(UINT)))
{
TRACE0("Failed to create status bar\n");
return -1; // fail to create
}

// TODO: Delete these three lines if you don't want the toolbar to
// be dockable
m_wndToolBar.EnableDocking(CBRS_ALIGN_ANY);
EnableDocking(CBRS_ALIGN_ANY);
DockControlBar(&m_wndToolBar);

CImageList* list1=this->m_wndToolBar.GetToolBarCtrl().GetImageList();
m_wndToolBar.GetToolBarCtrl().GetImageList()->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));
CWindowDC w(NULL);
w.DrawIcon(0, 0, m_wndToolBar.GetToolBarCtrl().GetImageList()->ExtractIcon(list1->GetImageCount()-1));
AfxMessageBox("");
return 0;
}

- Can you help?

- Have a nice weekend,
BigMouth

Re: about ToolBar

Christian Graus14-Dec-01 10:23

Christian Graus

14-Dec-01 10:23

What do you mean by no effect ? Like I said, this will add the image to the imagelist, and draw it on the top left of your screen in order to prove that it's there. But you've still not added a button with this image, so it's still not going to be on the toolbar. You need to fill a TBBUTTON structure with info including the index of this image, then call AddButton to add that button to the toolbar.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth14-Dec-01 18:23

BigMouth

14-Dec-01 18:23

- Thanks, Christian pal!

- Sorry, I have misunderstood your meaning before. I am a newbie of CToolBar. I have never modified it before. Now I find it is a hard work for me. So, if it does not take very much of your time, could you show me a simple example of your method? Smile | :)

- Have a nice weekend,
BigMouth

Re: about ToolBar

Christian Graus15-Dec-01 10:56

Christian Graus

15-Dec-01 10:56

Sure - this is how you'd add a button with the bitmap we've been putting into the image list, which calls OnFileNew:

int index = m_wndToolBar.GetToolBarCtrl().GetImageList()->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));
TBBUTTON btn;
btn.fsStyle = TBBUTTON;
btn.fsState = TBSTATE_ENABLED;
btn.idCommand = ID_FILE_NEW;
btn.iBitmap = index;

m_wndToolbar.GetToolBarCtrl().AddButtons(1, &btn);

Note we store the index of the image and pass it to the button, and we pass in the ID of the command we want the button to execute.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth15-Dec-01 21:01

BigMouth

15-Dec-01 21:01

- Thanks, Christian pal!

- I think the statement 'btn.fsStyle = TBBUTTON;' should be written like this 'btn.fsStyle = TBSTYLE_BUTTON;'. IMHO

- And there is still a trouble. When I am testing your codes, the new toolbar button has no image attached to it.

- Can you help?

- Regards,
BigMouth

Re: about ToolBar

Christian Graus16-Dec-01 9:51

Christian Graus

16-Dec-01 9:51

1. Absolutely correct, I posted in a hurry.

2. Then you've not set the image index to be the index of your new image in the image list.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth16-Dec-01 17:59

BigMouth

16-Dec-01 17:59

- Thanks, warm-hearted Christian pal! Smile | :)

- Can you tell me how to set the image index to be the index of my new image in the image list? I find the work is easy to think, but it is hard to implement for a newbie, like me. Smile | :)

- Can you help?

- Regards,
BigMouth

Re: about ToolBar

Christian Graus17-Dec-01 10:01

Christian Graus

17-Dec-01 10:01

OK - the line:

m_wndToolBar.GetToolBarCtrl().GetImageList()->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));

returns the index of the new image, and so that is the index iBitmap needs to be set to when creating the new button. The code I posted previously actually did that, you're saying it's not working ?

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth18-Dec-01 17:21

BigMouth

18-Dec-01 17:21

- Thanks, Christian!

- The method still has a problem. The newly added toolbar button has no image on it.

- Such are my codes: (OnCreate())

int index = m_wndToolBar.GetToolBarCtrl().GetImageList()->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));
TBBUTTON btn;
btn.fsStyle = TBSTYLE_BUTTON;
btn.fsState = TBSTATE_ENABLED;
btn.idCommand = ID_FILE_NEW;
btn.iBitmap = index;
m_wndToolBar.GetToolBarCtrl().AddButtons(index, &btn);
m_wndToolBar.GetToolBarCtrl().GetImageList()->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));

- Can you help me out?

- Regards,
BigMouth

Re: about ToolBar

Christian Graus18-Dec-01 17:31

Christian Graus

18-Dec-01 17:31

I don't understand what the last line is for, why add the icon again ?

I also don't get why you need to do it this way, given that GetImageList returns a pointer, but here is what you need:

CImageList * pList = m_wndToolBar.GetToolBarCtrl().GetImageList();
int index = pList->Add(AfxGetApp()->LoadIcon(IDR_MAINFRAME));
m_wndToolBar.GetToolBarCtrl().SetImageList(pList);
TBBUTTON btn;
btn.fsStyle = TBSTYLE_BUTTON;
btn.fsState = TBSTATE_ENABLED;
btn.idCommand = ID_FILE_NEW;
btn.iBitmap = index;
m_wndToolBar.GetToolBarCtrl().AddButtons(1, &btn);

Note that you pass the number of buttons to add to addbuttons, not the index ( which is not even necessarily the index of the button you're adding ).

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth18-Dec-01 21:52

BigMouth

18-Dec-01 21:52

- Thanks Christian!

- I tried your codes in the OnCreate function of an MDI app. It does not have the desired effect.

- Such is the effect:
1) It removes the 'help' toolbar button.
2) No new toolbar button appears.
3) All the toolbar button becomes a bit bigger.

- I do not know why? Have you tried your codes?

- Can you help, pal?

- Best regards and Merry Christmas to you,
BigMouth

Re: about ToolBar

Christian Graus19-Dec-01 0:59

Christian Graus

19-Dec-01 0:59

I tested this code on an app at work, and again now on another app at home. It works fine.

Try it again, and try also to take the time top understand *why* it works. That is the path to not having to ask next time, and also to being able to figure stuff out for yourself.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth21-Dec-01 23:49

BigMouth

21-Dec-01 23:49

- Thanks, Christian pal!

- Today, I run the app again. I find everything is Ok. But I never change the code!!! Just like yesterday!!!

- Ok, I am puzzled. Confused | :confused:

- Best regards,
BigMouth

Re: about ToolBar

BigMouth21-Dec-01 23:55

BigMouth

21-Dec-01 23:55

- Christian pal!

- I still have a question. How to do the same task from another class? Like the view class? Can you give me a sample code?

- Can you help me?

- Best regards,
BigMouth

Re: about ToolBar

Christian Graus22-Dec-01 12:53

Christian Graus

22-Dec-01 12:53

#include "MainFrm.h" at the top of the class, then

CMainFrame * pMain = (CMainFrame*)AfxGetMainWnd();

Then do it all the same, just access m_wndToolbar via pMain-> You may have to make it public, or make the view class a friend of CMainFrame.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth22-Dec-01 21:35

BigMouth

22-Dec-01 21:35

- Thanks, Christian pal!

- I do not know why the method sometimes does not run stablly. Sometimes it runs ok, sometimes it does not run ok.

- Can you tell me why it happens? Need I refresh something manually?

- Best regards,
BigMouth

Re: about ToolBar

Christian Graus23-Dec-01 10:20

Christian Graus

23-Dec-01 10:20

You need to run it when CMainFrame has been constructed and not destroyed.

When does it crash ?

You can do this:

CMainframe * pMain = dynamic_cast<cmainframe*>(AfxGetMainWnd());

if (pMain)
{
// use it here
}

This is how C++ does run time type information, and although it should *always* work in this case, it gives us a chance to catch if it doesn't. Whenever you request a pointer you should check it first, even if it's just with ASSERT.

Christian

After all, there's nothing wrong with an elite as long as I'm allowed to be part of it!! - Mike Burston Oct 23, 2001

Sonork ID 100.10002:MeanManOzI live in Bob's HungOut now

Re: about ToolBar

BigMouth24-Dec-01 2:41

BigMouth

24-Dec-01 2:41

- Thanks, Christian pal!

- I still have a question. I think your codes are added to the function OnCreate, so it is sure that the CMainFrame has been constructed.

- So I think there is no need to test whether the "pMain" is NULL. IMHO

- Can you help?

- Merry Christmas,
BigMouth

Dialog Box Problem

mvworld11-Dec-01 22:42

mvworld

11-Dec-01 22:42

I have a dialog based application which the user accesses through a password. Now there are 2 categories of users and depending on the login and password the application has to display 2 different user screens.

How do I do this?

Also when I first wrote this application I had just one user in mind so all the code is present in the dialog class CApplicationDlg. Is it possible for me to hide all the controls on this dialog box and create a new user screen on the same dialog box when the 2nd user type logs in?

Thanks
Mike.

Re: Dialog Box Problem

Joaquín M López Muñoz12-Dec-01 1:28

Joaquín M López Muñoz

12-Dec-01 1:28

Well, I guess the simplest way to get this done, given the original design of your project, is as follows:

Create two sets of controls for each user profile and merge them into the only dialog resource. You'll end up with a mess of overlapping controls, so you might want to do the work separately in auxiliary dialog resources and then copy and paste to the final destination. On the process some controls will be shared (i.e., they exist for both user profiles), keep that in mind and do not duplicate them.
Have all the controls hidden by default. If you select Test on the Resource menu, the dialog should appear empty.
Have two static arrays defined for your CDialog class, each specifying the IDs of the controls that should appear for the corresponding user profile.
Add a variable to the constructor of your CDialog class indicating the user profile.
In OninitDialog you just have to walk thorugh the appropriate array of control IDs and call GetDlgItem(id)->ShowWindow(SW_SHOW).

Hope this helps.

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo

Re: Dialog Box Problem

mvworld12-Dec-01 1:35

mvworld

12-Dec-01 1:35

I figured that out thanks. But the problem now is that I need a menu bar for one user category and no menu for the other user category.

By default the dialog box loads a menu bar, and I want to remove it when the user 2 enters. So I did the following

CMenu* menu = GetSystemMenu(TRUE);
menu->DestroyMenu();

But the program crashes!

What do I do?

Thanks,
Mike

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.