How do I modify the below query without union ?

Question

1.00/5 (2 votes)

See more:

I want to get rid of the union but still need the same resultset.

I'm new to sql Please help.

[EIDT]Duplicated content has been removed - Maciej Los[/EDIT]

What I have tried:

Query::

SQL

select con.FirstName +' ' +con.LastName as ConsultantName,PositionName,MAX(tm.TsId)  as TsId, (pm.PositionId), tm.FromDate,tm.ToDate from TimesheetMasters tm
          left join PositionMasters pm on tm.PositionId=pm.PositionId
          left join Consultants con on con.ConsultantId=pm.ConsultantId

          where  tm.SubmissionStatus=0 
          --and tm.TsId in ( select MAX( TsId) from TimesheetMasters group by PositionId)
          and convert(date, tm.ToDate) between convert(date, DATEADD(day,-30,GETDATE())) and CONVERT(date, GETDATE())
          and pm.CompanyKeyId=@CompanyKeyId
          group by con.FirstName +' ' +con.LastName,PositionName,tm.TsId,pm.PositionId, tm.FromDate,tm.ToDate
          --order by TsId desc


          union

-- Position created but Timesheet is not submitted till now

select con.FirstName +' ' +con.LastName as ConsultantName,PositionName,null as TsId, pm.PositionId,pm.StartDate, pm.EndDate 
          from PositionMasters pm 
          left join Consultants con on con.ConsultantId=pm.ConsultantId
          where pm.PositionId not in (select PositionId from TimesheetMasters) 
          and pm.CompanyKeyId=@CompanyKeyId
          and convert (date,pm.StartDate) between convert(date, DATEADD(day,-30,GETDATE())) and CONVERT(date, GETDATE())

Posted 3-Jan-17 18:41pm

Member 10468587

Updated 3-Jan-17 19:55pm

Maciej Los

v2

Add a Solution

Comments

Suvendu Shekhar Giri 4-Jan-17 1:04am

What is the problem, if you are getting correct result?
Is it slower than expected?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

jgakenhe · Accepted Answer · 2017-01-03T19:09:00

There is nothing wrong with using UNION. It would probably perform faster than using the OR logical boolean operator because it most likely will have less table reads. If you want, you can try and take the top half of the query and substitute the WHERE clause with the code below. I believe it will work, but hard to tell without any data.

SQL

where (tm.SubmissionStatus = 0 OR pm.PositionId not in (select PositionId from TimesheetMasters))