Question about sqlconnection open

Question

0.00/5 (No votes)

See more:

Example 1

public class foo() 
{
   public void InsertDatabase() 
   {
      using (SQLConnection conn=new SQLConnection("connection info")) 
      {
         conn.Open()
         conn.CommandText="Insert into database";
         conn.ExecuteNonQuery();
      }
   }
}

public void main()
{
   foo f= new foo();
   foo.InsertDatabase();
}

OR

Example 2

public class foo():Idisposable
{
   private SQLConnection sql=new SQLConnection();

   public void OpenDB()
   {
     sql.Open(); 
   }

   public void InsertDatabase()
   {
     sql.commandtext="Insert into database";
     sql.executenonquery();
   }

//Idisposable methods would go here

}

public void main()
{
    using (foo f= new foo()) 
    {
       foo.OpenDB();
       foo.InsertDatbase();
    }
}

You can see the two examples, one would have open in the InsertDatabase method and the other would have an open method and then the InsertDatabase method. I realize with connection pooling opening and closing isnt really an issue, but what is the best practice way to do this. Most people online tend to lean toward example 1, but is this right?

Posted 18-Nov-10 12:07pm

jdunk

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2010-11-19T01:29:00

Solution 3

There is no best practice on this. It's more amatter of style and project requirements. Someones I do it like your first example. Sometimes the other way. But I DO always put a try/catch block around db access stuff.

Posted 19-Nov-10 1:29am

#realJSOP

mayurjogani · Answer 2 · 2010-11-19T01:08:00

Try this code for Open Connection...

C#

public void InsertDatabase()
   {
try
{      
using (SQLConnection conn=new SQLConnection("connection info"))
      {
         conn.Open();
         conn.CommandText="Insert into database";
         conn.ExecuteNonQuery();
      }
}
catch(exception ex)
{
messagebox.show(ex.tostring());
}
finally
{
conn.close();
}
   }

fjdiewornncalwe · Answer 3 · 2010-11-18T13:10:00

When you write methods, then name of the method should give a clear indication of what the method does, and nothing more. So I would lean towards your second example because InsertDatabase should only insert into a database. OpenDB is short and sweet, but if you want to wrap some generic validation around it, you will only have to do it once in that method, so it is a win win. Neither is wrong, however. If you have other project source to look at where you work, you could look at those and write yours to be consistent with those.

Question about sqlconnection open

3 solutions

Solution 3

Solution 2

Solution 1

Add your solution here

Preview 0