Mysqli_query ($conndb, $SQL); error report

Question

1.00/5 (1 vote)

See more:

I have the following codes. But it reports error for mysqli_query ($conndb, $sql); statement 

 
<?php

//function conndb()
//{
$conndb = mysqli_connect('localhost', 'root', '','mydatabase');
//}

if($conndb = true){
 echo "Connection Succesful!";
} else{
    die(mysqli_error);
}

// line 14================================
$author = "Temtim" ; //$_Post["name"];
$title = "kjkdfdf";   //$_Post["title"];
$year = 2343 ;   //$_Post["year"];
$abstract = "This is a data scine ";   //$_Post["abstract"];

$sql = "insert 'article' ('author', 'title', 'year', 'abstract') values('$author','$title','$year','$abstract');"
//$sql = "INSERT INTO `tbl_contact` (`Id`, `fldName`, `fldEmail`, `fldPhone`, `fldMessage`) VALUES ('0', '$txtName', '$txtEmail', '$txtPhone', '$txtMessage')";

mysqli_query ($conndb, $sql);


mysqli_close($conndb);

?>

What I have tried:

I tried different options but this statement mysqli_query ($conndb, $sql);  cannot be executed

Posted 31-Aug-24 23:17pm

Temtim Assefa

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2024-08-31T23:42:00

Firstly, The SQL INSERT statement doesn't look like that - it requires the INTO keyword as well: SQL INSERT INTO Statement[^]

SQL

INSERT INTO MyTable (Column1, Column2) VALUES (...)

Secondly, and much more important - never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

PHP has built in parameterised query passing: PHP: Prepared Statements - Manual[^]

Richard Deeming · Answer 2 · 2024-09-01T21:31:00

insert 'article' ('author', 'title', 'year', 'abstract')

You have used single quotes around your table and column names. That is not valid. You need to use back-ticks around object identifiers, as shown in your commented-out code:

insert into `article` (`author`, `title`, `year`, `abstract`)

But as Griff said, fix the critical SQL Injection[^] vulnerability before you do anything else!

Mysqli_query ($conndb, $SQL); error report

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0