error in store procedure

Question

0.00/5 (No votes)

See more:

CREATE PROCEDURE dbo.usp_booking_insert
	@user_id int,
	@journey_place varchar(50),
	@pickup_address varchar(250),
	@return_address varchar(250),
	@service_id int,
	@vehicle_id int,
	@mode_of_payment varchar(50),
	@status varchar(5),
	@starting_km decimal(15,4),
	@ending_km decimal(15,4),
	@booking_date datetime

	AS
		Begin

		Declare @uid int
		if(@uid = 0)
		Begin
		set uid = (select max(user_id) from registration)
		End

		Else
		Begin
		set uid = @user_id
		End

		insert into booking (user_id,journey_place,pickup_date,pickup_address,return_date,return_address,service_id,vehicle_id,mode_of_payment,status,starting_km,ending_km,booking_date)
		 values (@uid,@journey_place,getdate(),@pickup_address,getdate(),@return_address,@service_id,@vehicle_id,@mode_of_payment,'true',0,0,@booking_date)

		End

there is an error in dis store procedure of "incorrect syntax near '='"

Posted 16-Mar-13 7:20am

Member 9671810

Updated 16-Mar-13 7:33am

Dave Kreskowiak

v3

Add a Solution

2 solutions

Solution 1

First of all, you are using SET[^] not with correct syntax, you missed the @: set @uid =.
BTW: what is the meaning to test the variable value right after declaring it?

Posted 16-Mar-13 8:45am

Zoltán Zörgő

Comments

Member 9671810 17-Mar-13 2:00am

thanx....

bt can you tell me how can i get date from the txtbox using getdate(),
as i have hot declared it..in store procedure.

cmd.Parameters.AddWithValue("@",);

what should i write over here..?

bbirajdar 17-Mar-13 2:38am

getdate() is a sql function to get current date.

To get the value from a textbox in asp.net you need to use

string dtStartDate=txtStartDate.Text.Trim()

Member 9671810 17-Mar-13 3:33am

bt what should i pass in parameters...?

and i only want to use getdate()

Zoltán Zörgő 17-Mar-13 3:36am

You wrote: "get date from the txtbox using getdate()". Well, you either use getdate and you get current date, or you get user input from a textbox and you need to pass it as parameter. These two have nothing in common.

BTW: you have posted it as reply to my answer, but aspnet_regiis -i wrote those to you.

Member 9671810 17-Mar-13 3:39am

cmd.CommandText = "usp_booking_insert";
cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddWithValue("@user_id", ddluname.SelectedValue);
cmd.Parameters.AddWithValue("@journey_place", txtjplace.Text);
cmd.Parameters.AddWithValue("getdate()", txtpickup_calenderri.Text);
cmd.Parameters.AddWithValue("@pickup_address", txtpickup_address.Text);
cmd.Parameters.AddWithValue("getdate()", txtreturndate.Text);
cmd.Parameters.AddWithValue("@return_address", txtreturn_address.Text);
cmd.Parameters.AddWithValue("@service_id", ddlsname.SelectedValue);
cmd.Parameters.AddWithValue("@vehicle_id", ddlvehicles.SelectedValue);
cmd.Parameters.AddWithValue("@mode_of_payment", rdbtnpayment.SelectedValue);
cmd.Parameters.AddWithValue("@booking_date", System.DateTime.Now.ToString());

dis is my code.. now what should i do?

Zoltán Zörgő 17-Mar-13 3:42am

Delete these:


cmd.Parameters.AddWithValue("getdate()", txtpickup_calenderri.Text);
cmd.Parameters.AddWithValue("getdate()", txtreturndate.Text);

Functions calls can not be used as parameter, the others begin with @ as they should. Don't you see the difference. These two are nonsense.

Member 9671810 17-Mar-13 3:43am

so then how can i get the value from textbox..?

Zoltán Zörgő 17-Mar-13 6:12am

Replace getdate() in the query with @pickup_calenderri and @returndate respectively, and pass the textbox values as in the case of the other parameters. Be aware, that not all intelligible date string are recognized by sql server as valid date values!

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

bbirajdar · Accepted Answer · 2013-03-16T08:49:00

Solution 2

In addition to the above solution posted .. I would suggest you to change this line of code

SQL

set uid = (select max(user_id) from registration)

should be changed to

SQL

select @uid=max(user_id) from registration

Posted 16-Mar-13 8:49am

bbirajdar

Comments

Member 9671810 17-Mar-13 1:59am

hey,
can you tell me how can i get date from the txtbox using getdate(),
as i have hot declared it..in store procedure.

cmd.Parameters.AddWithValue("@",);

what should i write over here..?