What is wrong in this expression ?

Question

1.00/5 (1 vote)

See more:

Hi i have this code, i don't know what is wrong in it, Can you help me to fix ? Thanks

C++

#include<stdio.h>
#include<conio.h>
#define PI 3.1415

float aria(float);
float perimetru(float);


void main(void)
{
float L, a, l, P;

printf("\nIntroduceti valoarea L: ");
scanf("%f", &l);
printf("\nIntroduceti valoarea l: ");
scanf("%f", &L);


printf("\n=======================================");

printf("\nPatratul are:");
printf("\nl = %f ", l);
printf("\nL = %f ", L);
printf("\nperimetru = %f ", perimetru(l, L));
printf("\naria = %f", aria(l && L));

getch();
}
float aria(float)
{ float a, l, L;
a = L * l;
return a;
}
float perimetru(float)
{ float P, l , L;
P = 2*(l+L);
return P;
}

Posted 23-Oct-13 8:03am

Malasuerte94

Updated 23-Oct-13 18:46pm

VICK

v3

Add a Solution

Comments

Andreas Gieriet 23-Oct-13 14:19pm

What exectly is the problem? Which expression?
Cheers
Andi

Malasuerte94 23-Oct-13 14:22pm

I think here is the problem
printf("\nperimetru = %f ", perimetru(l, L));
printf("\naria = %f", aria(l && L));

With this program i need to calculate the perimeter and area of a square

2 solutions

Solution 2

Exact answer is.

C++

#include<stdio.h>
#include<conio.h>
#define PI 3.1415

float aria(float,float);
float perimetru(float,float);


void main(void)
{
float L, a, l, P;

printf("\nIntroduceti valoarea L: ");
scanf("%f", &l);
printf("\nIntroduceti valoarea l: ");
scanf("%f", &L);


printf("\n=======================================");

printf("\nPatratul are:");
printf("\nl = %f ", l);
printf("\nL = %f ", L);
printf("\nperimetru = %f ",perimetru(l, L));
printf("\naria = %f", aria(l,L));

getch();
}
float aria(float l1,float L1)
{float a;
a = L1*l1;
return a;
}
float perimetru(float l2,float L2)
{ float P;
P = 2*(l2+L2);
return P;
}

Posted 23-Oct-13 8:59am

Vishal I. Sahuji

Updated 23-Oct-13 9:02am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-10-23T08:23:00

Would you like a list?
Because the compiler will give you one for free, and you don't have to wait at all...

Lets start by looking at your functions for working out the results:

C#

float aria(float)
{ float a, l, L;
a = L * l;
return a;
}
float perimetru(float)
{ float P, l , L;
P = 2*(l+L);
return P;
}

What values do you expect these to return?
Because you are declaring all your variables locally, so aria is the equivalent of:

C++

float aria()
   {
   float a;
   a = 0.0 * 0.0;
   return a;
   }

You can't access L, a, L, or P from the declaration in your main function, because they are only in scope and available within the main function itself.
Instead, try this:

C++

float aria(float l1, float l2)
   {
   return l1 * l2;
   }

You will need to change the prototype to match.
Then call it like this instead:

C++

printf("\naria = %f", aria(l, L));

Then do the same fro perimetru.

And do yourself a favour: don't use single character variable names, and never, ever, ever use two variables that only differ by case! It is a very silly idea to have "l" and "L" in the same scope as it is far, far too easy to type the wrong one...