Whats wrong with this search query?

Question

1.00/5 (1 vote)

See more:

C#

protected void btnSearch_Click(object sender, EventArgs e)
    {
        SqlConnection con = new SqlConnection();
        con.ConnectionString = ConfigurationManager.ConnectionStrings["constr"].ConnectionString;
        con.Open();
        try
        {
            string query = "select * from news where name like '" + txtSearch.Text + "%' or description like '" + txtSearch.Text + "%'  ";
            SqlCommand cmd = new SqlCommand(query, con);
            SqlDataAdapter da = new SqlDataAdapter(cmd);
            DataSet ds = new DataSet();
            da.Fill(ds);
            con.Close();
            gridrecord.DataSource = ds;
            gridrecord.DataBind();
            if (gridrecord.Rows.Count == 0)
            {
                lblmsg.Visible = true;
                lblmsg.Text = " No data found";

            }
        }
        catch (Exception ex)
        { 
        
        }
    }

Posted 20-Feb-14 17:36pm

Ruhani18

Updated 20-Feb-14 17:50pm

Bojjaiah

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 20-Feb-14 23:39pm

Why should we even look at this code dump if you did not even bother to explain what problem do you have with this code?
—SA

King Fisher 20-Feb-14 23:51pm

getting any error?

Bojjaiah 20-Feb-14 23:54pm

what's your problem?
or
what's error?

thatraja 21-Feb-14 2:10am

I know the what's wrongs(yes, many) but you tell first what's the error?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Bernhard Hiller · Answer 1 · 2014-02-20T21:24:00

C#

}
catch (Exception ex)
{

}

That's wrong: you swallow any exception, hence you have no chance to get rid of the error.
Also, you do not close the connection in case of an exception. I suggest a using directive:

C#

using(SqlConnection con = new SqlConnection())
{
    con.ConnectionString = ... etc.
}

And

C#

if (gridrecord.Rows.Count == 0)
           {
               lblmsg.Visible = true;
               lblmsg.Text = " No data found";

           }

will never reset that label when a query succeeds after a previous failure.

King Fisher · Answer 2 · 2014-02-20T17:53:00

Solution 1

better you use Trim() to Avoid Space while using Like Query

SQL

string query = "select * from news where name like '" + txtSearch.Text.Trim() + "%' or description like '" + txtSearch.Text.Trim() + "%' ";

Posted 20-Feb-14 17:53pm

King Fisher