UPDATE my access database

Question

0.00/5 (No votes)

See more:

Helloo,

I try to update ALL records from my database, i use the folowing code:

C#

try
                {
                    Program.Connection.CommandText = "SELECT * FROM NirProduseAmanet";
                    DataTable TableIntrareProduse = new DataTable();
                    Program.Connection.FillDataTable(TableIntrareProduse, true);

                    string[] ProduseIntare = new string[TableIntrareProduse.Rows.Count];
                    string[] GrProdusIesire = new string[TableIntrareProduse.Rows.Count];

                    for (int i = 0; i < TableIntrareProduse.Rows.Count; i++)
                    {
                        ProduseIntare[i] = TableIntrareProduse.Rows[i]["PretPropusVanzare"].ToString();
                        GrProdusIesire[i] = TableIntrareProduse.Rows[i]["Cantitatea"].ToString();

                        Program.Connection.CommandText = "UPDATE NirProduseAmanet SET PretVanzare=@PretVanzare, GrProdusIesire=@GrProdusIesire";
                        Program.Connection.AddParameter("@PretVanzare", Convert.ToDecimal(ProduseIntare[i]));
                        Program.Connection.AddParameter("@GrProdusIesire", Convert.ToDecimal(GrProdusIesire[i]));
                        Program.Connection.ExecuteNonQuery();
                    }
                }
                catch (OleDbException ex)
                {

                }

the code is ok, i retive al recod from database

BUT on UPDATE he update ALL records with my last value from database.
any sugestions?

Posted 27-Feb-14 21:16pm

aciobanita constantin

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-02-27T21:26:00

Well...it will.
When you write an UPDATE you have to specify exactly which records should be affected - or SQL will assume that you mean all of them, just as it does when you do a SELECT:

SQL

SELECT * FROM MyTable

Will return all records.

SQL

UPDATE MyTable SET MyColumn=6

Will change all records.

If you want to limit the rows you return, then you use a WHERE clause:

SQL

SELECT * FROM MyTable WHERE MyColumn=6

Similarly, if you want to alter only specific records, you use a WHERE clause on your UPDATE:

SQL

UPDATE MyTable SET MyColumn=6 WHERE MyOtherColumn=1

I have no idea what column of your table is significant here, so I leave it up to you to decide which column determines the update criteria!

Maciej Los · Accepted Answer · 2014-02-27T21:23:00

Solution 1

You forgot to add WHERE statement to limit/restrict the range of changes ;)

SQL

UPDATE TableName SET FieldName=NewValue 
WHERE FieldName = OldValue

Posted 27-Feb-14 21:23pm

Maciej Los

Updated 27-Feb-14 21:26pm

v3