Error in my code block, I need help to get rid of it.

Question

0.00/5 (No votes)

See more:

This codes where working yesterday but today, its giving error "No value given for one or more required parameters." I do not know what I have done.

I am passing data from window formA to Microsoft Access database using a dynamic method "DBeditor" in "mClass" class.

C#

//DBeditor method in mClass.
public void DBeditor(string query, params Control[] A)
{
    static string path = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=" + Application.StartupPath + "\\dBase.accdb";

    OleDbCommand cmd = new OleDbCommand();
    OleDbDataAdapter adt = new OleDbDataAdapter();
    OleDbConnection con = new OleDbConnection(path);
    DataTable dt = new DataTable();
    DataSet ds = new DataSet();

    con.Open();
    cmd.Connection = con;
    cmd.CommandType = CommandType.Text;
    cmd.CommandText = query;
    for (int i = 0; i < A.Length; i++)
    {
        cmd.Parameters.Add(new OleDbParameter(("@cell" + "[" + i.ToString() + "]"), OleDbType.VarChar)).Value = A[i].Text; //the problem is here.
        cmd.ExecuteNonQuery();
        con.Close();
    }
}

//Using DBeditor in Windows FormA
            mClass mcl = new mClass();
            mcl.DBeditor("Insert into AdministratorsTable ([SURNAME], [OTHER NAMES])values(@cell1, @cell2)",
                txtSName, txtONames);

Please help, I am really confused right now.

Posted 30-May-14 0:28am

Salisu Shaibu

Updated 30-May-14 0:31am

Thomas Daniels

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2014-05-30T00:40:00

The problem here is that your parameter names are @cell1 and @cell2, but in your for loop, you are adding values to parameter names like @cell[1] and @cell[2]. You should remove the square brackets. Also, you should put the ExecuteNonQuery and Close method outside the loop, otherwise you execute the query before all parameters have values.

C#

for (int i = 0; i < A.Length; i++)
{
    cmd.Parameters.Add(new OleDbParameter("@cell" + i.ToString(), OleDbType.VarChar)).Value = A[i].Text; // remove square brackets []
}
cmd.ExecuteNonQuery(); // put these two lines outside the loop
con.Close();

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2014-05-30T00:35:00

Solution 1

I guess the execution should take place after the for loop.

C#

for (int i = 0; i < A.Length; i++)
{
    cmd.Parameters.Add(new OleDbParameter(("@cell" + "[" + i.ToString() + "]"), OleDbType.VarChar)).Value = A[i].Text; //the problem is here.
    cmd.ExecuteNonQuery();
    con.Close();
}

cmd.ExecuteNonQuery();
con.Close();

The previous code would work if the A.Length is 1. But when it exceeds 1, it would create problems.

Posted 30-May-14 0:35am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Comments

Salisu Shaibu 30-May-14 7:44am

You were very correct!

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 30-May-14 7:44am

Thanks. :)