Not retaining Changes to values of properties in a Custom Class

Question

4.00/5 (1 vote)

See more:

I created this function to remove vbCrLf from the values of properties in a Custom Class:(vTransaction)

Public Function ValidateTransaction(ByRef vTransaction)            Dim property1 As String
        Dim value1 As String

        For Each p As System.Reflection.PropertyInfo In vTransaction.GetType().GetProperties()
            If p.CanRead Then
                property1 = p.Name '// FOR TESTING to identify Property Name
                value1 = p.GetValue(vTransaction, Nothing)
                If (TypeOf value1 Is String) Then
                    If value1 <> " " And value1 <> "" Then
                        'MsgBox("Before .Replace:" & vbNewLine & value1.ToString) '// FOR TESTING.
                        value1 = value1.ToString.Replace(vbCrLf, " ")
                        'MsgBox("After .Replace:" & vbNewLine & value1.ToString) '// FOR TESTING.
                    End If
                End If
            End If
        Next

        Return vTransaction

    End Function

Throughout testing I can verify that vbCrLf is being replaced with a space as expected. When I re-examine vTransaction the changes have not been retained and the vbCrlf's are still there.
What do I need to do to retain the changes being made to values in vTransaction.

Posted 10-Jun-11 11:18am

gspeedtech

Add a Solution

3 solutions

Solution 2

Your code doesn't really make any sense. But, what you did was get a copy of a string value, remove all the vbCrLf's from the copy, then drop it and not do anything with it. You returned only the value that was passed into the method, so yeah, nothing changed.

Posted 10-Jun-11 11:49am

Dave Kreskowiak

Comments

gspeedtech 10-Jun-11 18:07pm

Thanks

Sergey Alexandrovich Kryukov 10-Jun-11 20:04pm

That's the thing, my 5.
--SA

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Alan N · Accepted Answer · 2011-06-10T11:43:00

Solution 1

You got it, you changed it. Now put it back, i.e. SetValue.

Alan.

Posted 10-Jun-11 11:43am

Alan N

Comments

gspeedtech 10-Jun-11 18:06pm

Thanks

Sergey Alexandrovich Kryukov 10-Jun-11 20:04pm

Simple as that, a 5.
--SA

gspeedtech · Accepted Answer · 2011-06-10T12:06:00

That fixed it:

VB

Public Function ValidateTransaction(ByRef vTransaction)
    Dim property1 As Object
    Dim value1 As Object

    For Each p As System.Reflection.PropertyInfo In vTransaction.GetType().GetProperties()
        If p.CanRead Then
            property1 = p.Name '// FOR TESTING to identify Property Name
            value1 = p.GetValue(vTransaction, Nothing)
            If (TypeOf value1 Is String) Then
                If value1 <> " " And value1 <> "" Then
                    'MsgBox("Before .Replace:" & vbNewLine & value1.ToString) '// FOR TESTING.
             p.SetValue(sTransaction, value1 = value1.ToString.Replace(vbCrLf, " "), Nothing)
                    'MsgBox("After .Replace:" & vbNewLine & value1.ToString) '// FOR TESTING.
                End If
            End If
        End If
    Next

    Return sTransaction

End Function