Writing to a file name input by user

Question

4.00/5 (1 vote)

See more:

I have created a Windows form app and part of it includes getting a name out of a text box and appending it to a directory in order to write to a file in that directory.

The top level will always be C:\Programs\PROGRAMS\

Here is what I have right now for my constructor (This is not how I actually want to do it, just wanted to provide some idea of what I'm looking at):

createFile::createFile(string name)
{
	string path = "C:\\Programs\\PROGRAMS\\" + name + "\\" + name + ".txt";	
}

So for example a file I would like to write to could be:
C:\Programs\PROGRAMS\ATP-8878B\ATP-8878B.txt
and I would like to be able to use
ofstream outFile;
outFile.open(path);

The error I get is: Attempting to read or write from protected memory.
at the first strcat() call.

The parameter (const char* name) can be changed to another type, as it needs to be converted from a String^ anyway, if you think that could be helpful. From what I've found path needs to end up being a const char* in order to call outFile.open(path);

Any ideas on a better way I can do this?
Thanks in advance for any help.

EDIT:
Modified original code.

Posted 16-Jun-11 10:39am

obp42

Updated 16-Jun-11 10:53am

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

obp42 · Accepted Answer · 2011-06-16T11:04:00

Solution 2

Sorry to waste anyone's time who read this... apparently I just wasn't thinking clearly.

After changing the code in the constructor to what it now in my top post, the solution was simply:

ofstream outFile;
outFile.open(path.c_str());

Posted 16-Jun-11 11:04am

obp42

Albert Holguin · Accepted Answer · 2011-06-16T11:12:00

The reason your other code wasn't working was that you had:

createFile::createFile(const char* name)
{
    char* path = "C:\\Programs\\PROGRAMS\\";

    path = strcat(path, name);
    path = strcat(path, (const char*)'\\');
    path = strcat(path, name);
    path = strcat(path, (const char*)'.txt');
}

when you should've probably had something like this:

createFile::createFile(const char*name)
{
    char path[] = "C:\\Programs\\PROGRAMS\\";

    strcat(path, name);
    strcat(path, (const char*)"\\");
    strcat(path, name);
    strcat(path, (const char*)".txt");
}