getting exception : indexoutofrangeunhadledexception

Question

0.00/5 (No votes)

See more:

C#

using System;
using System.Collections;
using System.Linq;
using System.Text;

namespace Generalsortingcon
{
    class Program
    {
        static void Main(string[] args)
        {
            int[] items = { 60,30,40,20,80};
            int temp=0;
            int n = items.Length;
            for (int i = 0; i <n mode="hold" />            {
                for (int j = i+1; j <n-i;>                {
                    if (items[j] > items[j+1])//  here getting exception
                    {
                        temp = items[j];
                        items[j] = items[j+1];
                        items[j] = temp;
                    }

                }
                Console.WriteLine("values:" + Convert.ToString(items[i]));
               
            }
            
           
            Console.ReadKey();
           
        }
    }
}

Posted 7-Jul-13 22:06pm

prasadhp

Updated 7-Jul-13 22:11pm

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v2

Add a Solution

Comments

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 8-Jul-13 4:12am

There are some problems while pasting the code.
Please paste it again.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Naz_Firdouse · Accepted Answer · 2013-07-07T22:15:00

modify your logic like this

C#

int[] items = { 60, 30, 40, 20, 80 };
int temp = 0;
int n = items.Length;
for (int i = 0; i < n; i++)
{
    for (int j = i ; j < n - i - 1; j++)
    {
        if (items[j] > items[j + 1])// here getting exception
        {
            temp = items[j];
            items[j] = items[j + 1];
            items[j+1] = temp;
        }

    }
    //Console.WriteLine("values:" + Convert.ToString(items[i]));

}

for (int i = 0; i < n; i++)
{
    Console.WriteLine("values:" + Convert.ToString(items[i]));
}

The reason you are getting exception is you are trying to compare items[4] with items[5] which doesnot exists....
so you need to restrict you termination condition to n-I-1

and also you need to change the initial value of j ...