Any ideas on Adding new item to List c#

Question

4.00/5 (1 vote)

See more:

i have an 2D array which i am trying to write into a List so i can bind it with a datagrid.
below is my code.

string[,] array = new string[8,4];
 array[counting2, 0] = txtSend.Text;
 array[counting2, 1] = One;
 array[counting2, 2] = Two;
 array[counting2, 3] = Three;

 List<testing> Hello1 = new List<testing>();

 Testing Hello = new Testing();
 for (int i = 0; i <= counting2;i++ )
 {
     Hello.year = array[counting2, 0];
     Hello.One = array[counting2, 1];
     Hello.Two = array[counting2, 2];
     Hello.Three = array[counting2, 3];
     Hello1.Add(Hello);

 }
dataGrid1.ItemsSource = Hello1;</testing></testing>

What is see is when my array contain 3 rows the data grids shows 3 rows with the same data instead of 3 diffrent data. I am guessing is that i am adding Hello to the list 3 times.
But do i change the Hello to a variabele so each time the for loop loops its another name.
Ne Ideas ??

Posted 1-Mar-11 16:51pm

Amd_eagle

Updated 1-Mar-11 17:03pm

Abhinav S

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sean A. Hanley · Accepted Answer · 2011-03-01T17:10:00

Yes, you're just adding the same object reference three times. ;P The last run on the for loop sets the values to what you'll see for all rows, since all rows point to the same instance of Testing.

You were really close. Instead, do this:

for (int i = 0; i <= counting2;i++ )
{
    Testing Hello = new Testing();
    Hello.year = array[counting2, 0];
    Hello.One = array[counting2, 1];
    Hello.Two = array[counting2, 2];
    Hello.Three = array[counting2, 3];

    Hello1.Add(Hello);
}
dataGrid1.ItemsSource = Hello1;

It's okay to have the Testing variable Hello scoped only within the for loop. In fact, this is how you'll get a new object reference to add to the list.