Input string was not in correct format

Question

0.00/5 (No votes)

See more:

Hello,
I am trying to do the sum of value in textbox1 and textbox2 and result in textbox3.
sum is happening when application is debug from Visual studio, but when application deployed on web server, sum is not happening and getting error Input string was not in correct format.
Kindly help to get this solv

What I have tried:

C#

protected void TextBox16_TextChanged(object sender, EventArgs e)
        {
                if ((!string.IsNullOrEmpty(TextBox16.Text)) && (!string.IsNullOrEmpty(TextBox19.Text)))
                {
                TextBox30.Text = (Convert.ToDecimal(TextBox16.Text) + Convert.ToDecimal(TextBox19.Text)).ToString().Trim();
                }
}

Posted 4-Apr-16 19:29pm

Member 12256084

Updated 4-Apr-16 19:38pm

Abhipal Singh

v3

Add a Solution

Comments

Abhipal Singh 5-Apr-16 1:40am

Use try parse to convert string to decimal. It is possible that the input values are not decimals at all!.
Would you mind sharing the input?
P.S. trim() is not required.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Answer 1 · 2016-04-04T19:38:00

Solution 1

use TryParse [^]for casting the string to a numeric type

corrected code:

C#

if ((!string.IsNullOrEmpty(TextBox16.Text.Trim())) && (!string.IsNullOrEmpty(TextBox19.Text.Trim())))
{
    decimal a = 0, b = 0;
    if (decimal.TryParse(TextBox16.Text.Trim(), out a) && decimal.TryParse(TextBox19.Text.Trim(), out b))
        TextBox30.Text = (a + b).ToString();

}

Posted 4-Apr-16 19:38pm

Karthik_Mahalingam

Comments

Abhipal Singh 5-Apr-16 1:42am

I think the null checks are not required if you are using try parse :) Just a word or advise.

Karthik_Mahalingam 5-Apr-16 1:49am

yes Abhipal correct, i just edited his code.
but technically, if we do do the validation, the app performance will improve.
since the Tryparse will do lot of job inside( if exception arise ), compared to the simple validation outside.

Sergey Alexandrovich Kryukov 5-Apr-16 2:00am

Wrong. Try parse doesn't throw and then handle exception, as you could imagine. It it does not run into exception at all. Look at the source code and you will see. Simple logic allows to suggest that your performance validation is also your fantasy. Sorry, but you have to reliably justify your statements.
—SA

Member 12256084 5-Apr-16 2:29am

Karthik,
Your code is working fine and no error when application runs from web server, but When TextBox19 having decimal value like 10.00 hours and TextBox16 having numaric value like 10 hour, the sum is not happening in TextBox30.
Only when TextBox16 and TextBox19 having numaric value, the code is running as expected and sum is happening in textBox30.

Sergey Alexandrovich Kryukov 5-Apr-16 1:56am

And assignment a = 0, b = 0 is totally redundant...
—SA

Member 12256084 5-Apr-16 2:12am

Hi again,
I have modify code as per suggetion, sum is happening in Textbox30 while project debug from VS, but when deployed on web server, it is not throwing any error and sum is also not happening in Textbox30.

Member 12256084 5-Apr-16 2:16am

Ok, let me clarify one thing, textbox19 is already having decimal value which is pickup from database and user is entering value in textbox16 in number format e.g
user input textBox16= 10 Hours
from database in Texbox 19 = 30.00 hours
and sum in textBox30= 40.00 hours and this value will store in database

Karthik_Mahalingam 5-Apr-16 2:20am

just run this code and check the performance by yourself and then you can justify me. its not fantasy

System.Diagnostics.Stopwatch watch = new System.Diagnostics.Stopwatch();
watch.Start();
if (!string.IsNullOrEmpty(TextBox1.Text) && !string.IsNullOrEmpty(TextBox2.Text) && !string.IsNullOrEmpty(TextBox3.Text) &&
!string.IsNullOrEmpty(TextBox4.Text) && !string.IsNullOrEmpty(TextBox5.Text) && !string.IsNullOrEmpty(TextBox6.Text) &&
!string.IsNullOrEmpty(TextBox7.Text) && !string.IsNullOrEmpty(TextBox8.Text) && !string.IsNullOrEmpty(TextBox9.Text) &&
!string.IsNullOrEmpty(TextBox10.Text))
{

}
watch.Stop();
var time1 = watch.ElapsedTicks; //18 ----- performance while validating

System.Diagnostics.Stopwatch watch1 = new System.Diagnostics.Stopwatch();
watch1.Start();
decimal a, b, c, d, e, f, g, h, i, k,l;
decimal.TryParse(TextBox1.Text, out a);
decimal.TryParse(TextBox2.Text, out b);
decimal.TryParse(TextBox3.Text, out c);
decimal.TryParse(TextBox4.Text, out d);
decimal.TryParse(TextBox5.Text, out e);
decimal.TryParse(TextBox6.Text, out f);
decimal.TryParse(TextBox7.Text, out g);
decimal.TryParse(TextBox8.Text, out i);
decimal.TryParse(TextBox9.Text, out k);
decimal.TryParse(TextBox10.Text, out l);
watch1.Stop();
var time2 = watch1.ElapsedTicks; // 39 --------- performance while parsing directly

Sergey Alexandrovich Kryukov 5-Apr-16 2:39am

I guess, I'll have to. But this is not correct timing, not at all. You should exclude any UI. You should exclude JIT. You should collect statistics — dispersion is very high. Even if you are right (I just suggested you were not; did not make a firm statement yet), your claim needs some correct validation.

Oh... wait a second. I just noticed: you are comparing apples and pears. Do you understand it? This is totally obvious. You timing it totally unrelated to your claim on performance. You have to compare two different method giving identical results but having potentially different performance. But you are not even trying to do that. First part does not do the job of several part.

Look, this is either cheating or not understanding anything. Not fantasy, indeed.

This is like claiming that wiping a computer box case with dump cloth accelerate computer repair. For the proof, you spend 1 minite for wiping and then 1 hour on repair. And you time time for wiping and then compare with the time for repair.

Oh... I did not expect such thing from your. This is the end of story.

—SA

Karthik_Mahalingam 5-Apr-16 2:45am

i took some time and did the performance evaluation.
however its a negligible time difference. that can be ignored.

Sergey Alexandrovich Kryukov 5-Apr-16 2:49am

Wrong. It's just fake. In don't know what's worse, if this intentional fake or lack of understanding.
Hence, the claim it totally baseless. I explained why.
—SA

Karthik_Mahalingam 5-Apr-16 3:59am

i have shown you the proof of the performance and still you try to prove your self right..
try to understand it. dont always stand tall.

Sergey Alexandrovich Kryukov 5-Apr-16 9:32am

I'm trying. So far, this is what I said. Look at your code again. Still the same.
—SA

phil.o 5-Apr-16 2:25am

string.IsNullOrEmpty(stringVariable.Trim());
What is the point to trim a string which you want to test for nullity? If the string is null, Trim method will throw a NullReferenceException.

Karthik_Mahalingam 5-Apr-16 2:30am

if the string contains white space?

Member 12256084 5-Apr-16 2:32am

Karthik,
Your code is working fine and no error when application runs from web server, but When TextBox19 having decimal value like 10.00 hours and TextBox16 having numaric value like 10 hour, the sum is not happening in TextBox30.
Only when TextBox16 and TextBox19 having numaric value, the code is running as expected and sum is happening in textBox30.

phil.o 5-Apr-16 2:42am

If the string contains whitespace, then it is not null.

Karthik_Mahalingam 5-Apr-16 2:34am

are you entering the value like 10.00 hours or 10.00

Member 12256084 5-Apr-16 2:37am

10.00 only
e.g
TextBox16.Text= 10
TextBox19.Text= 10.50
TextBox30.Text=20.50
but sum is not happening whenever there is decimal value in textBox19

Karthik_Mahalingam 5-Apr-16 2:42am

10.00 it should cast

Karthik_Mahalingam 5-Apr-16 2:47am

place a breakpoint and see what you are getting over there?

Member 12256084 5-Apr-16 2:50am

Karthik, this is only issue when application running from web server.
It is working fine when debug from my local system where the VS10 is installed

Karthik_Mahalingam 5-Apr-16 3:51am

try like this
decimal.TryParse(TextBox16.Text.Trim(), System.Globalization.NumberStyles.Any,System.Globalization.CultureInfo.InvariantCulture, out a);