Need help with dispose() in C#

Question

0.00/5 (No votes)

See more:

In the below code please suggest the references which we are using and especially where ever we are using the 'new' keyword for the SqlCommand etc., should we explicitly dispose of the references or enclose them with 'using ()' or will it get garbage collected when it loses scope.

C#

private static Boolean clsinit()
{
    Boolean mret = true;
    String mconnstr = @"Data Source=PL\clsSQL,7000;Initial Catalog=clsms;User
    ID=1111;password=2222;";
    clsmain.clsconn = new SqlConnection(mconnstr);
    try
    {
        clsmain.clsconn.Open();
        SqlCommand msqlcmd = new SqlCommand("select licdate from customer",
        clsmain.clsconn);
        SqlDataReader msqldat = msqlcmd.ExecuteReader();
        msqldat.Read();
        if (DateTime.Now.Date > Convert.ToDateTime(msqldat["licdate"]).Date)
        {
            MessageBox.Show("Authentication Restricted.");
            mret = false;
        }
        else
        {
            clsmain.clsconn.Close();
            if (!pychk())
            {
                MessageBox.Show("Authentication Failed");
                mret = false;
            }
        }
    }
    catch
    {
        clsmain.oclsmsgmgr.showmsg("Error connecting Server...!|.",
        mret = false;
    }
    finally
    {
        clsmain.clsconn.Close();
    }
    loadcls mfrm = new loadcls();
    mfrm.ShowDialog();
    return mret;
}

Please Note : I have been given a task to figure out some memory leaks in a project. Please throw some light in a 'dummies' language on garbage collection. Im quite new to .NET GC operations.

Thanks in advance.

What I have tried:

I have searched the web for a clear picture but those have gone over my head. So probably hoping with my own example if someone clarifies I could understand better.

Posted 1-Aug-16 20:06pm

Priya-Kiko

Updated 1-Aug-16 20:46pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Bernhard Hiller · Answer 1 · 2016-08-01T20:46:00

Solution 1

That's really dirty code with all that static and global crap.
My impression from that snippet is that you are running your application in it, with the line mfrm.ShowDialog();, am I correct? Since all those disposable types you talked about are in the same function, it depends on the capabilities compiler to find out that they went out of scope. With different functions, that's easy: when the function is left, local variables are out of scope. I won't exclude that they get garbage collected even here, but I won't assume it either.
On the other hand, memory leaks of a function called once only are rather irrelevant. Look for places which are called repeatedly - small memory leaks there can sum up to relevant amounts.

Posted 1-Aug-16 20:46pm

Bernhard Hiller

Comments

Priya-Kiko 2-Aug-16 4:00am

Quite offensive though, Thank you for the reply.

Sorry, We are not professionals like you all and are just doing some R&D with stuff in the self learning process.

This code snippet is part of a class library the references of which i want to access from other forms and other dlls just like --- class.reference = something. ---- This is what I came across doing some reading.

Moreover, the sqlcommand is used in several places in several functions. Basically i need to have some light on how to implement the dispose pattern.

I need some light on this please :

1. Seems that a variable loses scope when it leaves out the block. Now I have figured this is okay with an Int or a String but not with SqlCommand or SqlDataReader etc.,
2. Now these unmanaged resources as they are called must be handled for disposing.
3. It is impractical to have a line ref.Dispose where ever such references are used considering my lack of knowledge on which are unmanaged resources and which are not.
4. At this background, i have figured this.. Dispose pattern and GC etc., which I dont know how to implement in my project.
5. Should I implement each and every class of my project from IDisposable and add a Dispose() method. If so I have to keep track of all the references used in the module to dispose them here isn't it.

Or just Form.Close or calling the destructor of the class can't do the job ?

Am i understanding this right. Please suggest.