How do I remove the new line from the end of string in C#?

Question

1.00/5 (3 votes)

See more:

how to remove the new line from the end of string ?This is my code to sort the records after writing it with binarywriter

What I have tried:

string inFile = Class1.filename;
       string outFile = Class1.filename;

       var contents = File.ReadAllLines(inFile);
      Array.Sort(contents);
       File.WriteAllLines(outFile, contents);

Posted 27-Apr-17 12:47pm

Member 13151067

Updated 27-Apr-17 23:11pm

v2

Add a Solution

Comments

PIEBALDconsult 27-Apr-17 19:23pm

Trim?
But ReadAllLines should have already removed them, so why do you think you need to?

Dave Kreskowiak 29-Apr-17 11:33am

Because he's writing the text files with a Binary writer.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-04-27T20:05:00

Solution 1

ReadAllLines does remove all newlines, but WriteAllLines puts them all back!
Instead try this:

string inFile = Class1.filename;
string outFile = Class1.filename;
var contents = File.ReadAllLines(inFile);
Array.Sort(contents);      
File.WriteAllText(outFile, string.Concat(contents));

Posted 27-Apr-17 20:05pm

OriginalGriff

Comments

Member 13151067 28-Apr-17 4:10am

when i try to use WriteAllText(outfile,string.concat(contents)); Records won't be sorted like writeAlllines

OriginalGriff 28-Apr-17 4:26am

Yes they will.
You sorted them in the line before the write operation.

Member 13151067 28-Apr-17 4:47am

How can i sort them?

OriginalGriff 28-Apr-17 4:52am

What do you think this line does?

Array.Sort(contents);

Member 13151067 28-Apr-17 4:58am

Sort the array of strings

OriginalGriff 28-Apr-17 5:01am

Correct!
So if it sorts the strings, and you then write them to a file, the resulting file gets what? :laugh:

Member 13151067 28-Apr-17 5:06am

The file will be sorted but i write the records with binary writer and they didn't sort after sorting it
here is my code to write the data
else
{

bw.BaseStream.Seek(length, SeekOrigin.Begin);

textBox2.Text = textBox2.Text.PadRight(5);
bw.Write(int.Parse(textBox2.Text).ToString("D5").Substring(0, 5));

textBox3.Text = textBox3.Text.PadRight(9);
bw.Write(textBox3.Text.Substring(0, 9));

textBox4.Text = textBox4.Text.PadRight(11);
bw.Write( textBox4.Text.Substring(0, 11));

textBox5.Text = textBox5.Text.PadRight(4);
bw.Write(int.Parse(textBox5.Text).ToString("D4").Substring(0, 4));

textBox6.Text = textBox6.Text.PadRight(1);
bw.Write(textBox6.Text.Substring(0, 1));
length += Class1.rec_size;
}

OriginalGriff 28-Apr-17 5:16am

So ... you are writing data to a file as fixed length text fields without any line breaks, reading it back as text and discarding any line breaks that aren't there, and assuming you can sort the result?

No. No, that's not the right approach at all.
And that's ignoring that you take a string, convert it to an integer, convert that back to a string and then assume you can rip a chunk out of it.

You need to go back to what you are supposed to be doing and think about it - because either you have got very much the wrong end of the stick, or you really don't understand what is going on here.

Have a good think, then explain what you are trying to achieve - not what your code does, because that's not good at all, but what task you are trying to get working.