Input string was not in a correct format

Question

0.00/5 (No votes)

See more:

There's no error in the code.
But When I run my web site, I get an error:"Input string was not in a correct format."
Please help me ..

What I have tried:

C#

if(LabelPrices.Text.Length > 0 && txtQuantity.Text.Length > 0)
{
int Quantity = Convert.ToInt32(txtQuantity.Text);
decimal Prices = Convert.ToDecimal(LabelPrices.Text);
decimal sum = Prices * Quantity;
decimal TotalSum = sum;
lblTotalPrice.Text = string.Format("{0:N0}", TotalSum);
lblMessageMoreThanStock.Visible = false;
                Lblonyx.Visible = false;
                lblcheck.Visible = false;
                Image3.Visible = false;
                HyperLinkTracking.Visible = false;
                imgleon1.Visible = true;
                imgleon2.Visible = true;
                imgleon3.Visible = true;
                imgleon4.Visible = true;
                lblstaryu.Visible = true;
                lblstarmie.Visible = true;
                lblstarwa.Visible = true;
                lblomanty.Visible = true;
                ImgThumb.Visible = true;
            }
            else
            {
                lblMessageMoreThanStock.Visible = true;
                Lblonyx.Visible = false;
                lblcheck.Visible = false;
                Image3.Visible = false;
                HyperLinkTracking.Visible = false;
                imgleon1.Visible = true;
                imgleon2.Visible = true;
                imgleon3.Visible = true;
                imgleon4.Visible = true;
                lblstaryu.Visible = true;
                lblstarmie.Visible = true;
                lblstarwa.Visible = true;
                lblomanty.Visible = true;
                ImgThumb.Visible = true;
                lblMessageMoreThanStock.Text = "*Should not be more than Available Stock";
txtQuantity.Text = "1";
                lblTotalPrice.Text = LabelPrices.Text;
            }
        }

Posted 23-Jul-17 5:55am

yasier

Updated 23-Jul-17 6:42am

RickZeeland

v2

Add a Solution

Comments

RickZeeland 23-Jul-17 12:21pm

So are you using ASP.NET ? what do you see if you place a breakpoint on the line:
lblTotalPrice.Text = string.Format("{0:N0}", TotalSum);
and hover with your mouse over TotalSum.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2017-07-23T06:42:00

Solution 1

I see two errors: you are using Convert.ToInt32 and Convert.ToDecimal on textbox strings, without any regard to whether they contain valid numbers. You should be using TryParse in order to catch any invalid characters in the input text.

Posted 23-Jul-17 6:42am

Richard MacCutchan

Comments

Atlapure Ambrish 24-Jul-17 2:06am

Another problem I see in the code is use of unnecessary variable "decimal TotalSum = sum;", instead of defining a new variable, you can use 'sum' variable.

Richard MacCutchan 24-Jul-17 3:02am

That's not exactly a problem, just down to a lack of experience.

Atlapure Ambrish 24-Jul-17 3:13am

Yeah, its not a problem but definitely a improvement!