|
Good thought!
I think I can see a way to do this, it will probably have to be Win32 IE specific due to some limitations in Netscape and Mac IE JavaScript.
I will add this to my list of "Things to implement if Chris says he'll use it". 
Alexpro wrote:
Good job!
Thanks. 
Jason Jystad
|
|
|
|
|
I appreciate everybody posting their comments/suggestions for this.
I want you all to know that I am keeping a list of the suggestions and I will do my best to implement them all if Chris says he will use this.
As for the general comments, I am not keeping a list of them unless the suggest improvements. But rest assured that I am basking in them and reading them over and over again.  (Can we tell who doesn't get much positive feedback at work?  ) Thanks for all of the comments so far, and in advance for any more that come along.
Jason Jystad
|
|
|
|
|
No changes to functionality, I was trying to debug the problem Shog noticed and when I was unable to fix it I had to do something to give me a feeling of accomplishment. 
I just took a lap through the code to optimize a few things, make it neater and more consistant, and add some error checking. Otherwise no differences should be noticable.
Jason Jystad
|
|
|
|
|
|
Hmm, no I hadn't seen that one. Thanks, looks to be worth reading.
Only thing I see wrong with this is that it isn't possible to make it cross browser compatible. I am certain I can make the functions above fully cross browser. I am pretty sure that I can even get them cross browser with minimal to no loss of functionality.
So what do you think of my button bar? Yes? No? Go soak my damn head and stop suggesting things?
Jason Jystad
|
|
|
|
|
If you're going to add tags, you should place the cursor between them. Otherwise, a cool idea....
Christian
The tragedy of cyberspace - that so much can travel so far, and yet mean so little.
And you don't spend much time with the opposite sex working day and night, unless the pizza delivery person happens to be young, cute, single and female. I can assure you, I've consumed more than a programmer's allotment of pizza, and these conditions have never aligned. - Christopher Duncan - 18/04/2002
|
|
|
|
|
Christian Graus wrote:
you should place the cursor between them
I donno why, but that sentence looks like it came out of a pr0n book
Nish
Regards,
Nish
Native CPian.
Born and brought up on CP.
With the CP blood in him.
|
|
|
|
|
This feature will be included in the next upgrade. 
Seriously though, I am working on this I just haven't worked all the bugs out yet.
Jason Jystad
|
|
|
|
|
Jason Jystad wrote:
With important input from Nish
Thanks Jason 
Nish
Regards,
Nish
Native CPian.
Born and brought up on CP.
With the CP blood in him.
|
|
|
|
|
Thank you for the input. The convert button was your idea, and now it is my favorite feature.
Now if I could just get Chris to give me a thumbs up or a thumbs down.
Jason Jystad
|
|
|
|
|
Jason Jystad wrote:
Now if I could just get Chris to give me a thumbs up or a thumbs down
lol! I honestly haven't had a chance to look over it carefully. OK <tappity> Let's give it a burl.- Looks good.
- love the insert smiley thing. Well done.
- I wouldn't put spaces around the > inserts.
- It would be really, really nice to have the buttons be reversible. Thus, if a text selection starts with <small> and ends with </small>, and the 'small' button is clicked, the tags are removed instead of added.
- The addition of a URLeriser would be great. Something that takes text and wraps in <a href...> tags. If the text didn't start with "http://" then http would need to be added.
I'll definitely implement some (or most) of the functionality. Nice work Jason!!
cheers,
Chris Maunder
|
|
|
|
|
|
Jason Jystad wrote:
This is something I wanted to talk to you about. The modified InsertText function does this because I have noticed that some smilies require spaces around them before they will parse correctly. Is this by design? Or have I just been smokeing crack again? If the smiley parser doesn't require them then I'll be happy to remove the spaces
The spaces are because some smileys need spaces around them to ensure they aren't mixed up with legit words (eg : D needs a space after the 'D' so that something like ::DestroyWindow isn't turned into  estroyWindow)
Jason Jystad wrote:
So do you want me to go ahead and implement the other suggested features and make the whole thing as fully cross-browser as possible?
That would be sensational. I'll probably replace the button bar you have with a VS.NET style (I can hear the groans) menu bar.
Thanks Jason!!
cheers,
Chris Maunder
|
|
|
|
|
Chris Maunder wrote:
The spaces are because some smileys need spaces around them to ensure they aren't mixed up with legit words (eg : D needs a space after the 'D' so that something like ::DestroyWindow isn't turned into estroyWindow)
Ah, I thought it was something like that. I will add this to my list of things to look over and fix.
Chris Maunder wrote:
That would be sensational. I'll probably replace the button bar you have with a VS.NET style (I can hear the groans) menu bar.
Groans, what groans? *looks around confusedly* Why would anyone groan? I was originally planning on doing it that way myself, it was just easier to prototype it this way first. (great minds do think alike I guess )
I will get started on finishing this up asap, but right now I am going home to bed. :yawn:
Jason Jystad
|
|
|
|
|
Oh yeah, one other thing...
What in tarnation is a Drop Bear?
Jason Jystad
|
|
|
|
|
|
Yee gods, and I parked under a tree today! *slinks away looking up*
Jason Jystad
|
|
|
|
|
Very nice. The interface is a little unfriendly at first but the work it does is very impressive. Nice one.
Michael
|
|
|
|
|
I suspect Chris is going to change the interface, but I would be curious to know if there is anything you would do different to solve the issues you noticed? I am always looking for different views and trying to improve my skills, especially usability.
Jason Jystad
|
|
|
|
|
I'd have prefered the cursor to have been placed between the tags rather than at the end because thats what I'd expected to happen.
The buttons looked a little silly, different sizes and the one with combination of upper and lower case. Didn't look right to me.
These are all issues that would probably have been sorted out in the real implementation rather than in your test page. Nothing major, just me being picky. 
Michael
|
|
|
|
|
Michael P Butler wrote:
These are all issues that would probably have been sorted out in the real implementation rather than in your test page
You are correct, the presentation is something that Chris is going to make quite different anyway so I was being silly and the cursor between the tags is something I am working on it is just being difficult.
Michael P Butler wrote:
Nothing major, just me being picky.
Not at all, these things are important. Thanks.
Jason Jystad
|
|
|
|
|
Jason Jystad wrote:
I bring you the Code Project Posting Toolbar.
<a href="http://" target="_blank">http:
*sigh* Not even my friends support me
Very cool toolbar Jason.
An "instant preview" (done client side, no server call) would be nice. Not hard to do with IE's HTML features. Shout if you want the code.
regards,
Paul Watson
Bluegrass
Cape Town, South Africa
The greatest thing you'll ever learn is just to love, and to be loved in return - Moulin Rouge
Tim Smith wrote:
Over here in the third world of humor (a.k.a. BBC America),
|
|
|
|
|
Paul Watson wrote:
*sigh* Not even my friends support me
Ok, what'd I miss? I sense a missed thread here. Fill me in.
Jason Jystad
|
|
|
|
|
There's a thread somewhere in the lounge where Paul posted a link then Nish got upset that it didn't open in a new window. Long story short, Paul thinks all links should open in the same window (so those who want it to open in the same window can, and those who want it in a new window can as well) and Nish thinks links to a different domain should open in a new window.
James
Simplicity Rules!
|
|
|
|
|
Ah, that makes sense then. Thanks James.
I guess I am going to have to respectfully disagree with Paul on this one.
Actually I would agree with him, except I frequently use a browseing hider service that makes my right click to open a link in a new window not work right. It does handle links that open new windows correctly though. This is really the only reason I disagree.
In case you're interested the service I use is orangatango [new window]
Jason Jystad
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
