How to compare two array's elements C++?

Question

2.00/5 (1 vote)

See more:

hi guys ,, soo i wanted to compare two arrays elements ,, and see the bigger value between each two elements

What I have tried:

C++

#include <iostream>
using namespace std;
int main()
{
int a[] =  {1, 2, 3, 4};
int b[] =  {0, 1, 5, 6};
for (int i=0;i<4;i++)
{
    for (int j=0;j<4;j++)
    {
        if (a[i] > b[j])
        {
            cout << a[i] << " | ";
        }
        else if (a[i] < b[j])
        {
            cout << b[j] << " | ";
            break;
        }
    }
}
    
    return 0;   
}

i wanted to get value like this

C++

1  | 2 | 5  | 6 |

insted i'm getting like this

C++

1 | 5 | 2 | 2 | 5 | 3 | 3 | 5 | 4 | 4 | 5 |

Posted 27-Mar-16 11:45am

Member 12173667

Updated 27-Mar-16 11:55am

Add a Solution

Comments

Member 12173667 27-Mar-16 18:07pm

thanks it worked :)

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sascha Lefèvre · Answer 1 · 2016-03-27T11:52:00

Solution 1

You're comparing each value in a[] to each value in b[] because you nested two for-loops. To get your expected result you only need a single for-loop and to compare the same indices of a[] and b[] with each other.

Posted 27-Mar-16 11:52am

Sascha Lefèvre

Comments

Sergey Alexandrovich Kryukov 27-Mar-16 21:21pm

5ed.
—SA

Patrice T · Answer 2 · 2016-03-27T11:55:00

Only advice for HomeWork:
You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jdb.html[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]

Run your code step by step, inspect variables, be very attentive to what your program is doing. You should find quickly what is wrong.