Is there any problem in the below code?

Question

0.00/5 (No votes)

See more:

C

int foo(int in) 
{
  int *buf1 = (int *)malloc(1000*sizeof(int));
  if(!buf1) return -1;
  int *buf2 = (int *)malloc(2000*sizeof(int));
  if(!buf2) return -1;

  int retVal = process(in,buf1,buf2);

  free(buf1);
  free(buf2);

  return retVal;
}

What I have tried:

I am not able to find any bug, please suggest if any is there?

Posted 13-May-18 6:54am

kishore kumar mishra

Updated 13-May-18 7:21am

CPallini

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2018-05-13T07:21:00

Solution 1

The code is almost fine: you have a memory leak if malloc fails for buf2 (in such a case buf1 memory is not released).

Posted 13-May-18 7:21am

CPallini

Lukasz Gwizdz (Member 2097797) · Answer 2 · 2018-05-13T07:23:00

Solution 2

At first glance, there is a potential memory leak. When buf2 allocation fails you don't care about previous one (buf1) and you immediately return from function without freeing buf1. You should take care of buf1.

Eg.:

C++

if (!buf2) {
    free(buf1);

    return -1;
}

Posted 13-May-18 7:23am

Lukasz Gwizdz (Member 2097797)

Updated 13-May-18 7:26am

v2