Ambiguous column name in my sql query

Question

0.00/5 (No votes)

See more:

i keep getting the error msg Ambiguous column name 'collectorid'in my sql query.
please what is the problem with this query

SQL

SqlDataAdapter adp = new SqlDataAdapter("SELECT a.Collectorid, a.Title, a.Surname, a.Firstname, a.Middlename, a.Gender, a.Dateofbirth, a.Nationality, a.Religion, a.Maritalstatus, a.Spousename, a.Telephone, a.Postaladdress, a.Residentialaddress, a.Hometownaddress from tblCollectorsRegistration a JOIN tblCollectorscontactperson b ON (a.Collectorid = b.Collectorid) WHERE Collectorid = '" + this.txtCollectorid.Text + "' AND conpersonid = (SELECT MIN(conpersonid) FROM tblCollectorscontactperson)", conn);

Posted 15-Jun-13 9:32am

mikeoabban

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mike Meinz · Accepted Answer · 2013-06-15T09:42:00

In your Where clause, CollectorId and conpersonid were not preceded by either a. or b. table alias. In the example below, I preceded them by a. table alias.

SQL

SqlDataAdapter adp = new SqlDataAdapter("SELECT a.Collectorid, a.Title, a.Surname, a.Firstname, a.Middlename, a.Gender, a.Dateofbirth, a.Nationality, a.Religion, a.Maritalstatus, a.Spousename, a.Telephone, a.Postaladdress, a.Residentialaddress, a.Hometownaddress from tblCollectorsRegistration a JOIN tblCollectorscontactperson b ON (a.Collectorid = b.Collectorid) WHERE a.Collectorid = '" + this.txtCollectorid.Text + "' AND a.conpersonid = (SELECT MIN(conpersonid) FROM tblCollectorscontactperson)", conn);

Also, by using the parameter this.txtCollectorid.Text in a concatenated string, you leave your application open to SQL Injection Attack. All parameters should be passed using the SQLParameter Class. Using SQLParameter Class also improves performance.

Guy Wouters · Accepted Answer · 2013-06-15T09:42:00

you forgot the table prefix of the Collectorid in the where clause.

Here the corrected version that should work:

SqlDataAdapter adp = new SqlDataAdapter("SELECT a.Collectorid, a.Title, a.Surname, a.Firstname, a.Middlename, a.Gender, a.Dateofbirth, a.Nationality, a.Religion, a.Maritalstatus, a.Spousename, a.Telephone, a.Postaladdress, a.Residentialaddress, a.Hometownaddress from tblCollectorsRegistration a JOIN tblCollectorscontactperson b ON (a.Collectorid = b.Collectorid) WHERE a.Collectorid = '" + this.txtCollectorid.Text + "' AND conpersonid = (SELECT MIN(conpersonid) FROM tblCollectorscontactperson)", conn);

Ambiguous column name in my sql query

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0