I have decided what the Power of scripting script should do! If you move a share by moving it in Windows Explorer, the share will stop work. If you move the folder with File System Object from vbscript, the share will still be there but will be pointing at the old path that no longer exists. So how to solve this?
I know a few ways that you don't. My first attempt was to use the winnt://localhost/lanmanserver/ object to try updating the path of the share. No luck... the property is read only!
My next attempt was using WMI instead. Same thing, unable to update the path. So I thought I would delete the share and then create it again. Well enough, that worked, however, I didn't manage to get the rights for the share to come along to the new one. There are methods to extract the access mask for the share and supply it when creating a new one, so I think it can be solved. I didn't have the time to do so this time and I think I proved my point about the power of scripting.
At the same time, I have learned or realized a few things that I hadn't thought about. Most scripts I have written in the past had been for controlled environments. By that, I mean a system where a specific task was asked from the script and the run was always with the same parameters. Here, I'm writing a script that should run on different versions of the operating system and with several different variables.
So some of the limitations I ran into can be expressed in the words: Access Denied! It was issues with running some of the commands from the script without running it with elevation. This is no issue running it from the command prompt with cscript moveshare.vbs as long as you start the cmd with elevation (right-click and select Run As Administrator). There are ways around this even with the "double-click execution" of scripts that are discussed in detail here.
So the window version of the script is pretty useless with a standard setup. However, if you run the script with elevation from the cmd
, you will be able to move shares around on the disk. The script is pretty ruff around the edges and some more error handling and stuff needs to be added. They probably will be solvable to get the share to keep its access list as well. This script should be seen as a proof of concept.
Option explicit
Dim FSO
Set FSO = CreateObject("Scripting.FileSystemObject")
If (InStr(1, WScript.FullName, "cscript", vbTextCompare)) Then
InitConsole
ElseIf (InStr(1, WScript.FullName, "wscript", vbTextCompare)) Then
InitWindow
Else
wscript.echo "How the hell did you start this script?"
End If
Set FSO = Nothing
Sub InitConsole()
If (Wscript.Arguments.Count < 2) Then
wscript.echo "Move share script"
wscript.echo ""
wscript.echo "Use: cscript moveshare.vbs {source} {destination}"
wscript.echo ""
wscript.echo "source = complete path of the shared folder"
wscript.echo "destination = full path of the folder where the shared folder _
should be moved"
wscript.echo ""
wscript.echo "moveshare.vbs Kristofer Källsbo http://www.hackviking.com"
Else
Dim sourcePath, destPath
sourcePath = Wscript.Arguments(0)
destPath = Wscript.Arguments(1)
If Not (FSO.FolderExists(sourcePath)) Then
wscript.echo "Source path was not found!"
Exit Sub
End If
If Not (FSO.FolderExists(destPath)) Then
wscript.echo "Destination path was not found!"
Exit Sub
End If
wscript.echo MoveShare(sourcePath, destPath)
End If
End Sub
Sub InitWindow()
Dim sourcePath, destPath, msgboxRetval
sourcePath = InputBox("This script will move an entire shared folder to a _
new location without losing the share!" & vbNewLine & vbNewLine & _
"Enter path of share:", "Move Share Script")
If (sourcePath = "") Then
msgboxRetval = MsgBox("Source path not entered or cancel was clicked!", _
vbOKOnly+vbCritical, "Source path error!")
Exit Sub
Else
If Not (FSO.FolderExists(sourcePath)) Then
msgboxRetval = MsgBox("Source path was not found!", _
vbRetryCancel+vbCritical+vbDefaultButton1, "Source path error!")
If (msgboxRetval = 4) Then
InitWindow
End If
Exit Sub
End If
End if
destPath = InputBox("Enter destination path of share:", "Move share script")
If (destPath = "") Then
msgboxRetval = MsgBox("Destination path not entered or cancel was clicked!", _
vbOKOnly+vbCritical, "Destination path error!")
Exit Sub
Else
If Not (FSO.FolderExists(destPath)) Then
msgboxRetval = MsgBox("Destination path was not found!", _
vbRetryCancel+vbCritical+vbDefaultButton1, "Destination path error!")
If (msgboxRetval = 4) Then
InitWindow
End If
Exit Sub
End If
End If
wscript.echo MoveShare(sourcePath, destPath)
End Sub
Function MoveShare(sourcePath, destPath)
Dim retval, objWMI, objInstances, objInstance, sourceFolder, _
sourceName, AccessMask, AllowMaximum, Caption, Description, _
MaximumAllowed, Name, shareType, delRetval, objNewShare, createRetval
destPath = destPath & "\"
Set objWMI = GetObject("winmgmts://./root\cimv2")
Set objInstances = objWMI.InstancesOf("Win32_Share",48)
Set sourceFolder = FSO.GetFolder(sourcePath)
sourcePath = sourceFolder.Path
sourceName = sourceFolder.Name
For Each objInstance in objInstances
If(objInstance.Path = sourcePath) Then
With objInstance
AccessMask = .AccessMask
AllowMaximum = .AllowMaximum
Caption = .Caption
Description = .Description
MaximumAllowed = .MaximumAllowed
Name = .Name
shareType = .Type
End With
delRetval = objInstance.Delete()
If Not(delRetval = 0) Then
retval = "Error: Unable to delete share!" & vbNewLine & _
"Error code: " & delRetval
MoveShare = retval
Exit Function
End If
End If
Next
On Error Goto 0
FSO.MoveFolder sourcePath, destPath
Set objNewShare = objWMI.Get("Win32_Share")
createRetval = objNewShare.Create(destPath & sourceName, Name, _
shareType, MaximumAllowed, Description, null, null)
If Not(createRetval = 0) Then
retval = "Error: New share not created!"
End If
MoveShare = retval
End Function