Re: richText box uses to much CPU - C# Discussion Boards

9-May-05 23:27

Hey!

I am displaying everything that comes in on the serialPort in a RichTextBox.

I have made a stress test program that sends as much as it can to my program through the serialPort.

The Performance startas out as normal, but after a while I notice that it goes from 10% up to 100% of CPU usage in about 2 min (depending on the threshold of the RecivedDataEvent(in this case 32 bits))?

On the RichTextBox i am using a scrool to bottom code like this:

<br />
                rtIncomeLogg.AppendText(inData);<br />
<br />
                if (AUTOSCROLL)<br />
                {<br />
                    rtIncomeLogg.HideSelection = false;<br />
                    rtIncomeLogg.Select(rtIncomeLogg.TextLength, 0);<br />
                }<br />

I have tryed do unhook the rtIncomeLogg.AppendText(inData); so no data is appended to the textbox, and by doing this it lays on 10%-15% CPU usage.

I thougt that maby the textbox is becoming full and have problem appending text at the bottom, so a tryed to remove data so the lenth not exided 5000, but i dident got this to work(used the richTextBox.text.remove(0,nrOver5000).

I realy need to display data little by little.

Do you got any ide how to fasten this up? Maby clipboard is an ide? Maby regular textbox is betther then richtextbox?

Best Regards
Jimmy

mav.northwind9-May-05 23:50

mav.northwind

9-May-05 23:50

The RichTextBox definitely isn't the best choice for this kind of output!

You could use a plain TextBox or, what I'd consider the best solution, a ListBox, where you can add entries, make the last entry visible and remove entries from the beginning of the list without too much trouble.
That way you can keep your logging entries to 100, 500, or whatever suits your needs.

mav

Snowjim9-May-05 23:55

9-May-05 23:55

Thanks!

I will test the plain TextBox. The ListBox would be some problems for me, the input on the serial port is not readed by row but read exisiting, this means that the rows will be strange.

Best Regards
SnowJim

S. Senthil Kumar10-May-05 0:06

10-May-05 0:06

I bet your RecivedDataEvent comes in through a non UI thread. You must not call AppendText or for that matter any method/property at all on the textbox from within that thread.

You need to call BeginInvoke or Invoke to marshal the call to the UI thread. Have a look at http://www.codeproject.com/useritems/begininvoke.asp[^]. It explains why you need to do that and also tells you how to use BeginInvoke.

Regards
Senthil
_____________________________
My Blog | My Articles | WinMacro

Snowjim10-May-05 0:11

10-May-05 0:11

Yes i am using Invoke, i know that only the creating thread would be operating on the object/control.

I have no tested the plain textbox and its MUCH faster it semes like, but it also uses alot more CPU.

now its starts on 50% and it increase a little.

I will run more testst.

The problem with plain textbox simes to be that it is not using the \r\n propperly? insted it becomes a square??

Is there any setting for this? in richtextbox this works fine!

Best Regards
SnowJim

S. Senthil Kumar10-May-05 0:30

10-May-05 0:30

You can try System.Environment.NewLine

Regards
Senthil
_____________________________
My Blog | My Articles | WinMacro

S. Senthil Kumar10-May-05 0:35

10-May-05 0:35

And did you try BeginInvoke instead of Invoke?

Regards
Senthil
_____________________________
My Blog | My Articles | WinMacro

Snowjim10-May-05 2:32

10-May-05 2:32

BeginInvoke helpt alot! Thanks!

'System.NullReferenceException' inside an Array

mav.northwind10-May-05 2:20

mav.northwind

10-May-05 2:20

The plain TextBox uses just \n as line separator, while the RichTextBox uses \r\n.

Regards,
mav

Vinnepin9-May-05 22:52

Vinnepin

9-May-05 22:52

Hey guys,

I got a little problem with an Array i made.

Here is the code:

<br />
using System;<br />
using MTV3D65;<br />
<br />
namespace Template<br />
{<br />
<br />
	/// <summary><br />
	/// Summary description for Grass.<br />
	/// </summary><br />
	public class GrassFactory<br />
	{<br />
<br />
		const float LandScapeSize = 256 * 8;   //the size of the landscape<br />
		const float GrassNumber = 200;         //the number of grassmeshes on a tile<br />
		const float NumberOfTiles = 12; <br />
<br />
		private int i;<br />
		private int x;<br />
		private int y;<br />
		private GrassType[,,] Grass;<br />
		private TVMesh[] GrassMeshes = new TVMesh[4];  //number of mesh types (grass, busg, rock...)<br />
<br />
		<br />
		//These variables are used internally. Don't f*** with them. :)<br />
		private float CamTilePosX;<br />
		private float CamTilePosY;<br />
		private float Distance;<br />
		private float DistX;<br />
		private float DistZ;<br />
		private float TranspDistance;<br />
		private float Transparency;<br />
		private float OneTileSize;<br />
		private float Denominator;<br />
		private float Transp2;<br />
<br />
		TVGlobals Globals;<br />
		TVEngine TV;<br />
<br />
<br />
		public GrassFactory(TVLandscape Land, TVScene Scene)<br />
		{<br />
			Globals = new TVGlobals();<br />
			TV = new TVEngine();<br />
<br />
			float PosX;<br />
			float PosZ;<br />
			float MeshRandom;<br />
			Random random = new Random();<br />
			<br />
			GrassType[,,] Grass = new GrassType[(int)NumberOfTiles, (int)NumberOfTiles, (int)GrassNumber];<br />
			  <br />
			OneTileSize = LandScapeSize / NumberOfTiles;<br />
			  <br />
			GrassMeshes[0] = Scene.CreateBillboard(Globals.GetTex("Tree01"), 0, 0, 0, 8, 4, "", true);<br />
			GrassMeshes[1] = Scene.CreateBillboard(Globals.GetTex("Tree02"), 0, 0, 0, 5, 6, "", true);<br />
			GrassMeshes[2] = Scene.CreateBillboard(Globals.GetTex("Tree03"), 0, 0, 0, 4, 7, "", true);<br />
			GrassMeshes[3] = Scene.CreateBillboard(Globals.GetTex("Tree04"), 0, 0, 0, 3, 2, "", true);<br />
			GrassMeshes[0].SetCollisionEnable(false);<br />
			GrassMeshes[1].SetCollisionEnable(false);<br />
			GrassMeshes[2].SetCollisionEnable(false);<br />
			GrassMeshes[3].SetCollisionEnable(false);<br />
			  <br />
			for (y = 0; y < (NumberOfTiles - 1); y++) <br />
			{<br />
				for (x = 0; x < (NumberOfTiles - 1); x++) <br />
				{<br />
					//Grass[x, y, 0].MeshType = (int)GrassNumber;   //IMPORTANT: this holds the number of meshes on this tile!!!! I know it's ugly but it works.<br />
					for (i = 1; i < GrassNumber; i++) <br />
					{<br />
						TV.AddToLog("X:" + x + " Y:" + y + " i:" + i);<br />
<br />
						PosX = OneTileSize * x + (float)random.NextDouble() * OneTileSize;<br />
						PosZ = OneTileSize * y + (float)random.NextDouble() * OneTileSize;<br />
						MeshRandom = (float)random.NextDouble();<br />
						Grass[x, y, i].Position.x = PosX;<br />
						Grass[x, y, i].Position.y = Land.GetHeight(PosX, PosZ);<br />
						Grass[x, y, i].Position.z = PosZ;<br />
						Grass[x, y, i].ColorR = 0.9f;<br />
						Grass[x, y, i].ColorG = 0.9f;<br />
						Grass[x, y, i].ColorB = 0.8f;<br />
						Grass[x, y, i].Size = Globals.Vector((float)random.NextDouble() * 0.4f + 0.8f, (float)random.NextDouble() * 0.4f + 0.8f, (float)random.NextDouble() * 0.4f + 0.8f);<br />
			          <br />
						if (MeshRandom > 0.2) <br />
						{      //Type of mesh<br />
							Grass[x, y, i].MeshType = 0;<br />
						}<br />
						else if (MeshRandom > 0.15) <br />
						{<br />
							Grass[x, y, i].MeshType = 1;<br />
						}<br />
						else if (MeshRandom > 0.1) <br />
						{<br />
							Grass[x, y, i].MeshType = 2;<br />
						}<br />
						else<br />
						{<br />
							Grass[x, y, i].MeshType = 3;<br />
						}<br />
					}<br />
				}<br />
			}<br />
			  <br />
			TranspDistance = OneTileSize * 0.9f;  //this is the range of transparent area. 0.9999: the meshes pop up, 0:everything is transparent at least a bit<br />
			  <br />
			Denominator = 1 / ((OneTileSize * OneTileSize) - (TranspDistance * TranspDistance)); //needed for calculation speedup<br />
			Transp2 = TranspDistance * TranspDistance;   //needed for calculation speedup<br />
		}<br />
<br />
		public void Render(MTV3D65.TV_3DVECTOR CamPos)  //this tells what tiles should be rendered. Campos is the camera's position vector<br />
		{<br />
			GrassMeshes[0].Enable(true);<br />
			GrassMeshes[1].Enable(true);<br />
			GrassMeshes[2].Enable(true);<br />
			GrassMeshes[3].Enable(true);<br />
			CamTilePosX = (CamPos.x - OneTileSize / 2) / OneTileSize;<br />
			CamTilePosY = (CamPos.z - OneTileSize / 2) / OneTileSize;<br />
<br />
			DrawSurround(CamTilePosX, CamTilePosY, CamPos);<br />
<br />
			if (CamTilePosX - 1 >= 0 && CamTilePosY - 1 >= 0) <br />
				DrawSurround(CamTilePosX - 1, CamTilePosY - 1, CamPos);<br />
			<br />
			if (CamTilePosY - 1 >= 0) <br />
				DrawSurround( CamTilePosX, CamTilePosY - 1, CamPos);<br />
		<br />
			if (CamTilePosX + 1 < NumberOfTiles && CamTilePosY - 1 >= 0) <br />
				DrawSurround( CamTilePosX + 1, CamTilePosY - 1, CamPos);<br />
			<br />
			if (CamTilePosX - 1 >= 0 && CamTilePosY + 1 < NumberOfTiles) <br />
				DrawSurround( CamTilePosX - 1, CamTilePosY + 1, CamPos);<br />
			<br />
			if (CamTilePosY + 1 < NumberOfTiles) <br />
				DrawSurround( CamTilePosX, CamTilePosY + 1, CamPos);<br />
			<br />
			if (CamTilePosX + 1 < NumberOfTiles) <br />
				DrawSurround( CamTilePosX + 1, CamTilePosY, CamPos);<br />
			<br />
			if (CamTilePosX + 1 < NumberOfTiles && CamTilePosY + 1 < NumberOfTiles) <br />
				DrawSurround( CamTilePosX + 1, CamTilePosY + 1, CamPos);<br />
			<br />
			if (CamTilePosX - 1 >= 0) <br />
				DrawSurround( CamTilePosX - 1, CamTilePosY, CamPos);<br />
			<br />
			GrassMeshes[0].Enable(false);<br />
			GrassMeshes[1].Enable(false);<br />
			GrassMeshes[2].Enable(false);<br />
			GrassMeshes[3].Enable(false);<br />
		}<br />
		<br />
		private void DrawSurround(float x, float y, MTV3D65.TV_3DVECTOR CamPos)<br />
		{<br />
			for (i = 1; i < Grass[(int)x, (int)y, 0].MeshType; i++) <br />
			{<br />
				GrassMeshes[Grass[(int)x, (int)y, i].MeshType].SetPosition(Grass[(int)x, (int)y, i].Position.x, Grass[(int)x, (int)y, i].Position.y, Grass[(int)x, (int)y, i].Position.z);<br />
				GrassMeshes[Grass[(int)x, (int)y, i].MeshType].SetScale(Grass[(int)x, (int)y, i].Size.x, Grass[(int)x, (int)y, i].Size.y, Grass[(int)x, (int)y, i].Size.z);    //you may disable this line to gain a few (5-6) FPS<br />
				DistX = Grass[(int)x, (int)y, i].Position.x - CamPos.x;<br />
				DistZ = Grass[(int)x, (int)y, i].Position.z - CamPos.z;<br />
				Distance = (DistX * DistX + DistZ * DistZ);<br />
<br />
				if (Distance > Transp2) <br />
				{<br />
					Transparency = 1 - ((Distance - Transp2) * Denominator);<br />
					if (Transparency > 0) <br />
					{<br />
						GrassMeshes[Grass[(int)x, (int)y, i].MeshType].SetColor(Globals.RGBA(Grass[(int)x, (int)y, i].ColorR, Grass[(int)x, (int)y, i].ColorG, Grass[(int)x, (int)y, i].ColorB, Transparency));<br />
						GrassMeshes[Grass[(int)x, (int)y, i].MeshType].Render();<br />
					}<br />
				}<br />
				else<br />
				{<br />
					GrassMeshes[Grass[(int)x, (int)y, i].MeshType].SetColor(Globals.RGBA(Grass[(int)x, (int)y, i].ColorR, Grass[(int)x, (int)y, i].ColorG, Grass[(int)x, (int)y, i].ColorB, 1));<br />
					GrassMeshes[Grass[(int)x, (int)y, i].MeshType].Render();<br />
				}<br />
					<br />
			}<br />
		}<br />
	}<br />
}<br />

And this is the GrassType class:

<br />
using System;<br />
using MTV3D65;<br />
<br />
namespace Template<br />
{<br />
	/// <summary><br />
	/// Summary description for GrassType.<br />
	/// </summary><br />
	public class GrassType<br />
	{<br />
<br />
		public int MeshType;<br />
		public MTV3D65.TV_3DVECTOR Position;<br />
		public MTV3D65.TV_3DVECTOR Size;   //maybe you don't need this<br />
		public float ColorR;<br />
		public float ColorG;<br />
		public float ColorB;<br />
<br />
		public GrassType()<br />
		{<br />
			MeshType = 0;<br />
			Position = new TV_3DVECTOR();<br />
			Size = new TV_3DVECTOR();<br />
			ColorR = 0;<br />
			ColorG = 0;<br />
			ColorR = 0;<br />
		}<br />
	}<br />
}<br />

I get my Error when i fist try to acces the array:
Grass[x, y, i].Position.x = PosX;

I really dont know why, because i init my array correcly (atleast i think).

Do u guys know what im doing wrong here?

Re: 'System.NullReferenceException' inside an Array

S. Senthil Kumar9-May-05 23:28