C / C++ / MFC

3-Sep-06 9:21

Hi,

I'm having difficulties using CString's LoadString under VC++ 8.0. I'm not sure what to make of it. I'm attempting to load a string from resources and getting back an incomplete string, e.g. "This application is registered to %1 %2For use on the computer named %3 only." and getting back, "This application is registered to %1????". The '?' are inserted into the string. I'm a total newbee to VC++ 8.0.

It seems to be random, cause loading strings from the resource seems to work correctly in the instances above the lines of code before calling the last LoadString.

e.g.
BOOL CAboutDlg::OnInitDialog()
{
CDialog::OnInitDialog();

// TODO: Add extra initialization here
CString cs0, cs1, cs2, cs3, cs4;

DWORD dwSizeUserName, dwSizeComputerName, dwError;

char szUserName[MAX_COMPUTERNAME_LENGTH + 1];
char szComputerName[MAX_COMPUTERNAME_LENGTH + 1];

dwSizeUserName = MAX_COMPUTERNAME_LENGTH + 1;
dwSizeComputerName = MAX_COMPUTERNAME_LENGTH + 1;

szUserName[0]=0;
szComputerName[0]=0;

m_nAppIcon.SetIcon(::LoadIcon(theApp.m_hInstance, MAKEINTRESOURCE(IDR_MAINFRAME)) );

cs0.Empty();
cs0.LoadString(AFX_IDS_APP_TITLE);

AfxSetWindowText(::GetDlgItem(this->m_hWnd, IDC_STATICTEXTAPPNAME), cs0);

cs0.Empty();
cs1.Empty();
cs2.Empty();
cs3.Empty();
cs4.Empty();

cs1.LoadString(IDS_STRABOUTAPPINFO);
// IDS_STRABOUTAPPINFO =
// File Version: %s\nProduct Version: %s\nApplication Info: %s\n\n%s by
// %s. All Rights Reserved.

cs2.LoadString(IDS_FILEINFOCOMMENTS);
// IDS_FILEINFOCOMMENTS = Comments

cs3.LoadString(IDS_FILEINFOLEGALCOPYRIGHT);
// IDS_FILEINFOLEGALCOPYRIGHT = LegalCopyRight

cs4.LoadString(IDS_FILEINFOCOMPANYNAME);
// IDS_FILEINFOCOMPANYNAME = CompanyName

cs0.Format( cs1,
CAppUtilitylFunctions::GetFileVersionX(),
CAppUtilitylFunctions::GetProductVersionX(),
CAppUtilitylFunctions::GetVersionInfo(NULL, cs2),
CAppUtilitylFunctions::GetVersionInfo(NULL, cs3),
CAppUtilitylFunctions::GetVersionInfo(NULL, cs4));

AfxSetWindowText(::GetDlgItem(this->m_hWnd, IDC_STATICTEXT1), cs0);

if( !(::GetUserName(szUserName, &dwSizeUserName)) )
{
dwError = GetLastError ();
}
if( !(::GetComputerName(szComputerName, &dwSizeComputerName)) )
{
dwError = GetLastError ();
}
else
{
cs0.Empty();
cs1.Empty();

// THIS LOAD FAILS TO LOAD ALL OF THE STRING IN THE RESOURCE
cs1.LoadString(IDS_ABOUTAPPINFO);
// IDS_ABOUTAPPINFO =
// This application is registered to %1 %2For use on the computer
// named %3 only.

cs0.FormatMessage( cs1,
szUserName,
"\n",
szComputerName);

AfxSetWindowText(::GetDlgItem(this->m_hWnd, IDC_STATICTEXT2), cs0);
}

return TRUE; // return TRUE unless you set the focus to a control
// EXCEPTION: OCX Property Pages should return FALSE
}

Cry | :((

Can someone shed some light on this for me? I'm thinking that it must have something to do with project settings....

Thanks!

Jon68z

prasad_som3-Sep-06 22:56

3-Sep-06 22:56

Jon68z wrote:
// THIS LOAD FAILS TO LOAD ALL OF THE STRING IN THE RESOURCE
cs1.LoadString(IDS_ABOUTAPPINFO);
// IDS_ABOUTAPPINFO =
// This application is registered to %1 %2For use on the computer
// named %3 only.

Can you check its return value ? Its BOOL.
To narrow down the problem , can you check value in cs1, by showing it in message box?

Prasad
Notifier using ATL

Jon68z3-Sep-06 23:32

3-Sep-06 23:32

Hi,

Thanks for the reply. using bool bRet, e.g. bRet = cs1.LoadString(IDS_ABOUTAPPINFO); The return value is 'true'. The string returned however is truncated and contains, cs1 "This application is registered to %?????" ATL::CStringT<char,StrTraitMFC_DLL<char,ATL::ChTraitsCRT<char> > > as reported in the VC++ 8.0 IDE 'Autos' tab.

If I use a line like 'CString cs5(MAKEINTRESOURCE(IDS_ABOUTAPPINFO));' cs5 is equal to the same malformed string as if I loaded it from the resource string table above.
Cry | :((

Do I have to specify something in my project settings ? Confused | :confused:

Or is something getting screwed up in the string table.... OMG | :OMG:

Thanks!

Jon68z

prasad_som4-Sep-06 0:05

4-Sep-06 0:05

Problem seems to be with format specifiers you have mentioned. Can you see same problem with strings without format specifiers(%).

Prasad
Notifier using ATL

Jon68z4-Sep-06 0:33

4-Sep-06 0:33

Hi,

Thanks for your reply. Actually, if I move the string loading to the top of the function, it works correctly. The entire string is loaded. I've tried several locations to narrow down where the load string gets truncated, but have not found the problem.

This is driving me mad, as I know something else is wrong, and it is not LoadString() per se, but have not been able to find the problem.

Thanks!

Jon68z

Jon68z4-Sep-06 0:50

4-Sep-06 0:50

Hi,

I've changed the previous Format to FormatMessage and the specifiers to %1, %2, %3, etc. and all seems to be fine with the string loading as it should. It is hard for me to believe that using CString Format could screw up memory on an unrelated LoadString.... Hmmm.

Any body have any ideas on this?

Please help....

Thanks!

Jon68z

prasad_som4-Sep-06 1:51

4-Sep-06 1:51

There is difference bet'n Format and FormatMessage, the way format specifiers are mentioned.
::FormatMessage documentation in MSDN can through some light on it.

Jon68z wrote:
It is hard for me to believe that using CString Format could screw up memory on an unrelated LoadString.... Hmmm.

Actually , instead of using same variable(using Empty), try using different variables.(this is just wild try).

Prasad
Notifier using ATL

CPropertySheet

ftsOne3-Sep-06 9:10

ftsOne

3-Sep-06 9:10

Hi,

I have a CPropertySheet embeded in a CPropertyPage.
Can anyone tell me how to move or size the embeded property sheet?

Thanks in advance
Ferdinand

Certification

messages3-Sep-06 8:12

3-Sep-06 8:12

Hi everyone,
I have again question I read about Certification from microsoft MCAD/MCSD
here[^] but i want to know
for which languages is it for VC++

Re: Certification

Waldermort3-Sep-06 8:19

Waldermort

3-Sep-06 8:19

You should read the full page, in particular the content of the exams. ASP.NET, VB.NET, C#.NET... Think of .NET as an extension to all of the programing languages.

Re: Certification

messages3-Sep-06 8:33

3-Sep-06 8:33

Thanks waldermort for help i read full page but i cant find that VC is in these exams or not and i want to know do you have any document for VC like document for C# or ASP.NET

Error

messages3-Sep-06 8:04

3-Sep-06 8:04

Hi everyone,
When i want to open my project i get this error
Project 'C:\MyBook\MyBook.vcproj' failed to open.
Thanks

Re: Error

Waldermort3-Sep-06 8:20

Waldermort

3-Sep-06 8:20

try deleting all of the extra files that VS adds to the directory. But make sure not to delete the .dsp and .dsw files.

Re: Error

messages3-Sep-06 8:33

How to get a pointer of the active view?

3-Sep-06 8:33

I dont have .dsp or .dsw i use VS2003 which files i need to delete

yummi3-Sep-06 7:45

3-Sep-06 7:45

Hi,
I want to get the active childframe in a MDI application when I am in the ViewClass. I need a pointer of CWnd to use it as parameter for MDIActivate.

Can someone tell me how to get it?
Thanks for help
yummi

Nader Elshehabi3-Sep-06 12:11

Nader Elshehabi

3-Sep-06 12:11

Hello

1- CWnd::GetActiveWindow(). Doesn't it work with you?
2- Or even better CWnd::GetTopWindow().

Regards

yummi3-Sep-06 22:50

3-Sep-06 22:50

Hi Nader,
thanks for your reply. So I got the window, but I can't use it for what I want to do.
In my MDI application I open new childframes automaticly but I want to stay the actually childframe in front.
I tried this way:

CMDIFrameWnd *pFrame = (CMDIFrameWnd*)AfxGetApp()->m_pMainWnd;
// Get the active MDI child window.
CMDIChildWnd *pChild = (CMDIChildWnd *) pFrame->GetActiveFrame();

// Get the active view attached to the active MDI child window.
CErgebnislisteView *pView = (CErgebnislisteView *) pChild->GetActiveView();

//Open new childframes
for(i=0; i< arrVerz.GetSize(); i++)
{
            //set some variables and open it with the next line
    theApp.OnOldTurnier();
}

    //activate the old childframe

    pChild->SetActiveView(pView);      //nothing happens

Do you have an idea how do do it?
yummi

prasad_som4-Sep-06 0:34

4-Sep-06 0:34

yummi wrote:
CErgebnislisteView *pView = (CErgebnislisteView *) pChild->GetActiveView(); //Open new childframes for(i=0; i< arrVerz.GetSize(); i++) { //set some variables and open it with the next line theApp.OnOldTurnier(); } //activate the old childframe pChild->SetActiveView(pView); //nothing happens

pView is already active view. why you are setting it to active again. It must be working.

Prasad
Notifier using ATL

yummi4-Sep-06 0:43

4-Sep-06 0:43

Hi Prasad,

thanks for your reply. I want to reach, that after I opened a few new childframes, that the chilframe that was on top before I open the new ones, is on top again. With the line pChild->SetActiveView(pView) I tried to reach it.

grettings
yummi

I've got it :-)

yummi4-Sep-06 1:05