|
Yes, this is another feature that is on my list of to-dos. I am pretty sure I know how to do this, but I didn't want to spend the time until Chris gave it a yay or nay. 
If Chris decides to use it in one form or another, I have a list of features I will implement to make the whole system smoother than this prototype.
I am glad you like it.
Jason Jystad
|
|
|
|
|
Actually, I went out to the prototype page and re-tested it. I wanted to make sure that I was correctly remembering what it presently did.
What it does now is highlight the selection AND the newly inserted tag(s). Is this what you mean, or did you have some other behaviour in mind? If you wanted a different behaviour, please describe it to me so I can include it on my list correctly.
(Remember that the full functionality of this prototype is limited to IE 4.x+ on Win32 platforms. I will be doing the cross-browser mods if Chris chooses to implement this.)
Thanks for the suggestions!
Jason Jystad
|
|
|
|
|
Jason Jystad wrote:
What it does now is highlight the selection AND the newly inserted tag(s).
That is what i meant; but it doesn't work for me 
I'm using IE 6.0.26 on Win2k; i'll try it on WinXP when i get home.
---Shog4---
From now on we can call C# and MC++ "The square wheel languages" -- Jack Handy, The Lounge
|
|
|
|
|
Really!!?!
I am using IE 6.0.26 on Win2k Pro here and it works flawlessly. What does it do on yours?
Jason Jystad
|
|
|
|
|
I went back and tried it again; you are correct, it does select the text + tags correctly - but it sometimes does not show the selection!
When i select text with the keyboard, everything is good, after i press one of the buttons it will display the new selection and the edit box will have focus.
But if i select text using the mouse, and then click one of the buttons, the box has focus, but the selection is not visible, and the cursor is gone. The only way i can tell it is selected is to type something (since that deletes the selection) or hold down shift and move the mouse (since that extends the selection).
It is very strange... But at least it works via the keyboard 
---Shog2---
From now on we can call C# and MC++ "The square wheel languages" -- Jack Handy, The Lounge
|
|
|
|
|
Great hopping horney toads!!!!
I guess I have my first bug report. I will use it to create my first entry in a new list.
*sigh*
Jason Jystad
|
|
|
|
|
Ok, I just tested this from my end and it get even weirder. I get the same results you do, which is weird enough, but I also noticed that if you use the mouse to select a word by double clicking the word then it works perfectly. The tags are inserted and the whole thing is selected and shown.
So the only way it doesn't show the highlighed selection is if you actually click and drag to highlight the initial selection. This is too damn weird. 
I will work on this. Thanks for bringing it to my attention Shog.
Jason Jystad
|
|
|
|
|
OK, I took a swing at fixing it. No good. I think it may be some kind of screwy IE bug. Let me know how XP handles it. I'll try it on IE 5.5 when I get home.
Jason Jystad
|
|
|
|
|
It acts the same on WinXP; must be a IE6 problem. Good luck tracking it down
---Shog9---
From now on we can call C# and MC++ "The square wheel languages" -- Jack Handy, The Lounge
|
|
|
|
|
Its a *feature* not a bug damnit! 
Ah well, I'll try to figure out a work-around but don't hold your breath.
Jason Jystad
|
|
|
|
|
It looks great , however is it possible when you click on a button (i.e Bold) for the caret to be automatically placed between the tags and not at the end?
Good job!
Best regards,
Alexandru Savescu
|
|
|
|
|
Good thought!
I think I can see a way to do this, it will probably have to be Win32 IE specific due to some limitations in Netscape and Mac IE JavaScript.
I will add this to my list of "Things to implement if Chris says he'll use it".
Alexpro wrote:
Good job!
Thanks. 
Jason Jystad
|
|
|
|
|
I appreciate everybody posting their comments/suggestions for this.
I want you all to know that I am keeping a list of the suggestions and I will do my best to implement them all if Chris says he will use this.
As for the general comments, I am not keeping a list of them unless the suggest improvements. But rest assured that I am basking in them and reading them over and over again. (Can we tell who doesn't get much positive feedback at work?  ) Thanks for all of the comments so far, and in advance for any more that come along.
Jason Jystad
|
|
|
|
|
No changes to functionality, I was trying to debug the problem Shog noticed and when I was unable to fix it I had to do something to give me a feeling of accomplishment. 
I just took a lap through the code to optimize a few things, make it neater and more consistant, and add some error checking. Otherwise no differences should be noticable.
Jason Jystad
|
|
|
|
|
|
Hmm, no I hadn't seen that one. Thanks, looks to be worth reading.
Only thing I see wrong with this is that it isn't possible to make it cross browser compatible. I am certain I can make the functions above fully cross browser. I am pretty sure that I can even get them cross browser with minimal to no loss of functionality.
So what do you think of my button bar? Yes? No? Go soak my damn head and stop suggesting things?
Jason Jystad
|
|
|
|
|
If you're going to add tags, you should place the cursor between them. Otherwise, a cool idea....
Christian
The tragedy of cyberspace - that so much can travel so far, and yet mean so little.
And you don't spend much time with the opposite sex working day and night, unless the pizza delivery person happens to be young, cute, single and female. I can assure you, I've consumed more than a programmer's allotment of pizza, and these conditions have never aligned. - Christopher Duncan - 18/04/2002
|
|
|
|
|
Christian Graus wrote:
you should place the cursor between them
I donno why, but that sentence looks like it came out of a pr0n book
Nish
Regards,
Nish
Native CPian.
Born and brought up on CP.
With the CP blood in him.
|
|
|
|
|
This feature will be included in the next upgrade. 
Seriously though, I am working on this I just haven't worked all the bugs out yet.
Jason Jystad
|
|
|
|
|
Jason Jystad wrote:
With important input from Nish
Thanks Jason 
Nish
Regards,
Nish
Native CPian.
Born and brought up on CP.
With the CP blood in him.
|
|
|
|
|
Thank you for the input. The convert button was your idea, and now it is my favorite feature.
Now if I could just get Chris to give me a thumbs up or a thumbs down.
Jason Jystad
|
|
|
|
|
Jason Jystad wrote:
Now if I could just get Chris to give me a thumbs up or a thumbs down
lol! I honestly haven't had a chance to look over it carefully. OK <tappity> Let's give it a burl.- Looks good.
- love the insert smiley thing. Well done.
- I wouldn't put spaces around the > inserts.
- It would be really, really nice to have the buttons be reversible. Thus, if a text selection starts with <small> and ends with </small>, and the 'small' button is clicked, the tags are removed instead of added.
- The addition of a URLeriser would be great. Something that takes text and wraps in <a href...> tags. If the text didn't start with "http://" then http would need to be added.
I'll definitely implement some (or most) of the functionality. Nice work Jason!!
cheers,
Chris Maunder
|
|
|
|
|
|
Jason Jystad wrote:
This is something I wanted to talk to you about. The modified InsertText function does this because I have noticed that some smilies require spaces around them before they will parse correctly. Is this by design? Or have I just been smokeing crack again? If the smiley parser doesn't require them then I'll be happy to remove the spaces
The spaces are because some smileys need spaces around them to ensure they aren't mixed up with legit words (eg : D needs a space after the 'D' so that something like ::DestroyWindow isn't turned into  estroyWindow)
Jason Jystad wrote:
So do you want me to go ahead and implement the other suggested features and make the whole thing as fully cross-browser as possible?
That would be sensational. I'll probably replace the button bar you have with a VS.NET style (I can hear the groans) menu bar.
Thanks Jason!!
cheers,
Chris Maunder
|
|
|
|
|
Chris Maunder wrote:
The spaces are because some smileys need spaces around them to ensure they aren't mixed up with legit words (eg : D needs a space after the 'D' so that something like ::DestroyWindow isn't turned into estroyWindow)
Ah, I thought it was something like that. I will add this to my list of things to look over and fix.
Chris Maunder wrote:
That would be sensational. I'll probably replace the button bar you have with a VS.NET style (I can hear the groans) menu bar.
Groans, what groans? *looks around confusedly* Why would anyone groan? I was originally planning on doing it that way myself, it was just easier to prototype it this way first. (great minds do think alike I guess )
I will get started on finishing this up asap, but right now I am going home to bed. :yawn:
Jason Jystad
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
I'll add it to the feature to-do list.