|
Thanks that have estimated an example. I know many other examples. 
The example of the change in the virtual function behavior.
class CWinApp {<br />
...<br />
virtual void WinHelp(DWORD_PTR dwData, UINT nCmd);<br />
...<br />
};<br />
<br />
class CSampleApp : public CWinApp {<br />
...<br />
virtual void WinHelp(DWORD dwData, UINT nCmd);<br />
...<br />
};
It is the common example which the developer may face while porting his application to the 64-bit architecture. Let’s follow the life-cycle of the developing of some application. Suppose it was being developed for Visual Studio 6.0. at first when the function "WinHelp" in class "CWinApp" had the following prototype:
virtual void WinHelp(DWORD dwData, UINT nCmd = HELP_CONTEXT);
It would be absolutely correct to implement the overlap of the virtual function in class "CSampleApp", as it is shown in the example. Then the project was placed into Visual Studio 2005 where the prototype of the function in class "CWinApp" underwent changes that consist in replacing "DWORD" type with "DWORD_PTR" type. On the 32-bit platform this program will continue to work properly for here "DWORD" and "DWORD_PTR" types coincide. Troubles will occur while compliling this code for the 64-bit platform. We get two functions with the same names but with different parameters the result of which is that the user’s code won’t be called.
There are also other issues which can prove on a 64-bit platform. I recommend to familiarize with article: Evgeniy Ryzhkov "Peculiarities of the Development of 64-bit Applications" in which it is possible to learn a lot of interesting on the given subjects: http://www.viva64.com/articles.php
|
|
|
|
|
I agree there are a number things to look out for when porting to 64bit.
I went through all this a year ago, i went through all my code checking every prototype (both mine and MS's) and promoting long to size_t (and other like things) where needed.
I consider the WinHelp error more of a (required) API change by MS that can break old code.
There are a bunch of other examples like that in the ODBC API, where SQLUINTEGER was changed to SQLULEN (see: sqltype.h for SQLULEN typedef).
Aside from all that, people are going to have a problem with you pushing your software here, that's why your OP was removed.
You would be better off showing the problem and a solution - posting a link to your software is not good enough.
...cmk
Save the whales - collect the whole set
|
|
|
|
|
Thank you for the details! I have no 64-bit compiler so I appreciate that!
cmk wrote: The problem is with the unsigned b, change it to int b and everything is fine again.
Of course. That's why I said that it's really up to us to know/use types correctly.
cmk wrote: To me this _should_ be a compiler bug.
The OP seems to imply it is correct (though possibly unexpected) behaviour for x64 compilers.
I don't believe it's correct behavior (hopefully someone will prove me wrong). I think the
disassembly shows that. Shouldn't the two DWORDs be promoted to QWORDs before the arithmetic?
Why is a treated as 32 bit instead of 64? And that's just for the "add". What happens after
is a WTF. Did something change in C pointer arithmetic? Did I miss a memo?
Anyway I'm glad I wouldn't code like that
Thanks again,
Mark
|
|
|
|
|
For the sake of flogging a dead horse ...
For those unaware of the changes in 64 arch:
The 64bit r?x registers extend the 32bit e?x registers
in the same way the 32bit registers extend the 16bit ?x registers.
Let's simplify the example and look at some variations:
1. Working
long a[] = {1, 2, 3};
long b = -1;
long *p = a + 2;
p = p + b;
movsxd rax,dword ptr [b] ; rax = ffffffff-ffffffff
mov rcx,qword ptr [p] ; rcx = 00000000-0012fec0
lea rax,[rcx+rax*4] ; rax = 00000000-0012febc
; rax*4 overflows gives ffffffff-fffffffc
; rcx + (rax*4) overflows, net effect is to sub 4 from rcx
; net effect is that we get the right value
mov qword ptr [p],rax ; p = 00000000-0012febc
2. Working, compiles using entirely different strategy
long a[] = {1, 2, 3};
ulong b = 1;
long *p = a + 2;
p = p - b;
mov eax,dword ptr [b] ; eax = 1, rax = 00000000-00000001
shl rax,2 ; rax *= 4, rax = 00000000-00000004
mov rcx,qword ptr [p] ; rcx = 00000000-0012fec0
sub rcx,rax ; rcx = 00000000-0012febc
mov rax,rcx ; rax = 00000000-0012febc
mov qword ptr [p],rax ; p = 00000000-0012febc
3. Fails, back to OP problem
long a[] = {1, 2, 3};
ulong b = 1;
long *p = a + 2;
p = p + (-b);
mov eax,dword ptr [b] ; eax = 1, rax = 00000000-00000001
neg eax ; eax = ffffffff, rax = 00000000-ffffffff
mov eax,eax ; noop, rax goes forth un sign extended
mov rcx,qword ptr [p] ; rcx = 00000000-0012fec0
lea rax,[rcx+rax*4] ; rax = 00000040-0012febc
; rax = 00000000-0012fec0 + (00000000-ffffffff * 4)
; rax = 00000000-0012fec0 + 00000003-fffffffc <- damn
mov qword ptr [p],rax ; p = 00000040-0012febc
What interests me is that
p = p - b;
produces such different code than
p = p + (-b);
when b is unsigned
...cmk
Save the whales - collect the whole set
|
|
|
|
|
The C and C++ languages state that in computations involving a mix of types, all values should be promoted to the largest type. In this case the expression (a + b) is performed first. Because a is int but b is unsigned int, a is promoted to unsigned int. That leaves the expression as 0xFFFFFFFE + 1, which has the value 0xFFFFFFFF.
That value is then added to ptr making an offset of nearly 4GB. It works on 32-bit only due to an overflow occurring. Whether or not that causes an access violation on 64-bit depends on what virtual memory is allocated and what the access mask is.
It feels like a pretty contrived example, though.
|
|
|
|
|
|
I stand by my original statement, i feel this _should_ be a compiler bug.
I am aware of type promotion rules, but i feel the compiler has more than enough info to 'do the right thing'.
The fact that turning on optimizations will generate correct code somewhat supports this view.
(I know _someone_ will say that even wrong code can produce right results now and then, to which i say  )
...cmk
Save the whales - collect the whole set
|
|
|
|
|
cmk wrote: I know _someone_ will say that even wrong code can produce right results now and then, to which i say
Sorry, I guess I will have to be that someone 
Seriously though, officially the code has undefined behavior, which means the C++ standard no longer imposes any requirements on what the code does, and does not require a diagnostic from the compiler. However, it's possible that the specific compiler used may document this behavior, in which case it would be safe to use (on that compiler), or it may issue a warning as a matter of QoI (quality of implementation).
--
Marcus Kwok
|
|
|
|
|
I have two dialogbars. I want docked them on right but in same column. one is on top of another.
lucy
|
|
|
|
|
You could nest them in a single CControlBar which is docked on the right.
|
|
|
|
|
Does anyone know of any image libraries that help aid with image manipulations and comparison. Something simerlar to Aforge but obviously in C++?
|
|
|
|
|
have you tried searching this site ?
|
|
|
|
|
yes but i havent found anything.
|
|
|
|
|
Hi All,
I need to write some application that getting some string and folder and check witch file in this folder ( the file are not Binary file - just text file ) contain the string that i looking.
What i mean is that i don't want to open each file and start to seek for the string.
In the windows search option we have this option to "search word or phrase in the file" - this what i looking for - how to do it with no using windows option.
Thanks for any help.
|
|
|
|
|
First thing you need to do it enumerate the directory for any file type that you are looking for. Use a combination of FindFirstFile() and FindNextFile(). Each file that you find, check the extension for whatever filetypes you want to look in ( ".txt" ). If it's a text file then open the file with CreateFile() or fopen(), read each line and do a string comparison for your string with strstr().
|
|
|
|
|
WalderMort wrote: ...then open the file with CreateFile() or fopen(), read each line and do a string comparison for your string with strstr().
But what about the "i don't want to open each file and start to seek for the string." requirement?
"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15
"Judge not by the eye but by the heart." - Native American Proverb
|
|
|
|
|
I presumed he meant he didn't want to open every single file with an arbritary file format. If you want to find something inside a file you are going to have to look inside it somehow.
|
|
|
|
|
|
After getting fed up of creating code to center a window correctly, I have finally gotton around to developing a re-usable class to do all the nitty gritty calculations for me. I pass in a desired width and height, it returns a rectangle centered to the screen. Why bother do I hear you say? How often did you take the taskbar into account when positioning a window?
Anyway, regarding the sidebar in vista, and probably XP soon, finding the window and getting it's rectangle is simple enough. But the sidebar comes with other options, like it's ability to always be on top and it's ability to hide ( or rather move of screen ).
Now first proplem, how can I detect if the sidebar is "on top" ( it's pinned to the edge of the screen and all maximized windows maximize to it's edge ) or if it's "on bottom" ( it sit's on the desktop only and other windows may cover it ).
Second, how to detect if it's on the screen, hidden or not it always has a rectangle of the same size. When it's hidden it's rectangle moves/animates off the screen, it's top edge becoming equal to the desktops bottom edge. A simple comparison of those edges should suffice, but what about mulitple-monitor desktops. If the monitors were arranged in such a way that another is below the desktop, it would appear on that monitor.
|
|
|
|
|
NM. The answer was staring me in the face, literally. I was looking in the registry wheras I needed to check for the WS_EX_TOPMOST flag. 
While I have this thread though, Can anybody think of any other windows that have a pinning ability and that may effect the correct centering of a window.
|
|
|
|
|
This is just a guess, but the sidebar is probably implemented as an appbar. All appbars have the potential to change the area available on the monitor for other windows. If you always use the work area of a monitor as the rect to center against, your code will always work no matter what app bars are present.
|
|
|
|
|
Thanks for that, and you were right. I simple call to SystemParametersInfo() did the trick.
|
|
|
|
|
Hello
All
I want to copy String table in one application to other application so how string tabe copy to other application.
Thanks And Regards
Atool
Atool
|
|
|
|
|
If by 'string tabe' you mean the string table stored in the resources, then use the resource functions to accquire access to them.
Load the application with LoadLibrary() then find a resource with FindResource() or one of the EnumerateResource***() functions.
|
|
|
|
|
Ohhh no
I want to copy string table manually from one application to other.
Thanks and Regards
Atool
Atool
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
