ASP.NET

Ben[dog] wrote:

I would think it's because GDI+ resources are being wasted/leaked somehow.. yeah?

Ben[dog] wrote:

and not being able to reproduce on the development machine doesn't help either.

Christian Graus wrote:

Ben[dog] wrote:
I would think it's because GDI+ resources are being wasted/leaked somehow.. yeah?

I'd say so

Christian Graus wrote:

You should post some code, if you want us to comment on it.

public class generateLabel : System.Web.UI.Page
{
    private ImageFormat Format;
    private Color TextColor;
    private Color TextColorOver;
    private bool Over;
    private string Text;
    private string Background;

    private void Page_Load(object sender, System.EventArgs e)
    {
        TextColorOver = Color.FromArgb(255,255,255);
        TextColor = Color.FromArgb(200,200,200);
        if (Request["Over"]!=null)
            Over = true;
        else
            Over = false;

        if (Request["Format"]!=null)
        {
            switch (Request["Format"].ToLower())
            {
                case "png":
                    ContentType = "image/png";
                    Format = ImageFormat.Png;
                    break;
                case "gif":
                    ContentType = "image/gif";
                    Format = ImageFormat.Gif;
                    break;
                case "jpg":
                case "jpeg":
                    ContentType = "image/jpeg";
                    Format = ImageFormat.Jpeg;
                    break;
            }
        }
        else
        {
            ContentType = "image/png";
            Format = ImageFormat.Png;
        }

        if (Request["Text"]!=null)
            Text = Request["Text"];
        else
            Text = "Sample";

        if (Request["Background"]!=null)
        {
            switch (Request["Background"])
            {
                case "On":
                    Background = "images/RootMenuBackgroundOn.png";
                    break;
            }
        }
        else
            Background = "images/RootMenuItemBackground.png";

        if (Cache[CacheKey]!=null)
            generateFromCacheKey();
        else
            generate();
    }

    private string key;
    private string CacheKey
    {
        get
        {
            if (key==null)
            {
                key = String.Format("Label_{0}{1}{2}",Text,Format.ToString(),Over);
            }
            return key;

        }
    }

    private void generateFromCacheKey()
    {
        Bitmap b = (Bitmap) Cache[CacheKey];

        MemoryStream io = new MemoryStream();
        b.Save(io, Format);
        Response.BinaryWrite(io.ToArray());
        io.Close();
    }

    private void generate()
    {
        try
        {

            // Create the fontsy
            PrivateFontCollection pfc=new PrivateFontCollection();
            pfc.AddFontFile(Server.MapPath("LTe50342.ttf"));
            FontFamily family= new FontFamily("Avenir LT 45 Book",pfc);
            Font myFont=new Font(family,14,FontStyle.Bold, GraphicsUnit.Pixel);

            // Calculate the required width of the bitmap
            Bitmap tmpBitmap = new Bitmap(100,100,PixelFormat.Format32bppArgb);
            Graphics objGraphics = Graphics.FromImage(tmpBitmap);
            SizeF textSize=objGraphics.MeasureString(Text,myFont);
            textSize.Width+=5;
            // Clean up
            objGraphics.Dispose();
            tmpBitmap.Dispose();

            // Load background
            System.Drawing.Image imgBackground = System.Drawing.Image.FromFile(Server.MapPath(Background));

            // Create target image
            tmpBitmap = new Bitmap((int)textSize.Width,imgBackground.Height);
            objGraphics = Graphics.FromImage(tmpBitmap);

            // "paing" background
            Brush b = new TextureBrush(imgBackground,WrapMode.Tile);
            objGraphics.FillRectangle(b,0,0,(int)textSize.Width,imgBackground.Height);

            // Write text
            objGraphics.TextRenderingHint = TextRenderingHint.AntiAlias;
            objGraphics.TextContrast = 12;
            objGraphics.DrawString(Text, myFont, new SolidBrush(Over?TextColorOver:TextColor),0,(imgBackground.Height-textSize.Height)/2);

            MemoryStream io = new MemoryStream();
            tmpBitmap.Save(io, Format);
            Response.BinaryWrite( io.GetBuffer() );
            io.Close();

            // Clean up
            b.Dispose();
            pfc.Dispose();
            imgBackground.Dispose();

        }
        catch (Exception ex)
        {
            Utility.WriteLog(ex.Message);
        }
    }

b.Dispose();
pfc.Dispose();
imgBackground.Dispose();
objGraphics.Dispose();  // Thanks Guffa.

Cache[CacheKey] = tmpBitmap;    //Otherwise there's no point in using the cache really :doh:

Ben[dog] wrote:

Bitmap b = (Bitmap) Cache[CacheKey];

Christian Graus wrote:

The easy way to write code that makes clear that yo dispose of resources is a using block

Christian Graus wrote:

Guffa said he found two items that were not.

Ben[dog] wrote:

But if the individual Dispose() are explicitely called, that shouldn't really make a difference, should it?

MemoryStream io = new MemoryStream();
tmpBitmap.Save(io, Format);
Response.BinaryWrite(io.ToArray());
io.Close();