C / C++ / MFC

Michael P Butler19-Jun-02 1:56

Michael P Butler

19-Jun-02 1:56

SetItemData takes a pointer to the allocated memory, so that when you called delete the pointer was no longer valid.

You need to keep the pointer active until you've finished. You could just loop through all your items and delete the pointer returned from GetItemData before you destroy the control. Or like you suggest you could have a list which gets deleted later. I tend to keep a vector of pointers and then free up the memory in the destructor.

Michael Smile | :)

"Eureka" is Greek for "This bath is too hot"

Steve L.19-Jun-02 2:00

Steve L.

19-Jun-02 2:00

Thanks a lot Smile | :)

-Raffi

_Magnus_19-Jun-02 1:50

_Magnus_

19-Jun-02 1:50

Can you really do this?
<bold>CItemInfo *itemInfo = new CItemInfo*;
Should it not be
<bold>CItemInfo *itemInfo = new CItemInfo;

Otherwise you would allocate a new pointer.
...at least that's what i think.

/Magnus

lock-up catching excel events

Steve L.19-Jun-02 1:52

Steve L.

19-Jun-02 1:52

I had it correct in my code, just a mistake when writing the question.

-Raffi

Zizilamoroso18-Jun-02 23:56

Zizilamoroso

18-Jun-02 23:56

I'm controlling excel from another app: create sheets, set ranges, modify properties and so on.

Now, I've implemented an eventlistener like described as on the msdn-website, automation, creating our own IDispatch for catching events.

The strange thing is that it handles pretty well events like WINDOW_ACTIVATE, SHEET_CALCULATE, ... if those things are modified from the outside-application. BUT if we select a range or double click on the sheet, excel blocks. Our app doesn't block, but it doesn't receive anymore events. We still can close excel though.

Is this a common problem? Anybody solved it yet? Or where to look?

initialising:

CEventsDispatch g_XLEventDispatch;
IConnectionPoint *m_pConnectionPoint;
DWORD m_adviseCookie;


	static const GUID IID_IExcel8AppEvents = 
	{0x00024413,0x000,0x0000,{0xc0,0x00,0x0,0x00,0x00,0x00,0x00,0x46 } };

	HRESULT hr;

	IConnectionPointContainer *pConnPtContainer;
	hr = m_pXlApp->QueryInterface(IID_IConnectionPointContainer,(void **)&pConnPtContainer);
	if(hr!=0)
		return;
	hr = pConnPtContainer->FindConnectionPoint(IID_IExcel8AppEvents,&m_pConnectionPoint);
	if(hr!=0)
		return;
	hr = m_pConnectionPoint->Advise(&g_XLEventDispatch, &m_adviseCookie);
	if(hr!=0)
		return;
	pConnPtContainer->Release();

our idispatch:

class CEventsDispatch : public IDispatch
{
	public:
		ULONG refCount;

	CEventsDispatch::CEventsDispatch()
	{
		refCount=1;
	}

	CEventsDispatch::~CEventsDispatch()
	{
	}

	virtual HRESULT __stdcall QueryInterface(REFIID riid, void **ppvObject)
	{
		if(IsEqualGUID(riid, IID_IDispatch) || IsEqualGUID(riid, IID_IUnknown))
		{
			this->AddRef();
			*ppvObject = this;
			return S_OK;
		}
		
		*ppvObject = NULL;
		return E_NOINTERFACE;
	}

	virtual ULONG _stdcall AddRef(void) 
	{
		return ++refCount;
	}

	virtual ULONG _stdcall Release(void) 
	{
		if(--refCount <= 0)
		{
			//Delete this;
			return 0;
		}

		return refCount;
	}

	// IDispatch methods.
	virtual HRESULT _stdcall GetTypeInfoCount(UINT *pctinfo) 
	{
		if(pctinfo) *pctinfo = 0;
		return E_NOTIMPL;
	}

	virtual HRESULT _stdcall GetTypeInfo(UINT iTInfo, LCID lcid, ITypeInfo **ppTInfo) 
	{
		return E_NOTIMPL;
	}

	virtual HRESULT _stdcall GetIDsOfNames(REFIID riid, LPOLESTR *rgszNames, UINT cNames, LCID lcid,DISPID *rgDispId) 
	{
		return E_NOTIMPL;
	}

	virtual HRESULT _stdcall Invoke(DISPID dispIdMember, REFIID riid, LCID lcid, WORD wFlags,DISPPARAMS *pDispParams, VARIANT *pVarResult,EXCEPINFO *pExcepInfo, UINT *puArgErr) 
	{
		// do something with the event;
		return S_OK;
	}
};

[VISUAL STUDIO 6.0] [MFC] [WIN98/2]

Bluute tette! Dead | X|

Re: lock-up catching excel events

Zizilamoroso19-Jun-02 1:18

Zizilamoroso

19-Jun-02 1:18

After a few minutes, a messagebox comes up saying: "Microsoft excel is waiting for another application to complete an OLE action."

I've implemented everything I've found on the msdn example (automating excel using vc++), so they must have forgotten something?

[VISUAL STUDIO 6.0] [MFC] [WIN98/2]

Bluute tette! Dead | X|

MFC Automation embedded Ms Word window bring to top

Braulio Dez18-Jun-02 23:51

Braulio Dez

18-Jun-02 23:51

Hi,

I start an Embedded Ms Word instance from my application, all goes ok but the Ms Word window is shown in the bottom of the Z-Order, I would like to bring it top, how can I make that using the App, Doc and that Ms Word stuff ?

Thanks in advance, greetings
Braulio

VS7 and Icons

Dennis Alden18-Jun-02 23:51

Dennis Alden

18-Jun-02 23:51

I have just started "playing" around with VS.NET. I have created a new project - added an Icon resource. The 32x32 icon is displayed but could somebody please tell me how I create the 16x16 icon - the "Device" field in the properties is disabled and I cannot for the life of me work out where the 16x16 Device has gone or how to add it.

I am certain that it is right there under my nose and that a visit to the optician may be coming up - but i would sure appreciate theh loan of a white stick right now!

TIA

Re: VS7 and Icons

Dennis Alden19-Jun-02 0:14

Dennis Alden

19-Jun-02 0:14

Doh! - I found out how to do it - must learn to RTFM before making a complete fool of myself Blush | :O

memory leak

Rage18-Jun-02 23:34

18-Jun-02 23:34

After using the following command

_crtBreakAlloc = 1884;

(this was a tip given by Chris in a previous thread), I discovered that this piece of code causes a memory leak :

if(Map!=NULL) delete[] Map;
Map=NULL;
Map=new I_int[Cor_Node->Parents.Nb_Elems()];

Exact position is the Map=new ... line (of course).Cor_Node->Parents.Nb_Elems() is equl to 4.

Any idea about what happened ? Is there a better way to do this ?

~RaGE();

Prem Kumar18-Jun-02 23:41

18-Jun-02 23:41

hi,
It does not mean that the piece of code is causing the memory leak,
but rather that the memory allocated at this point has not been freed.

Also you should be careful abt tracking the leaks with this
method because the number only indicates that the n-th allocation is
leaked-->this may change if you change the sequence of the actions when
testing or debugging.

Rage18-Jun-02 23:45

18-Jun-02 23:45

Thanks for the help ...

Prem Kumar wrote:
this may change if you change the sequence of the actions when
testing or debugging.
Is that meaning I have to do exactly the same operations when Debbugging (press same buttons in same order in my app ?) ...

~RaGE();

Prem Kumar18-Jun-02 23:51

18-Jun-02 23:51

You got it! you have to have the same sequence.

Rage19-Jun-02 0:07

19-Jun-02 0:07

Well, OK. I have implemented Chris´ macros too (supposed to show info about the line where not freed memory is overwritten), but it did not change anything in the debug output, and i cannot spot where something wrong occurs ... Frown | :(

any idea how to do that ? (Problem is, i have to take over the bugged code from somebody else =/)

~RaGE();

Prem Kumar19-Jun-02 0:11

19-Jun-02 0:11

Hi,

Check your code that you are properly freeing up Map
at your app exit.

JohnnyG19-Jun-02 3:16

JohnnyG

19-Jun-02 3:16

I've tried all of the macros too and they didn't work. I finally did what was suggested, buy Bounds Checker, after wasting 8 hours trying to get VC++ to show me line number and filename of leak.

As an aside the 40+ leaks identified from the C++ runtime library (STL's list, vector and iostream calls) weren't really leaks. Turns out I just needed to link a library (MFC42D.LIB) in to get rid of those reported leaks.

Debug assertion failed

Rsh18-Jun-02 23:24

18-Jun-02 23:24

How do i release the memory after reading from the CList from the head position.If i run the folowing code i get Debug assertion failed at the delete statement.

void CPLayerApp::LockIt()
{
unsigned char data[10], mCnt,mMid;
CMessage* pMess;
CSingleLock singleLock(&m_SyncLock.m_mutex);

CString str="";
while(1)
{

if(m_messList.GetCount() != 0)
{
singleLock.Lock();
pMess = &m_messList.GetAt(m_messList.GetHeadPosition());//m_messList is a CList pointer

mCnt = pMess->m_cnt;
mMid = pMess->m_mid;
pMess->GetData(data);
POSITION pos = m_messList.GetHeadPosition();

m_messList.RemoveHead();
delete pos;
singleLock.Unlock();
if(data[0] == 0x10)
{
str.Format("%0x",data[0]);
AfxMessageBox(str);
break;
}
}
Sleep(200);

}

Rsh

Rage18-Jun-02 23:36

18-Jun-02 23:36

I do not see the point of your code Confused | :confused:

Why using a POSITION if you delete it two lines after ?

~RaGE();

Prem Kumar18-Jun-02 23:45

18-Jun-02 23:45

Actually the statement of 'delete pos' doesnt make sense !!
pos is just a stack variable and its value is not necessarily
a pointer.

Rsh19-Jun-02 0:00

19-Jun-02 0:00

Ok. If POSITION and pos r not required can u pls. suggest how to release the memory associated with the element in the CList after you read that? Cause RemoveHead()is not doing that.

Rsh

Prem Kumar19-Jun-02 0:06

19-Jun-02 0:06

how abt 'delete pMess' ???

Rsh19-Jun-02 0:16

19-Jun-02 0:16

No Prem,
even that doesn't work.Just now i tried with that also. Its giving the same error.

Rsh

Rage19-Jun-02 2:09

19-Jun-02 2:09

As far as I know (but I may be wrong) if you delete an Item with RemoveHead(), itreturns a pointer on the deleted item. So let´s use this to delete the already-deleted-in-the-list Item ... no ?

~RaGE();

Chad Koehler19-Jun-02 7:28

Chad Koehler

19-Jun-02 7:28

Are you just trying to iterate through the list? If so, there are easier ways, I will elaborate if needed.

Otherwise, just remove the line that says 'delete pos;'. As was stated this is a variable declared on the stack. Trying to delete it will cause debug assertion errors. (Worse yet in release mode)

Rsh19-Jun-02 21:37