|
Personally I don't find that to be horrible. It's completely correct and only slightly more redundant. It really makes no difference in practice.
And no I'm not trying to defend my usage of it I don't lie
|
|
|
|
|
I agree it's not horrible and that it can add to readability but it is still one comparison too many.
It might get more obvious in different situation.
Like (some stupid example):
<br />
<br />
bool IsNumberEven(int number)<br />
{<br />
return ((number % 2 == 0) ? true : false);<br />
}<br />
<br />
int Main()<br />
{<br />
int someNumber = 2^100;<br />
<br />
for (int i = 0; i < 100; i++)<br />
{<br />
while (IsNumberEven(someNumber) == true)<br />
{<br />
someNumber /= 2;<br />
}<br />
}<br />
}<br />
I think it is similar as using String object when one should use StringBuilder. It's OK for small number of iterations or single comparison, but can be time-consuming for large number of iterations.
modified 19-Nov-18 21:01pm.
|
|
|
|
|
I've always assumed that if(aBool) is simply a short-hand for if(aBool == true), and they should be completely equivalent to the compiler. If they are not for some reason, it would be a trivially easy optimization for the compiler to make.
|
|
|
|
|
I don't know if that is true. Maybe someone with deeper knowledge than me could answer that. If it is true though, I should 'recompile' my coding practices
modified 19-Nov-18 21:01pm.
|
|
|
|
|
I ran some tests for speed for both cases and the results show that your assumption is correct. It seems compiler is smarter than I thought So this case is closed and I learned something new to me and that is always a good thing
modified 19-Nov-18 21:01pm.
|
|
|
|
|
You ran a test for speed???
I put it in an app:
bool IsNumberEven(int number)
{
return ((number % 2 == 0) ? true : false);
}
private void Form1_Load(object sender, EventArgs e)
{
if (IsNumberEven(2))
{
}
if (IsNumberEven(2) == true) { }
}
checked with ildasm, and they both turn into exactly the same IL code.
.maxstack 2
.locals init ([0] bool CS$4$0000)
IL_0000: nop
IL_0001: ldarg.0
IL_0002: ldc.i4.2
IL_0003: call instance bool csharpWindowsApp.Form1::IsNumberEven(int32)
IL_0008: ldc.i4.0
IL_0009: ceq
IL_000b: stloc.0
IL_000c: ldloc.0
IL_000d: brtrue.s IL_0011
IL_000f: nop
IL_0010: nop
IL_0011: ldarg.0
IL_0012: ldc.i4.2
IL_0013: call instance bool csharpWindowsApp.Form1::IsNumberEven(int32)
IL_0018: ldc.i4.0
IL_0019: ceq
IL_001b: stloc.0
IL_001c: ldloc.0
IL_001d: brtrue.s IL_0021
IL_001f: nop
IL_0020: nop
IL_0021: ret
|
|
|
|
|
Testing if the number is even with modulus is the real horror .. :P
|
|
|
|
|
Actually the real horror would be:
<br />
bool IsEven(int someNumber)<br />
{<br />
if (someNumber == 2 || someNumber == 4 || someNumber == 6 ||
{<br />
return true;<br />
}<br />
else<br />
{<br />
return false;<br />
}<br />
}<br />
modified 19-Nov-18 21:01pm.
|
|
|
|
|
A rumour has it that it always can be worse
|
|
|
|
|
This might be even better. After all, it's the way I do it in my head.
bool IsNumberEven(int number) {
string sNumber = number.ToString();
string sLastDigit = sNumber[sNumber.Length - 1];
if(sLastDigit == '0' || sLastDigit == '2' || sLastDigit == '4' || sLastDigit == '6' || sLastDigit == '8' ) {
return true;
}
else {
return false;
}
}
|
|
|
|
|
It's ok e.g. in C#, but in C/C++ this habit can lead to nasty bugs.
If you work with multiple libraries, you probably have to deal with bool, BOOL and VARIANT_BOOL . While bool is fine (unless abused in the assignment), BOOL is usually used as "any nonnegative value is true", and the respective TRUE constant is defined sometimes as 1, sometimes a (!FALSE) which would expand to -1. VARIANT_BOOL explicitely defines -1 as VARIANT_TRUE.
I know that some people prefer
if (someridiculouslylongexpression==false)
over
if (!someridiculouslylongexpression)
since the not can get lost quickly for the quick reader. However, I discourage this habit, as it may fail with the "fak" boolean types.
|
|
|
|
|
dighn wrote: slightly more redundant
It is a way bit explicit right? Do you mean to say it affects any of the coding guidelines? C# actually advocates and prefers explicit typecasting too. And similarly an explicit mention should be a welcome though a bit strange. What do you way?
|
|
|
|
|
Actually I do not know why that was even posted, there was absolutely nothing wrong with that code.
Now if there was something in the “do something…” sections, that showed a problem – then it might have made since as a problem – otherwise it is great and legitimate code.
Tinko101 – can just ignore my comment, because I have only been writing code for about 19 years or so, but I agree with you.
INTP
"Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
|
|
|
|
|
The only thing I can see wrong is that the boolean value isn't initialized. Now that is ban practice as in C/C++ values only get a default value in Debug mode. In Release mode it could be anything
|
|
|
|
|
I assumed the posted code was just missing an elipsis. Presumably there was something to set the Boolean value.
|
|
|
|
|
Tell the compiler that
|
|
|
|
|
mmm...not sure !
I already see worse !
You write a first test
if (boolValue == true)
during debugging, it appaers that you have to change the test
if (boolValue != true)
after a second debug you wish to change it again
if (boolValue != false)
As summary, do you think that this code is really readable, even the performance is the same... :
<big>if (boolValue != !false)
|
|
|
|
|
It makes no difference, just like
if (((true == myFlagVariable) == true) != false)
is in fact equivalent to
if (myFlagVariable)
It's just that one version shows that the programmer understands that a boolean variable is in fact a boolean expression. So while it doesn't do much damage, it does show a lack of understanding -- excepting the occasional brainfart, which can surely happen to anyone.
I've also noted the habit of C programmers to write
if (null == var) ...
which to me just doesn't read naturally! I realise that they do this to avoid an unintensional assignment - a common and often subtle bug in C code:
if (var = null) ...
But in C# an assignment statement is not legal in an if condition, so it is a pointless practice. But I won't deny that habits are powerful and it may not be so easy for an old dog (C programmer) to change his ways. (I wish it was "her" ways more often, but for some reason girls are few and far between in our community.)
|
|
|
|
|
I'll rush to correct myself...
"an assignment statement is not legal in an if condition"
isn't strictly true. What is true is that an if condition in C# requires a boolean expression. For the present purpose it doesn't greatly matter, since the accidental assignment cannot happen in C#, but in general, an assignment can indeed be part of the boolean expression, even if there is little reason to make our code harder to read in this way.
if ((list.Capacity = count) > 1024) { ... }
This is perfectly legal, but not as readable as
list.Capacity = count;
if (count > 1024) { ... }
which is equivalent (i.e. both versions produce the same IL code).
|
|
|
|
|
that's the classic "the Product guys won't make up their minds, so i'll do it both ways" design pattern.
|
|
|
|
|
While I don't write boolValue == true, I do write boolValue == false since it stands out more then !boolValue.
I can imagine the sinking feeling one would have after ordering my book,
only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
|
|
|
|
|
It stands out more?? How clear do you need it to be?
IMO, (b == true) "stands out" more than (b), so if this was a guiding principle we ought to write it all the time.
Perhaps we should also write
int i, count, n;
...
i = i.Add(count.Multiply(n));
instead of
i += count * n;
Admittedly the last example is a stretch. And the issue is surely quite academical - there are a few other bad coding habits I can think of, and methodology (or lack thereof), and much else, that matters rather a lot more in the end. But for the sake of academic nitpicking (which I think is rather fun) I'd still say "less is usually better". The only exception is when less code makes something obscure or unreadable. In my judgement (!b) clearly does NOT qualify; it is as clear as it can be.
|
|
|
|
|
I'm going to be pedantic here and state that the do something condition will never be executed in this example. BTW - to answer your question, the compiler recognises that if (a == true) is functionally equivalent to if (a) because it is clever enough to know that all parts of the if condition must be boolean conditions.
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
In some languages TRUE is actually an int, mostly 1. But BASIC languages (VB for one), define TRUE as NOT FALSE (where not is the 2's complement), so TRUE is actually -1. If you are interacting with different languages, you have to take this into account -- for example, a Windows API return value in Visual Basic.
|
|
|
|
|
Not with C# compiler right? The compiler 'barks' and strongly recommends an explicit casting. Isn't it?
|
|
|
|