C / C++ / MFC

Mark Salsbery wrote:

You haven't initialized the array that's being copied to the CString.

Class a
{
  void SetPath(CString strPath)
  {
    memset(m_pA->pSzPath, NULL, MAX_PATH);

    int len = min(MAX_PATH, strPath.GetLength());
    strncpy(m_pA->pSzPath, strPath, len);  // Path to folder
    m_pA->bPathUpdated = TRUE;  // a volatile BOOL
  }

  static UINT ThumbnailViewerThread(LPVOID pParam)
  {
    CString strFullPath, strFileName, strFolderPath;
    // blah blah
    
    while(!pData->bStop)
    {
      if (pClientData->bPathUpdated)
      {

        // Find file name by enumerating the folder

        // Replace the following 2 lines, every thing's fine! no need to Empty()

        // strFolderPath = _T("C:\\Images");
        strFolderPath = pClientData->pSzPath; // Folder path

        strFullPath = strFolderPath + "\\" + strFileName;
        // Blah blah

        // Memory leak, if I comment the following
        strFolderPath.Empty();
      }
      else
      {
         sleep(500);
      }
    }    
  }
}

Hamed Mosavi wrote:

void SetPath(CString strPath)
{
memset(m_pA->pSzPath, NULL, MAX_PATH);

int len = min(MAX_PATH, strPath.GetLength());
strncpy(m_pA->pSzPath, strPath, len); // Path to folder
m_pA->bPathUpdated = TRUE; // a volatile BOOL
}

void SetPath(CString strPath)
  {
    memset(m_pA->pSzPath, 0, MAX_PATH);

    int len = min(MAX_PATH<font color="Red"> - 1</font>, strPath.GetLength());
    strncpy(m_pA->pSzPath, strPath, len);  // Path to folder
<font color="Red"><font><font>    m_pA->pSzPath</font></font>[len] = 0;</font>
<font>    m_pA->bPathUpdated = TRUE;  // a volatile BOOL
  }</font>

Mark Salsbery
Microsoft MVP - Visual C++

Mark Salsbery wrote:

(MAX_PATH - 1,

m_pA->pSzPath[len] = 0;

memset(m_pA->pSzPath, 0, MAX_PATH);

Mark Salsbery wrote:

You shouldn't need the empty call

Mark Salsbery wrote:

the destructor isn't getting called.

Is your thread shutdown all the way before the app exits?

gizmokaka wrote:

That is of course after I'm allocation memory for the colName array, and each of it's members.

char **myArray = malloc(sizeof(char *) * 10);
int i;
 
for(i = 0; i < 10; i++)
{
    myArray[i] = malloc(sizeof(char) * 15);
}

if( data.colName ) /* colName != NULL */
{
    int i;
    for( i=0; i < data.NameCount; ++i )
    {
        if( data.colName[i] ) /* data.colName[i] != NULL */
        {
            free(data.colName[i]);
            data.colName[i] = NULL;
        }
    }
    free(data.colName);
    data.colName = NULL;
}

//t = a pointer to table_rec
//local_data = pointer to data 
for(i = 0 ; i < width ; i++)
{
    free(t->local_data->colName[i]);
}
free(t->local_data_colName);

assert(t != NULL);
assert(t->local_data != NULL);
assert(t->locat_data->colName != NULL);
 
for(i = 0 ; i < width ; i++)
{
    assert(t->local_data->colName[i] != NULL);
     
    free(t->local_data->colName[i]);
}
 
free(t->local_data_colName);

#include <stdio.h>
#include <string.h>
#include <malloc.h>


void main ()
{
	int num = 2;
	char** str_array;
	char str1[] = "first string";
	char str2[] = "second string";

	str_array  = (char**)malloc(sizeof(char*)*num);
	str_array[0] = (char*)malloc(sizeof(char)*strlen(str1));
	str_array[1] = (char*)malloc(sizeof(char)*strlen(str2));
	strcpy (str_array[0],str1);
	strcpy (str_array[1],str2);
	
	printf("%s \n",str_array[0]);
	printf("%s \n",str_array[1]);

	free(str_array[0]);//error ocurres
	free(str_array[1]);
	free(str_array);


}