|
in the controller class? something like this?
<code></code>
class Controller
{
private:
string filename; //Store filename.
int Menu; //Store Menu.
public:
void setFilename(const char *s); //Method to set filename.
string getFilename(void); //Method to get filename.
int getmenu(int choice); //Method to get menu.
void setmenu(const int m); //Method to set menu.
Controller(); //Default constructor.
};
#endif
<code></code>
|
|
|
|
|
Controller.cpp file
<code></code>
#include "Controller.h"
Controller::Controller()
{
Menu = 0;
}
int Controller::getmenu(int choice)
{
return Menu;
}
void Controller::setmenu(const int m)
{
Menu = m;
}
string Controller::getFilename()
{
return filename;
}
void Controller::setFilename(const char *s)
{
filename = s;
}
<code></code>
|
|
|
|
|
Main.cpp
<code></code>
#include <iostream>
#include "Controller.h" //include controller header file
using namespace std;
int main()
{
int choice; //To hold screen to display message, until menu class is added.
int menu = 0;
const char *word = "Hangman";
Controller controller;
Controller display;
display.setmenu(menu); //Method to set the menu.
display.getmenu(menu); //Method to get the menu.
controller.setFilename(word); //Set filename to Hangman.
cout << "Coming soon - " << controller.getFilename() << endl; //Display temporary message.
cout << "To be continued......" << endl;
cout << endl;
cout << "Please click X in top right corner to exit." << endl;
cin >> choice; //Hold screen to display message.
return 0;
}
<code></code>
|
|
|
|
|
Thank you for posting your course assignment. We enjoy keeping abreast of the current CIS curriculum.
led mike
|
|
|
|
|
I am catching an exception that is thrown when a char* is assigned to a CString. {The line - m_strResponse += CString(_T(pszOutBuffer));} I can print the char * pszOutBuffer to the screen, and it looks fine. Any ideas on how to get past this or how to further debug? The exception is caught in the second catch (...), and GetLastError() returns 0.
Thanks.
Code segments
from .h file:
public CString m_strResponse;
from .c file:
BOOL CMessage::HandleResponse(HINTERNET hRequest)<br />
{ <br />
CString strError = "";<br />
DWORD dwSize, dwDownloaded;<br />
char *pszOutBuffer;<br />
<br />
try<br />
{<br />
TRY<br />
{<br />
do <br />
{<br />
dwSize = 0;<br />
if (!WinHttpQueryDataAvailable( hRequest, &dwSize))<br />
{<br />
strError.Format("Error %u in WinHttpQueryDataAvailable.",GetLastError() );<br />
RecordError( strError, NULL ,"", "" );<br />
}<br />
<br />
pszOutBuffer = new char[dwSize+1];<br />
<br />
if (!pszOutBuffer)<br />
{<br />
strError.Format("Error allocating buffer for HandleResponse()\n");<br />
RecordError( strError, NULL ,"", "" );<br />
return false;<br />
}<br />
else<br />
{<br />
ZeroMemory(pszOutBuffer, dwSize+1);<br />
<br />
if (!WinHttpReadData( hRequest, (LPVOID)pszOutBuffer, dwSize, &dwDownloaded))<br />
{<br />
strError.Format ("Error %u in WinHttpReadData.", GetLastError() );<br />
RecordError( strError, NULL ,"", "" );<br />
}<br />
else<br />
{<br />
strError.Format("Try 1 - outbuffer:%s, downloaded%u", pszOutBuffer, dwDownloaded);<br />
AfxMessageBox(strError);<br />
<br />
pszOutBuffer[dwSize] = '\0';<br />
m_strResponse += CString(_T(pszOutBuffer));<br />
<br />
strError.Format("response:%s", m_strResponse);<br />
AfxMessageBox( strError ) ;<br />
}<br />
<br />
delete [] pszOutBuffer;<br />
pszOutBuffer = NULL;<br />
<br />
}<br />
<br />
} while (dwSize>0);<br />
<br />
<br />
CDBAccess::Instance()->RecordTransaction( m_strXMLMessage, m_strResponse);<br />
<br />
}<br />
CATCH_ALL(pEx)<br />
{<br />
RecordError( "Error occured while processing HTTP response", NULL ,"", (pEx->ReportError()) );<br />
<br />
if( pszOutBuffer != NULL )<br />
delete[] pszOutBuffer;<br />
<br />
return false;<br />
}<br />
END_CATCH_ALL <br />
<br />
}<br />
<br />
catch (...)<br />
{<br />
strError.Format ("Caught GetLastError: %u.",GetLastError());
AfxMessageBox(strError);<br />
return false;<br />
}<br />
<br />
return true;<br />
}
|
|
|
|
|
holly.sherman wrote: m_strResponse += CString(_T(pszOutBuffer));
I can't readily see the cause of the exception, but using _T() in that fashion is incorrect.
You're reading data synchronously, right?
Mark
Mark Salsbery
Microsoft MVP - Visual C++
![Java | [Coffee]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/coffee.gif)
|
|
|
|
|
Mark Salsbery wrote: but using _T() in that fashion is incorrect.
I can't believe you got that far, I stopped looking after seeing this bowl of worms:
try<br />
{<br />
TRY<br />
{<br />
do <br />
{
led mike
|
|
|
|
|
Come on, Mike, it's the old adage, "If at first you don't succeed, try and try again." 
"Normal is getting dressed in clothes that you buy for work and driving through traffic in a car that you are still paying for, in order to get to the job you need to pay for the clothes and the car and the house you leave vacant all day so you can afford to live in it." - Ellen Goodman
"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne
|
|
|
|
|
LMAO
It must be the Texas version: "try and try and do, can't be fooled again".
led mike
|
|
|
|
|
You should post that code to the Coding Horrors one.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
|
|
|
|
|
 ROTFL. I am just wondering why people like Mark, David, etc., are making fun of the OP. Crazy guys. Your reply is the only one which makes sense. 5 for that.
Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->Rajesh<-·´¯`·.
Codeproject.com: Visual C++ MVP
|
|
|
|
|
I get the same results when I remove _T().
Yes, I'm reading data synchronously.
I tried writing to the CString character by character too, but it threw the exception at the first character.
for(nTestIndex = 0; nTestIndex <= dwSize; nTestIndex++)
{
m_strResponse += pszOutBuffer[nTestIndex];
}
|
|
|
|
|
m_strResponse should really be a CStringA, not a CString.
Then, maybe try stepping into the CStringA += operator code to see why an exception
is being thrown.
Mark
Mark Salsbery
Microsoft MVP - Visual C++
|
|
|
|
|
Why CStringA? MSDN doc says CString does both ANSI and Unicode, while CStringA does just ANSI. Why would that make a difference?
Stepping through code not exactly an option... Long story, but this is old code (5 yrs) that mysteriously broke at that point when I made a change to the request xml. In other words, this code worked before, but doesn't anymore. I suppose I could write a small test for that one line, but http connection won't work from my testing environment.
|
|
|
|
|
habs wrote: Why CStringA?
To match your incoming data. If the data is coming in Unicode, then use CStringW.
Any other case requires potential conversion of the data, depending on your build configuration.
Is the debugger no help? There's not all that many reasons the CString += operator
should fail.
Mark
Mark Salsbery
Microsoft MVP - Visual C++
|
|
|
|
|
The following test code works without any issues:
int main(int argc, char* argv[])<br />
{<br />
char * pszOutBuffer;<br />
pszOutBuffer = "test";<br />
CString m_strResponse;<br />
m_strResponse += CString(pszOutBuffer);<br />
<br />
<br />
printf(m_strResponse);<br />
<br />
<br />
return 0;<br />
}
I added all this header info from the original program:
#include <afxwin.h>
#include <afxext.h>
<br />
#ifndef _AFX_NO_OLE_SUPPORT<br />
#include <afxole.h>
#include <afxodlgs.h>
#include <afxdisp.h>
#endif // _AFX_NO_OLE_SUPPORT<br />
<br />
<br />
#ifndef _AFX_NO_DB_SUPPORT<br />
#include <afxdb.h>
#endif // _AFX_NO_DB_SUPPORT<br />
<br />
#ifndef _AFX_NO_DAO_SUPPORT<br />
#include <afxdao.h>
#endif // _AFX_NO_DAO_SUPPORT<br />
<br />
#include <afxdtctl.h>
#ifndef _AFX_NO_AFXCMN_SUPPORT<br />
#include <afxcmn.h>
#endif // _AFX_NO_AFXCMN_SUPPORT<br />
<br />
#pragma warning ( push )<br />
#pragma warning ( disable : 4786 )<br />
#include <map><br />
#include <string><br />
#include <strstream><br />
#include <fstream><br />
<br />
std::ostream& operator<< ( std::ostream& os, CString& cs );
I'm having trouble switching this to CStringA... Did I mention this is Visual Studio 6.0?
|
|
|
|
|
Almost always, if you use a catch-all you should re-throw the exception again.
Steve
|
|
|
|
|
I'm assuming that none of you know the answer or have anything helpful to say since you have resorted to making fun of this code... (apologies to Mark, who at least seems to be trying)
I added the extra try{}catch(...){} because the macro didn't catch the exception, and I didn't know if just adding catch at the end of the macro would work. I also tried adding catch(CException &e), but that didn't catch anything. I don't know to get to the exception that is caught in the (...), and GetLastError() only returns 0. I have pulled the assignment code out and put it in a separate program (see above), and it works fine.
This lovely little segment of code even worked before, but doesn't work anymore (yay, maintenance).
So anyways, unless you know how to tell me how to get at the exeception, or how to debug, or how to fix... bug off.
modified on Thursday, March 27, 2008 10:04 AM
|
|
|
|
|
habs wrote: I'm assuming that none of you know the answer or have anything helpful to say since you have resorted to making fun of this code
Speaking only for myself here. Since I am not being paid to analyze that monkey crap you posted I didn't even try to "know the answer". My answer ( and based on the history around here I choose not to post) would be, if I had to maintain that monkey crap, to select the entire thing and press the delete key. Then develop a reasonable solution from scratch.
led mike
|
|
|
|
|
You haven't provided enough evidence that the diagnosis of the problem is correct.
You might try to:
- replace the TRY-CATCH_ALL macros
- use a try-catch on the "Read the Data" block rather than the whole function
- properly handle the case of WinHttpQueryDataAvailable failure.
- verify that m_strResponse is valid before you attempt to concatinate to it.
It may have "worked" before; I would add "by the grace of God." The code is flawed.
|
|
|
|
|
Thanks for some suggestions. I'm not certain how to implement all of them.
Member 754960 wrote: - properly handle the case of WinHttpQueryDataAvailable failure.
Are you talking about missing a return false; ? I can add that in, but I actually get a response, dwSize 753, so I don't think that's the problem.
Member 754960 wrote: - verify that m_strResponse is valid before you attempt to concatinate to it.
How would I validate m_strResponse?
|
|
|
|
|
AFAICS, on WinHttpQueryDataAvailable failure dwSize is undefined; it may be 0; it may be junk. You haven't indicated if that call failed or not. In that case, it is not clear what awful behavior happens if you then call WinHttpReadData. Why waste time chasing phantom cases? Just remove the bogus pathway.
Unless you are using the debugger to examine dwSize, I don't see it being output anywhere. I have to wonder what the difference is between dwSize and dwDownloaded. What is supposed to happen when they are different?
The symptom you report is that an often used operation of a common type generates an exception. The object is a class member that is neither initialized or reset in the function that generates the exception. You might want to examine how this object is used before the call to the function. Is it being locked? Is there a call to GetBuffer/ReleaseBuffer? etc.
You should be able to trace into the CString class and determine the exact cause of the exeption.
|
|
|
|
|
hmmmn
There is this line of code called several lines above:
if ( WinHttpWriteData( hRequest, (void*)m_strXMLMessage.GetBuffer(0), m_strXMLMessage.GetLength (), &dwBytesWritten) )
and no corresponding ReleaseBuffer.
Looking into that...
man, I'm getting cross-eyed. that was m_strXMLMessage and not m_strResponse, which doesn't have a GetBuffer call. 
modified on Thursday, March 27, 2008 5:27 PM
|
|
|
|
|
Hi, here's my problem:
I have a pointer to a struct (in C++, using VC++ .NET 2005 with MFC). The struct has been allocated from heap memory and contains many fields that are also allocated from the heap (character arrays, etc).
How can I copy this straight to another struct?
These are the two things I've tried, neither have worked:
This is where oldData is a pointer to a MyStruct that has been allocated from the heap:
struct MyStruct *newData = new MyStruct;<br />
memcpy(newData, oldData, sizeof(struct MyStruct));<br />
memcpy(oldData, newData, sizeof(struct MyStruct));<br />
delete newData;
And:
struct MyStruct newData;<br />
newData = *oldData;<br />
oldData = &newData;
Neither of these methods work. Is there a way to do this or do I have to copy field by field with the proper memory allocations in newData etc?
Thanks!
KR
|
|
|
|
|
It seems like it works if I copy all of the character arrays and heap allocated data separately and then do a memcpy on all the rest. Let me know if anyone knows a better way, please!
Thanks!
KR
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
