|
Stephen Hewitt wrote: Finally, your technique will not work. LoadResource returns nothing that LoadString can consume.
Hi Stephen,
You may be correct. I was thinking that you could just do something like this:
HRSRC hres = FindResource(NULL, MAKEINTRESOURCE(IDS_SOMESTRING), RT_STRING);
DWORD dwSizeRes = SizeofResource(NULL,hres);
char *p = NULL;
int result = LoadString((HINSTANCE)&__ImageBase,AFX_IDS_APP_TITLE,p,0);
std::string s(p,dwSizeRes);
Which is not much different than what you posted.
With the method that you posted...I am thinking that the std::string would need a NULL terminator in the string resource. I admit that I have not tried either method (including the one I just typed above). I will test both methods later when I get some free time.
Best Wishes,
-David Delaune
|
|
|
|
|
Hey Steve
I just spent 30 minutes testing both of our code samples. I could not get the code you wrote working for std::string probably because the resource strings are actually stored in Unicode within the PE files. However for wstrings your code is absolutely perfect. I suspect... that the brilliant code you posted could be actually be modified to utilize wcstombs and work for both ANSI and Unicode builds.
As for my code sample... I had even less success although I was eventually able to get it working. I had to re-read some of the MSDN docs and ended up using FindResourceEx with the language identifier. To make things worse the address I was recieving was the start of the string resource block. I had to load the string block into an HGLOBAL and walk the string table before I could even read the string.
Anyway I just wanted to let you know that you were correct.
Best Wishes,
-David Delaune
|
|
|
|
|
|
I didn't give you a 1 vote but the method I outlined will work for strings greater than 4096 characters, it just won't load the whole string. If you're really worried about that you have to use the OS/2 vintage "try it once to fail, once to succeed" method of sizing buffers.
And it'd be fairly easy to change Stephen's method to work for std::string - depending on how much you know about the resource and the characters in it it's either trivial (use the two iterator string constructor) or slightly harder (use wcstombs).
Ash
|
|
|
|
|
Load it into a character array first then assign the result to the std::string.
std::string load_string_from_resource( HINSTANCE app_instance, unsigned string_ID )
{
char buffer[ 4096 ];
unsigned bytes_copied = LoadString( app_instance, string_ID, buffer, sizeof( buffer ) );
if( !bytes_copied )
throw std::runtime_error( "Resource not found!" );
return std::string( buffer, bytes_copied );
}
(Code not tested, Errors and Omissions Excluded)
Cheers,
Ash
|
|
|
|
|
If you're using Unicode it can be done more efficiently than that:
std::wstring LoadString(HINSTANCE hInstance, UINT uID)
{
LPCWSTR pString;
int res = LoadStringW(hInstance, uID, (LPWSTR)(&pString), 0);
if (res == 0)
return std::wstring();
return std::wstring(pString, res);
}
MSDN on LoadString[^]:
If this parameter is 0, then lpBuffer receives a read-only pointer to the resource itself.
NOTE: Raw string resources are not NULL terminated.
Steve
|
|
|
|
|
Cool, I'd either forgotten about or never known the behaviour of LoadString when you pass zero as the buffer size.
What's the reason this wouldn't work on ANSI as well?
|
|
|
|
|
I'm not positive, but it doesn't seem to. Note that the documentation says it returns a pointer to the raw resource and string resources are always Unicode, so perhaps this is a reason. In fact, in the ANSI case 0xFFFFffff was returned to indicate an error (when 0 is passed as the buffer size), which isn't mentioned in the documentation.
Steve
|
|
|
|
|
Thanks for that, I'll stick that on the list as the first new thing I've learnt today.
Ash
|
|
|
|
|
|
Very nice and useful..Thanx
|
|
|
|
|
gmallax wrote: Very nice and useful
Then please upvote. Thanks, AR
When the wise (person) points at the moon the fool looks at the finger (Chinese proverb)
|
|
|
|
|
hi,
here we declare char buffer as char buffer[ 1024 ] = { '\0' }..
How to release this?
|
|
|
|
|
It is released at the next }
ReturnType SomeClass::SomeFunction(SomeParams)
{
char buffer[1024] = {0};
return ReturnType::SomeValue;
} cheers,
AR
When the wise (person) points at the moon the fool looks at the finger (Chinese proverb)
|
|
|
|
|
Hi..
can u please help me to solve this error... i'm getting the following error
"fatal error C1001: INTERNAL COMPILER ERROR
(compiler file 'msc1.cpp', line 1786) "
I'm using vc6.0 and in my project settings options - there are no such options like /Og , /Oa .. but still i'm getting the error.
can anyone suggest me some solution asap..
Thanks in advance...
Archana
|
|
|
|
|
I had a few of those. I think I rearranged some of the code to get it to work. But it was a long time ago. Use #error directive at the top of your source file that fails, move it downwards and see where it breaks. Then, try rearranging your code at that point.
|
|
|
|
|
try rebuild/clean the solution once before running
|
|
|
|
|
I have a vc++ application that has been showing odd characters on Japanese Windows installations.
It shows up an japanese katakana letter O (U + 30AA) instead of the micron character µ (mu)
i am using
sprintf(Buf, "%d µV", Values[i]);
My very simple task is to embed or force the "µ" symbol to remain as-is despite language settings.
Surely there is an easy method that I am missing somewhere!? Does anyone know an answer?
Much appreciation for any help.
|
|
|
|
|
Don't use ANSI strings, use UNICODE strings, ANSI strings will use the local Codepage for character conversions wich causes your problem.
|
|
|
|
|
Hi,
What windows message will be send to the application while closing the applcation[End Process] via task manager?
Thanks,
|
|
|
|
|
If you use the "End Task" button from the "Applications" tab the WM_CLOSE message is used. If you use the "End Process" button from the "Processes" tab it's closed forcefully and receives no notification.
Steve
|
|
|
|
|
For "End Task", system sends WM_CLOSE to the app window and wait for a specified time. After the time out if the window is not closed, "Application not responding" message will be shown, and the app is closed forcefully , if you select "End Now".
|
|
|
|
|
Hi,
I have to work on a project developed in Visual C++ 6 and it need to migrate to Visual Studio 2008.
Can anyone suggest me below things:
- What things one should take care?
- Is there any procedure to do that?
Please provide me as much as information you can provide.
Thanks,
Sachin
|
|
|
|
|
Hi,
Microsoft releases a list of what they call 'Breaking Changes' each time they release a new compiler.
Breaking Changes in Visual C++ .NET 2003[^]
Breaking Changes in the Visual C++ 2005 Compiler[^]
Breaking Changes in Visual C++ 2008[^]
Breaking Changes in Visual C++ 2010[^]
When I am upgrading legacy VC6 applications... I would say that one of the most common problems that I find is within the STL. For example VC6 iterators could be compared to NULL which was non-compliant with the standards. You will now need to compare it to the container.end()
Hmmm I guess another issue I see alot is the forced conformance in for-loop scope. It seems alot of VC6 C++ software engineers would re-use variables outside of the loop scope. You can disable the conformance but I usually take the time to fix it.
Another common issue that I find within MFC projects... is that some of the MFC message handler function signatures have been changed from UINT to LRESULT.
Thats all I can really think of at the moment...
Best Wishes,
-David Delaune
|
|
|
|
|
Hello every body !
Now I add some messages in the MainFrame:
1、#define WM_MSG_UPLOAD WM_USER+101
2、afx_msg LRESULT OnUploadMsg(WPARAM wParam,LPARAM lParam);
3、ON_MESSAGE(WM_MSG_UPLOAD,OnUploadMsg)
4、At last, I pose a MessageBox in the "OnUploadMsg" function.
In the Dll:
void MainMsg()
{
AfxGetMainWnd()->PostMessage(WM_CLOSE, 0, 0);
}
But in the debug mode, AfxGetMainWnd() also is NULL. how can I send the message from the dll space to the MainFrame?
thanks for your reply !
|
|
|
|