C / C++ / MFC

HENDRIK R27-Jan-03 4:39

27-Jan-03 4:39

How about calling your Create() in in the view's OnCreate() ?

Haakon S.27-Jan-03 4:54

Haakon S.

27-Jan-03 4:54

I tried OnCreate(), and it didn't work. But mind you, it may have failed not because of the buttons Create() functions, but because of the next piece of code, LoadBitmap(). I got an ASSERT because hWnd==NULL. It is a general problem that I want to do a lot of initialisation after the view is created, but before it is visible. And I want to do it once.

Haakon S.

Joggers live two years longer. But those two years they spend jogging.

HENDRIK R27-Jan-03 5:00

27-Jan-03 5:00

As long as your window isn't created hWnd is NULL. Thus you should first call the base class' OnCreate(). When finished, your windows hWnd should contain a valid handle - if not, I'm not certain what to do Wink | ;)

Haakon S.27-Jan-03 6:06

Haakon S.

27-Jan-03 6:06

I've checked it again, and yes, maybe you are pointing in the right direction Big Grin | :-D

. But I'm not home free Frown | :(

I've got some CStatic members in the resource template (my view is CFormView), identified as IDC_TOP and IDC_BOTTOM. They are subclassed into CStatic derivatives for color and blinking:

m_stTop.SubclassDlgItem(IDC_TOP, this);
m_stBottom.SubclassDlgItem(IDC_BOTTOM, this);

This works fine in OnInitialUpdate(), but not in OnCreate() Confused | :confused:

. Next time OnInitialUpdate() comes back, I've got an error.

Joggers live two years longer. But those two years they spend jogging.

crash on exit in release version with PostMessage!!!!! Help!!!

PJ Arends27-Jan-03 6:57

PJ Arends

27-Jan-03 6:57

Here's a hack:

add a member variable to your view class

BOOL m_bOnInitialUpdateRan;

Set it to false in your view's constructor

m_bOnInitialUpdateRan = FALSE;

and then in OnInitialUpdate only create your controls if it is FALSE. Be sure to set it to TRUE afterwards.

if (!m_bOnInitialUpdateRan)
{
    // Create controls here
    m_bOnInitialUpdateRan = TRUE;
}

Note: This is not tested, so give it a try. May work, may not Confused | :confused:

CPUA 0x5041

Sonork 100.11743 Chicken Little

"So it can now be written in stone as a testament to humanities achievments "PJ did Pi at CP"." Colin Davies

Within you lies the power for good - Use it!

ns27-Jan-03 4:33

27-Jan-03 4:33

In my MFC MDI app I spawn CDIAlog derived windows from the View class. In the release version, if I close the CDialog, and then exit the whole app, it crashes. Doesnt crash if you exit while the CDialog is still up. ALso doesnt crash if we comment out the PostMessage()and then close the CDialog and exit!!!!Heres the OnClose for the CDialog:

void CImageDisplay::OnClose(void) 
{
	m_pParentWnd->PostMessage(UDM_UPDATEDISPLAY,m_imageDisplayVectorIndex);
	

	CDialog::OnClose();
}

For the handler that runs when the msg is received by the vIew

LRESULT CSVBoxView::OnUDMUpdateDisplay(UINT index)
{
	return 0;
}

SendMessage causes really strange behavior in the whole program, and its not really what I want to do. SO what is so peculiar about the postmessage? It does get sent because you step into the handler when debugging...
Please help!

Appreciate your help,
ns

Re: crash on exit in release version with PostMessage!!!!! Help!!!

Michael Dunn27-Jan-03 5:19

Michael Dunn

27-Jan-03 5:19

The signature for the message handler is wrong, it should be

LRESULT CSVBoxView::OnUDMUpdateDisplay ( WPARAM wParam, LPARAM lParam )

the sig used for any generic message handler. It's crashing because PostMessage() puts two parameters on the stack, but the function only removes one, so when the function returns it doesn't read its return address off the stack correctly.

--Mike--
Looks like I picked the wrong week to stop sniffing glue.
1ClickPicGrabber - Grab & organize pictures from your favorite web pages, with 1 click!
My really out-of-date homepage
Sonork-100.19012 Acid_Helm

Gosh!!!! MAny many mnay thanks!!!!

ns27-Jan-03 5:25

27-Jan-03 5:25

I am so glad to get your response> That indeed was it> I cant thank you enough!!!! Big Grin | :-D

Appreciate your help,
ns

Re: Beat me to it

Bill Gates Antimatter Particle27-Jan-03 7:34

Bill Gates Antimatter Particle

27-Jan-03 7:34

Michael Dunn, beat me to it. A similar problem was one of my first ' Unsure | :~

pain in the neck Confused | :confused:

' bugs, when I was still a newbie. The sigs for message handlers have to be correct in release mode, but usually sail through in debug mode without complaint

"Life begins at 140"

Find active Child Frame in MDI app

Aaron Schaefer27-Jan-03 4:30

Aaron Schaefer

27-Jan-03 4:30

Hi There,

Let's say I've got an MFC MDI app with three child frames open. How do I figure out which one is the active one?

Thanks,

Aaron

Re: Find active Child Frame in MDI app

HENDRIK R27-Jan-03 4:41

27-Jan-03 4:41

CFrameWnd supports a function called GetActiveView(). This should work for your purposes.

Tool Bars

will138327-Jan-03 4:27

will1383

27-Jan-03 4:27

Hi All,

I'm creating a toolbar and I have a couple of questions:

1) when setting up a button on a tool bar to be multiple state (i.e. start/stop) and I want to change the bitmap displayed on the button, how do I change the bitmap on the button? And does this bitmaps need to be inserted as an icon or do they both need to be on the toolbar itself? If that is the case, would I have to make two seperate buttons and then hide the one that isn't the current state?

2) Is there a general place to find groups of generic button bitmaps or do I need to make my own?

thank you in advance. I appreciate all the help I have gotten here in the past and in the future.

Thanks.

Dan Willis

RobJones27-Jan-03 7:17

RobJones

27-Jan-03 7:17

Hello,
Hopefully this helps...

groover4life wrote:
1) when setting up a button on a tool bar to be multiple state (i.e. start/stop) and I want to change the bitmap displayed on the button, how do I change the bitmap on the button?

The following code should help.. I create a function so that if a button is pressed and the bitmap needs to be changed.. change the bitmap for the whole tool bar (to either ON or OFF).. if a button is pressed and you dont need to change the bitmaps don't run the following... You get the idea..

You will need to create 2 bitmaps for the tool bar.. one for "ON" and one for "OFF".. both these bitmaps need to be in your resoruces tab..

////////////////////////////////////////////////////////////////////////////////////
// THIS IS FOR SETTING THE OFF BITMAP

// Get the old ImageList and then destroy it.
HIMAGELIST hOld = (HIMAGELIST)::SendMessage(m_wndToolBar, TB_GETIMAGELIST, 0, 0);
ImageList_Destroy(hOld);

// Set up image lists.
CImageList imageList;
CBitmap    bitmap;

// Create and set the toolbar image list.
bitmap.LoadBitmap(IDB_OFF); <-- BITMAP IN RESOURCE
imageList.Create(16, 16, ILC_COLORDDB|ILC_MASK, 3, 1);
imageList.Add(&bitmap, RGB(255,0,255)); 

// Set the new image list on the toolbar
m_wndToolBar.SendMessage(TB_SETIMAGELIST, 0, (LPARAM)imageList.m_hImageList);
						
// Clean up
imageList.Detach();
bitmap.DeleteObject();
// END OF OFF BITMAP
///////////////////////////////////////////////////////////////////////////////////

///////////////////////////////////////////////////////////////////////////////////
// THIS IS FOR SETTING THE ON BITMAP

// Get the old ImageList and then destroy it.
HIMAGELIST hOld = (HIMAGELIST)::SendMessage(m_wndToolBar, TB_GETIMAGELIST, 0, 0);
ImageList_Destroy(hOld);

// Set up image lists.
CImageList imageList;
CBitmap    bitmap;

// Create and set the toolbar image list.
bitmap.LoadBitmap(IDB_ON); <-- BITMAP IN RESOURCES
imageList.Create(16, 16, ILC_COLORDDB|ILC_MASK, 3, 1);
imageList.Add(&bitmap, RGB(255,0,255)); 

// Set the new image list on the toolbar
m_wndToolBar.SendMessage(TB_SETIMAGELIST, 0, (LPARAM)imageList.m_hImageList);
						
// Clean up
imageList.Detach();
bitmap.DeleteObject();
// END OF ON BITMAP
///////////////////////////////////////////////////////////////////////////////////

groover4life wrote:
2) Is there a general place to find groups of generic button bitmaps or do I need to make my own?

I'm sure you can find them some where.. I usually just make my own..

Hope this helps..

Rob

will138327-Jan-03 8:59

will1383

27-Jan-03 8:59

This helps.

BUT, if I have ... say ... 10 buttons that each have 2 functions to them (I don't, but just an example) I'd have to have a TON of bit maps just for that 1 tool bar. There's gotta be a more efficient way to do it. In my case this would work becuase I only have a couple of buttons, which would mean I'd have to have 4 different bitmaps I'd have to load depending on the state I'm in.

Thanks!

Dan Willis

RobJones27-Jan-03 9:12

RobJones

27-Jan-03 9:12

Yep your right.. The example I provided was based on how to change the bitmap for all buttons on the toolbar (not very usefull in your example).. I know there are articles here on codeproject and on codeguru that will show you how to do just what you are trying to do..

Rob

Colouring one row of CListView Class:)

PJ Arends27-Jan-03 11:51

PJ Arends

27-Jan-03 11:51

Ok, here comes a real hack that does work, but once implemented you will not be able to change your toolbar using the toolbar resource editor, so make sure you have all your buttons set up in their default states first.

1.) Using MSPaint (or another graphics editing tool) extend the toolbar bitmap by adding the new bitmaps you want to the end of it. remember to make all the images the same size (default is 16 x 15 pixels)

2.) to the class that will handle the button states, add an integer variable that will keep track of which bitmap is currently displayed on each button (use seperate variables or an array of them). The variable will hold the index number of the image in the bitmap. remember that the first image in the bitmap is at index 0 not 1.

3.) add an ON_COMMAND message handler for the button being clicked. in that handler, change the index variable to contain the index of the new image

4.) add an ON_UPDATE_COMMAND_UI handler for the button. here you check if the command is coming from the toolbar (as opposed to the menu), and then you use CToolBar::SetButtonInfo() to change the image.

CMyView::OnUpdateAppAbout(CCmdUI* pCmdUI)
{
    if (pCmdUI->m_pOther && pCmdUI->m_pOther->IsKindOf(RUNTIME_CLASS(CToolBar)))
    {
        CToolBar *pTB = (CToolBar *)pCmdUI->m_pOther;
        pTB->SetButtonInfo(pCmdUI->m_nIndex, pCmdUI->m_nID, TBBS_BUTTON, m_nAboutImage);
    }
}

although you may want to use CToolBar::GetButtonInfo() to get the button style

omer ejaz27-Jan-03 4:10

omer ejaz

27-Jan-03 4:10

Actually i need to colour different rows of CListView by different colours...so how to do this?
Any Help ...
Thanks

Re: Colouring one row of CListView Class:)

HENDRIK R27-Jan-03 4:44