|
Well, I've changed the code as you've suggested, but the handle leaks are even faster than before... (I'm sure that it is my fault because it's the first time that I use this kind of pointers and that I work with HTMLViews...). This is the code:
CComQIPtr<IHTMLDocument2> pHtmlDoc(this->GetHtmlDocument());
if (pHtmlDoc)
{
pSafeArray = ::SafeArrayCreateVector(VT_VARIANT, 0, 1);
if (pSafeArray)
{
hr = ::SafeArrayAccessData(pSafeArray,(LPVOID*) &pElement);
if (!SUCCEEDED(hr))
{
bRetorn = false;
}
else
{
pElement->vt = VT_BSTR;
pElement->bstrVal = csHTML.AllocSysString();
hr = SafeArrayUnaccessData(pSafeArray);
if (!SUCCEEDED(hr))
{
bRetorn = false;
}
else
{
pHtmlDoc->clear();
pHtmlDoc->close();
hr = pHtmlDoc->write(pSafeArray);
if (!SUCCEEDED(hr))
{
bRetorn = false;
}
}
SysFreeString(pElement->bstrVal);
}
if (pSafeArray) SafeArrayDestroy(pSafeArray);
}
pHtmlDoc->close();
}
In the other hand, and using the first code (the posted in the first question) I've changed two things (and this is how the code is working now):
lpDispatch = this->GetHtmlDocument();
if (lpDispatch)
{
hr = lpDispatch->QueryInterface(IID_IHTMLDocument2, (LPVOID*)&pHTMLDoc2);
if (!SUCCEEDED(hr))
{
bRetorn = false;
}
else
{
pSafeArray = ::SafeArrayCreateVector(VT_VARIANT, 0, 1);
if (pSafeArray)
{
hr = ::SafeArrayAccessData(pSafeArray,(LPVOID*) &pElement);
if (!SUCCEEDED(hr))
{
bRetorn = false;
}
else
{
pElement->vt = VT_BSTR;
pElement->bstrVal = csHTML.AllocSysString();
hr = SafeArrayUnaccessData(pSafeArray);
if (!SUCCEEDED(hr))
{
bRetorn = false;
}
else
{
pHTMLDoc2->clear();
pHTMLDoc2->close();
hr = pHTMLDoc2->write(pSafeArray);
if (!SUCCEEDED(hr))
{
bRetorn = false;
}
}
SysFreeString(pElement->bstrVal);
}
if (pSafeArray) SafeArrayDestroy(pSafeArray);
}
if (pHTMLDoc2) pHTMLDoc2->close();
}
pHTMLDoc2->Release(); <code>this is new...</code>
lpDispatch->Release(); <code>this is what I've moved...</code>
}
Using this version the problems are exactly the same than the ones that I've found in the first release...
Could you give me an idea on how to continue working? my customer has already seen the program and this program has to work 24 hours a day, this means that I cannot go back to plain texts and that I must find the solution...
Thanks a lot in advance...
|
|
|
|
|
I would remove the clear() and close() method calls, since the only thing that matters is the write() method.
|
|
|
|
|
Well, thank you, I've done it and it continue working, but it continue leaking some handles...
I have more information to give to you:
The third code portion (step 3.) doesn't seems to be the guilty: that HTMLView modify it's contents each time the user selects items in a listView.
The HTML is used in order to show information regarding to items of a ListView, so each time that the user changes the selection the HTML gets changed...
The fact is that when the user changes the HTML View via selecting another field, nothing happens (I don't leak any handle).
but the first time the leaking occurs...
It seems that I create the new page via "Navigate2(_T("about:blank"));" and that when after I try to modify it I don't do it allright, because then and only then is when the leaks happen:
PROGRAM FLOW WHEN LEAKING HAPPEN:
1. this->Navigate2(_T("about:blank"), navNoHistory); <code>This line ONLY happens at the intitialization of the view...</code>
2. Selecting programatically the first item in the listview.
3. OnItemchanged calls PrepareHTML(); (Only one time (I'm sure about it))
4. PrepareHTML(); contains the <code>step 3</code> (the one you've helped me to modify...)
5. Closing window.
PROGRAM FLOW WHEN LEAKING HAPPEN 2:
1. this->Navigate2(_T("about:blank"), navNoHistory); <code>This line ONLY happens at the intitialization of the view...</code>
2. Selecting programatically the first item in the listview.
3. OnItemchanged calls PrepareHTML(); (Only one time (I'm sure about it))
4. PrepareHTML(); contains the <code>step 3</code> (the one you've helped me to modify...)
5. the user selects n times other items in the listview. <code>see notes below "note 1"</code>
6. Closing window.NOTES:
note 1:
It's curious to see that the same handles are leaked if the user selects 2000 different items in the listview or if the user doesn't select any other item than the first one that is selected.
note 2:
If I comment the line that writes the safearray inside the HTML (inside the step 3)(hr = pHTMLDoc2->write(pSafeArray);) then no leaks happen.
note 3:
notes 1 and 2 make me think that I have misunderstood something in the middle of the steps 1 and 3 because the leaking only happen between those steps...
I've noticed that leakage only happens when I create the HTML page using Navigate2 and when after I Write a safearray inside the HTML page... leakage doesn't happen if, after the first time I select n items in the listview, in this case the HTML modification happens without any error...
As always thank you in advance.
|
|
|
|
|
I don't know what might be the point of doing Navigate2("about:blank"). I don't think it is necessary. After all, once the underlying web browser instance is running, there is a default document to write to.
|
|
|
|
|
I thought this, but when I try to get the document the lpdispatch is not ready...
I would not do this if I would know how to create and attach a document to the CHTMLView...
But meanwhile...
Time to say that the HTMLView is not a normal HTMLView...
It's a HTMLCtrl, a wrapper class written by Paul DiLascia that makes possible to insert a HTMLView inside a dialog.
But before posting the question here in CP, I wrote down to Mr. DiLascia in order to ask him about it and his answer was that it must be a error of the MFC because his class was just a wrapper...
If you want I can try to send you a little sample code in order to make easier to talk about the problem...
What do you think about me sending you a little sample of this?
If you don't want to receive my little sample (with all the needed modifications), you can also download his article and source codes from his site at: http://www.microsoft.com/msj/0100/c++/c++0100.asp[^]
Note:
The DiLascia's article doesn't modify dynamically the web page contents.
Thanks a lot in advance for your time and help.
|
|
|
|
|
Ok then, to spend as little time as possible with the handle leak issue, the first thing to do is to isolate the code. This is a general debugging rule, and it translates in your particular case by trying to reproduce the behaviour with a simple CHtmlView class.
Good luck!
|
|
|
|
|
I have a little sample ready, can I send it to you? it's really simple:
2 dialogs and 3 buttons...
What do you think about it?
Thank you in advance.
|
|
|
|
|
Hello,
I'd like to tell you that I'm very sorry to annoy you with my problems... I don't like to do it, but I need to solve those problems as fast as I can... the program is now installed in an industrial PC that controls a machine and after some hours the PC crashes...
I hope that after seeing the little program you'll be able to tell me how stupid I've been to pass a surely easy thing...
As I said before (in other post) I'm dealing with those pointers and HTML for first time...
Thank you in advance, and please, if you don't want me to send you the sample, feel free to tell it to me, you've been trying to help me for a long time and I don't want to annoy you more...
|
|
|
|
|
Hello, I've written down (and posted) an article on how to place HTML inside a dialog (from Paul DiLascia) and how to change it dynamically, it is about what I've been asking you those days...
Would you be so kind to take a look at it? you could download the demo project and see what happens directly...
this is the direction of the article: http://www.codeproject.com/useritems/HTMLCtrlSample.asp[^]
Thank you in advance.
|
|
|
|
|
Joan,
Can you explain what you are trying to accomplish in step 3. Is this just to give you a blank html page to work with or ...??
Neville Franks, Author of ED for Windows. www.getsoft.com
Make money with our new Affilate program
|
|
|
|
|
In step 1 or 2 I make the browser to load a blank page in order to be able to work with it (create a new page).
In step 3 I modify the contents of the newly created HTML page using a CString that contains the code that I want to appear inside the HTML page.
Then, as I don't know how to tell the HTMLView to create a new HTML page to work with it, I make the HMLView to navigate to a blank page (steps 1 or 2) and then I modify this page (step 3).
hope this clarify what I'm trying to do...
Thank you for your interest.
|
|
|
|
|
Hi Joan,
Another simpler way to replace your page is as follows:
1) In your blank page add an id attribue to the body tag. eg:
<body id="mybody">
2) The use this code:
MSHTML::IHTMLDocument2Ptr pDoc( GetHtmlDocument() );
MSHTML::IHTMLElementPtr e;
e = pDoc->Getall()->item( _T("mybody") );
if ( e != NULL )
{
e->PutinnerHTML( (LPCSTR)sYourString.GetBuffer() );
sYourString.ReleaseBuffer();
}
This replaces all the html between the open and close body tags. It should do what you want.
Neville Franks, Author of ED for Windows. www.getsoft.com
Make money with our new Affilate program
|
|
|
|
|
the problem (I think) is that I'm not using CHTMLView in an ordinary view, I'm doing it in a dialog...
Do you mean that I should do this in the creation?
this->Navigate2(_T("about:<html><body id=\"mybody\"></body></html>"), navNoHistory);I'm prepairing an article about this but I would like to catch the handle that is being missed...
Could I send you a little demo project prepared to reproduce the problem only pressing two keys?
Then you would be able to see exactly what is happening...
Thank you in advance...
|
|
|
|
|
Hello, I've written down (and posted) an article on how to place HTML inside a dialog (from Paul DiLascia) and how to change it dynamically, it is about what I've been asking you those days...
Would you be so kind to take a look at it? you could download the demo project and see what happens directly...
this is the direction of the article: http://www.codeproject.com/useritems/HTMLCtrlSample.asp[^]
Thank you in advance.
|
|
|
|
|
hi,
I have this problem that wenn i begin printing a drawing with Visual C++ it doesn't fill a rectangle. i just use the function:
<br />
void CRSARuitLocaties::SelectPrintRuit(CDC *dc, CRect r, FLOAT Factor, int Ruitnr)<br />
{<br />
m_strFilter.Format("Nr = %d", Ruitnr);<br />
Open();<br />
<br />
int x,y;<br />
<br />
CBrush* brush;<br />
CBrush* oldBrush;<br />
<br />
brush = new CBrush(RGB(255,0,0));<br />
<br />
while(!IsEOF())<br />
{<br />
oldBrush = dc->SelectObject(brush);<br />
<br />
x = r.left + (m_xmiddel / Factor);<br />
y = r.top - (m_ymiddel / Factor);<br />
<br />
dc->FloodFill(x, y, RGB(0,0,0));<br />
dc->SelectObject(oldBrush);<br />
MoveNext(); <br />
}<br />
<br />
delete brush;<br />
<br />
Close();<br />
}<br />
the locations are right, i've checked...
|
|
|
|
|
|
|
my problem is:
I have a file, where I write some data(for example name, description, date). and I have to delete one record. how do I have to do this?
|
|
|
|
|
Using C or C++ functions?
How are u writing to the file
Anyway consider using fseek or CFile:Seek and be sure u dont open in append mode
|
|
|
|
|
I am writing like this:
"ses" is my serializable class
I want to save "name" and "date"
ses.Add(name);
ses.Add(date);
and after I am writing into the file.
mode "write".
|
|
|
|
|
I have two modeless dialogs (two different classes). Each has a textbox. I want to see when the user pressed Enter - SO I overrride OnCommand() in both of the CDialogs. Now if I press enter in the Dilaog#1 textbox, the OnCommnad of that class will run. But wil the OnCommnad of the other class run too? Or does the message (WM_COMMAND) generated on pressing Enter pertain only to the window in which the enter key was pressed?
Appreciate your help,
ns
|
|
|
|
|
You can you PreTranslateMessage defined in each dialog class.
BOOL CYourClass::PreTranslateMessage( MSG* pMsg )
{
if ( (pMsg->message == WM_KEYDOWN) && (pMsg->wParam == VK_RETURN) )
{
return TRUE;
}
return CYourBaseClass::PreTranslateMessage(pMsg);
}
Max.
Maximilien Lincourt
For success one must aquire one's self
|
|
|
|
|
Thank you! I will try it.
Appreciate your help,
ns
|
|
|
|
|
Exactly what I needed.
Appreciate your help,
ns
|
|
|
|
|
Is it possible to use get to read a file in as a string without the whitespace characters.
I have done this effectively by using >> and a loop but I was wondering if I could do it with get.
btw I have called File.setf(ios::skipws) without success.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
