Re: Strange error - C / C++ / MFC Discussion Boards

jhwurmbach4-Aug-03 2:30

4-Aug-03 2:30

BoudewijnEctor wrote:
Can someone tell me what i wrong with this?

Only if you give more info - just show a few lines of code, e.g. the function where the error hits.

Who is 'General Failure'? And why is he reading my harddisk?!?

Re: Strange error

BoudewijnEctor4-Aug-03 2:37

BoudewijnEctor

4-Aug-03 2:37

There you are: Dead | X|

The bold big italic code is where the prgram syas it crashes (it seems strange)

CF2FDlg is the first screen, wich calles the second (and other...) wich is IOschermclass, and is also the one wich must be shown after clicking cancel in the IOschermclass

void CF2FDlg::ga_naar_IOscherm(Cmodeprop C)
{
IOschermclass *iosclass= new IOschermclass();
INT_PTR nRet = -1;
nRet=iosclass->DoModal();

switch(nRet)
{
case IDCANCEL:
{
return;
}
case IDC_stop:
{
break;
}

case 1:
{
return;
}
default:
{
return;
}
};

return;
}

void IOschermclass::OnBnClickedTerug()
{
EndDialog(ID_TERUG);
}

BEGIN_MESSAGE_MAP(IOschermclass, CDialog)
ON_BN_CLICKED(IDC_BUTTON1, OnBnClickedButton1)
ON_BN_CLICKED(IDC_BUTTON2, OnBnClickedButton2)
ON_BN_CLICKED(IDCANCEL, OnBnClickedCancel)
ON_BN_CLICKED(IDOK_IOscherm, OnBnClickedIoscherm)
//ON_BN_CLICKED(IDCANCEL2, OnBnClickedCancel2)
ON_BN_CLICKED(IDC_CHECK, OnBnClickedCheck)
ON_BN_CLICKED(IDC_BUTTON3, OnBnClickedButton3)
ON_STN_CLICKED(ID_outpad, OnStnClickedoutpad)
ON_COMMAND(IDOK_IOscherm,OnBnClickedIoscherm)
//ON_COMMAND(ID_TERUG,OnBnClickedTerug)
ON_BN_CLICKED(ID_TERUG, OnBnClickedTerug)
ON_STN_CLICKED(ID_inpad, OnStnClickedinpad)
ON_BN_CLICKED(IDC_stop, OnBnClickedstop)
ON_COMMAND(IDC_stop,OnBnClickedstop)
END_MESSAGE_MAP()

Re: Strange error

jhwurmbach4-Aug-03 3:08

jhwurmbach

4-Aug-03 3:08

Some annotations to your code:
A) Where is the delete corresponding to your new. These need to come in pairs!
As it is now, you probably have a memory leak: After iosclass has gone out of scope, there is no way you can ever call delete on it.
But maybe you are doing a delete this inside of the class?

B) nRet only needs to be of type int, not INT_PTR. That you are calling DoModal() via a pointer does not change its return type.

Otherwise, it looks OK. I am puzzled here why this should not work.
Check for nRet geting assigned ID_TERUG and step through the switch/case.

Who is 'General Failure'? And why is he reading my harddisk?!?

Re: Strange error

BoudewijnEctor4-Aug-03 3:12

BoudewijnEctor

4-Aug-03 3:12

Ok, Il'll give it a try.

A) I didn't use delete --> variables will go out of of scope automatically, and I do not (as far as I know) have any memory problems

B) is it really, I got the INT_PTR form an MSDN example --> first I used an int too, but after I saw the example I thought it might be better to use an INT_PTR

Thanks

Re: Strange error

jhwurmbach4-Aug-03 3:35

jhwurmbach

4-Aug-03 3:35

Looking at the error code again:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared
with one calling convention with a function pointer declared with a different calling
convention"

I begin to suspect that you have confused the compiler by changing some of the
ON_... stuff that the CodeWizard produces by hand.
That way the ON_... macros may produce wrong code.

Hope this helps

Who is 'General Failure'? And why is he reading my harddisk?!?

Re: Strange error

BoudewijnEctor4-Aug-03 3:45

BoudewijnEctor

4-Aug-03 3:45

Here are my ON_COMMAND's etc:

BEGIN_MESSAGE_MAP(IOschermclass, CDialog)
ON_BN_CLICKED(IDC_BUTTON1, OnBnClickedButton1)
ON_BN_CLICKED(IDC_BUTTON2, OnBnClickedButton2)
ON_BN_CLICKED(IDCANCEL, OnBnClickedCancel)
ON_BN_CLICKED(IDOK_IOscherm, OnBnClickedIoscherm)
//ON_BN_CLICKED(IDCANCEL2, OnBnClickedCancel2)
ON_BN_CLICKED(IDC_CHECK, OnBnClickedCheck)
ON_BN_CLICKED(IDC_BUTTON3, OnBnClickedButton3)
ON_STN_CLICKED(ID_outpad, OnStnClickedoutpad)
ON_COMMAND(IDOK_IOscherm,OnBnClickedIoscherm)
//ON_COMMAND(ID_TERUG,OnBnClickedTerug)
ON_BN_CLICKED(ID_TERUG, OnBnClickedTerug)
ON_STN_CLICKED(ID_inpad, OnStnClickedinpad)
ON_BN_CLICKED(IDC_stop, OnBnClickedstop)
ON_COMMAND(IDC_stop,OnBnClickedstop)
END_MESSAGE_MAP()

It's exact the same as in other parts of my app, but it doesn't work!!!!! Mad | :mad:

Re: Strange error

Ryan Binns4-Aug-03 4:56

Ryan Binns

4-Aug-03 4:56

Post the declarations of those functions, in your class's header file

Ryan

"Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"

Re: Strange error

jhwurmbach4-Aug-03 4:41

jhwurmbach

4-Aug-03 4:41

OK, here is how it works with me:

GeneralPP, derived from a CPropertyPage, contains a button to show a CAdvProcDlg, derived from CDialog.
After closing CAdvProcDlg, you can then proceed to use GeneralPP or even call CAdvProcDlg again.
In my case, there is no need to call EndDialog() in CAdvProcDlg, I only use IDOK and IDCANCEL.

void CGeneralPP::OnButtonProcAdvanced() 
{
    CAdvProcDlg dlg;
// set member variables in dlg

    int result = dlg.DoModal(); //show the Dialog
    if (result != IDOK)
    {   //ignore changes made from dlg
        if (result!=IDCANCEL)
        {
            TRACE1("CAdvProcDlg ended with %d", result);    //warn if neither OK nor CANCEL
        }
    }
    else
    {
// retreive member variable content from dlg
    }
}

[EDIT]
Please not the function signature of my OnButtonProcAdvanced() function: return type void, parameter list void, too. This may very well make the difference?
[/EDIT]

Who is 'General Failure'? And why is he reading my harddisk?!?

Re: Strange error

Bob Stanneveld4-Aug-03 22:13

Bob Stanneveld

4-Aug-03 22:13

Hello,

Did you port some old code written in a different language that are not part of a standard library? If so, and they are called from IOschermclass, try not to call those.

The is a tiny change that this will help you getting closer to the source of your problem...

A student knows little about a lot.
A professor knows a lot about little.
I know everything about nothing.

Re: Strange error

BoudewijnEctor4-Aug-03 22:16

BoudewijnEctor

4-Aug-03 22:16

No,

it's all fesh, brand new code, written in MFC C++ in vStudio .NET 2003

Re: Strange error

Bob Stanneveld4-Aug-03 22:23

Bob Stanneveld

4-Aug-03 22:23

If you press other bottons on the dialog, do you get the same error?

jij bent trouwens de eerste nederlander die ik hier tegenkom Smile | :)

A student knows little about a lot.
A professor knows a lot about little.
I know everything about nothing.

Re: Strange error

BoudewijnEctor4-Aug-03 22:25

BoudewijnEctor

4-Aug-03 22:25

No, i don't get the same error : it's unique

Nee hoor, ik krijg niet dezelfde error, dit gebeurt alleen bij die specfieke knop.

Re: Strange error

Bob Stanneveld4-Aug-03 22:27

Bob Stanneveld

4-Aug-03 22:27

Post the code for the OnCancel() method, the problem probably lies there

A student knows little about a lot.
A professor knows a lot about little.
I know everything about nothing.

Re: Strange error

Bob Stanneveld4-Aug-03 22:32

Bob Stanneveld

4-Aug-03 22:32

I mean the OnBnClickedCancel() method,...

A student knows little about a lot.
A professor knows a lot about little.
I know everything about nothing.

Re: Strange error

BoudewijnEctor4-Aug-03 22:33

BoudewijnEctor

4-Aug-03 22:33

it's just EndDialog(IDCANCEL);

Re: Strange error

Bob Stanneveld4-Aug-03 22:45

Bob Stanneveld

4-Aug-03 22:45

When I look at the declaration of EndDialog, you are missing a parameter! (from the msdn library: BOOL EndDialog(HWND hDlg, INT_PTR nResult);)

but let's get something straight:
When you press the cancel button, OnBnClickedCancel() is called.
From there you call EndDialog().

Assuming this, maybe you should call CDialog::OnCancel(). The EndDialog function just ends the message loop returning control to the system, maybe something goes wrong there.

A student knows little about a lot.
A professor knows a lot about little.
I know everything about nothing.

Re: Strange error

BoudewijnEctor4-Aug-03 23:00

BoudewijnEctor

4-Aug-03 23:00

OK,

I'll try: wait a moment

Re: Strange error

BoudewijnEctor4-Aug-03 23:06

BoudewijnEctor

4-Aug-03 23:06

I'm sorry, doesn't work

DO you have got some other idea's

I'll put the code of my first window, wich will have to receive the message, below this text.

void CF2FDlg::ga_naar_IOscherm(Cmodeprop C)<br />
{	<br />
	IOschermclass *iosclass;<br />
	iosclass=new IOschermclass();<br />
	iosclass->set_properties(C);<br />
	//IOschermclass *ios=new IOschermclass();<br />
	//ios->set_properties(C);		//Pass the selected filter\option\converter<br />
	//ios->set_hoofdscherm(this); //send this Dialog, to make sure we can press the cancel button in the next screen<br />
	<br />
	INT_PTR nRet = -1;<br />
	//nRet=ios->DoModal();<br />
	nRet=iosclass->DoModal();<br />
<br />
<br />
<br />
	switch(nRet)<br />
	{<br />
		case IDCANCEL:<br />
		{<br />
			return;<br />
		}<br />
		case IDC_stop:<br />
		{<br />
			break;<br />
		}<br />
		<br />
		case 1:<br />
		{<br />
			return;<br />
		}<br />
		default:<br />
		{<br />
			return;<br />
		}<br />
	};<br />
	<br />
	<br />
	return;<br />
}<br />

Re: Strange error

BoudewijnEctor4-Aug-03 23:08

BoudewijnEctor

4-Aug-03 23:08

I'm sorry, doen't work

DO you have got some other idea's<br />
<br />
I'll put the code of my first window, wich will have to receive the message, below this text.<br />
<br />
<br />
void CF2FDlg::ga_naar_IOscherm(Cmodeprop C)<br />
{ <br />
IOschermclass *iosclass;<br />
iosclass=new IOschermclass();<br />
iosclass->set_properties(C);<br />
//IOschermclass *ios=new IOschermclass();<br />
//ios->set_properties(C); //Pass the selected filter\option\converter<br />
//ios->set_hoofdscherm(this); //send this Dialog, to make sure we can press the cancel button in the next screen<br />
<br />
INT_PTR nRet = -1;<br />
//nRet=ios->DoModal();<br />
nRet=iosclass->DoModal();<br />
<br />
<br />
<br />
switch(nRet)<br />
{<br />
case IDCANCEL:<br />
{<br />
return;<br />
}<br />
case IDC_stop:<br />
{<br />
break;<br />
}<br />
<br />
case 1:<br />
{<br />
return;<br />
}<br />
default:<br />
{<br />
return;<br />
}<br />
};<br />
<br />
<br />
return;<br />
}<br />

Re: Strange error

BoudewijnEctor5-Aug-03 1:33

BoudewijnEctor

5-Aug-03 1:33

I just solved the problem... I thought you might like to know how I did it,, but I don't understand it myself --> when I removed the setproperties call, everything worked okay.
The program must have had the problems because of that crash, although it is just a very simple function:

Th second screen has an own object of type Cmodeprop, with setproperties you povide an object to get passed to the second window. It is something like this:

set_properties (Cmodeprop C)<br />
{<br />
  own_props=C;<br />
return;<br />
}

This is really strange (microsoft!!!)

Re: Strange error

Bob Stanneveld5-Aug-03 4:40

Bob Stanneveld

5-Aug-03 4:40

That sure is strange! Well, At least you solved it! Smile | :)

.
I once had a strange assertion in my program. It took me 3 days to solve it Dead | X|

!

(by the way, Cmodeprops is probaly a class, did you write a copy constructor? or overload the operator=? It might solve something!)

Good luck...

Re: Strange error

Vitali Halershtein4-Aug-03 2:37

Vitali Halershtein

4-Aug-03 2:37

Hello,

I had a similar error. Try "Rebuild All"

Re: Strange error

BoudewijnEctor4-Aug-03 2:43

BoudewijnEctor

4-Aug-03 2:43

Let me try........

No doesn't work:

I've pressed clean solution under BUILD, ad then Rebuild Solution. After trying again I got the same error Mad | :mad:

Re: Strange error

Vitali Halershtein4-Aug-03 2:56

Vitali Halershtein

4-Aug-03 2:56

It is strange Eek! | :eek:

Difficult say more without seeing project settings and code...

Vitali

Re: Strange error

BoudewijnEctor4-Aug-03 2:59

BoudewijnEctor

4-Aug-03 2:59

I've put some code on this forum (this thread at 8:37), please take a look

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.