Bugs and Suggestions

15-Nov-01 12:29

This has gone on the TODO list. Nice one!

cheers,
Chris Maunder (CodeProject)

Ad problem?

Roger Allen9-Nov-01 4:39

Roger Allen

9-Nov-01 4:39

I seem to have an intermittent problem when accessing CP threads. Every so often when I expand a message after about 2 secs, IE switches to a "This page cannot be found" or equivalent Frown | :(

It seems that the page is trying to switch to a different ad which is not found. Basically this makes the board practiacally unreadable Cry | :((

as you only have 2 seconds to read that post..

Is anybosy else affected by this or is it just me?

Roger Allen the Smile | :)

man

Re: Ad problem?

Nish Nishant9-Nov-01 4:45

Nish Nishant

9-Nov-01 4:45

Yup

its happnd to me a few times
I think its somethin to do with bandwidth
When my connection gets slow, this happens quite often and when I hit the back-button it has gotta load the entire page Frown | :-(

Nish

Sonork ID 100.9786 voidmain

www.busterboy.org

Nish is a BIG fan of Goran Ivanisevic

Re: Ad problem?

Rassman9-Nov-01 4:56

Rassman

9-Nov-01 4:56

Stop your browser from stopping on errors (Tools-Options-Advanced). Disable script debugging and notification on errors (loads of Ads are error prone).

Ok so you run the risk of missing 'Lucy Linda wants to see you at her very own site' adverts, but thats a price we must pay.

We do it for the joy of seeing the users struggle.

Re: Ad problem?

[James Pullicino]10-Jan-02 0:26

[James Pullicino]

10-Jan-02 0:26

I don't know if my problem is related but, its really annoying that some ad banners on this site are loaded from external sites (like the Dundas advert http://www.dundas.com/products/mfc/grid/images/Grid5Banner.gif)

It is annoying since over here we have a firewall which only allows access to certain sites, and www.dundas.com is not one of them, so every now and then I get an Access denies message.

(2b || !2b)

Quoting

Thomas Freudenberg8-Nov-01 1:34

Thomas Freudenberg

8-Nov-01 1:34

Chris, how about a Reply with quote button. Many times when editing a reply you will quote the previous posting, so an automatism would be very helpful. I suggest following format:

Thomas Freudenberg wrote:
Chris, how about a Reply with quote button. Many times when editing a reply you will quote the previous posting, so an automatism would be very helpful. I suggest following format:

<blockquote><hr><small>
<b><a href="/script/profile/whos_who.asp?id=4960" target="_blank">Thomas Freudenberg</a> wrote:</b>
<br>
Chris, how about a <i>Reply with quote</i> button. Many times when editing
a reply you will quote the previous posting, so an automatism would be very helpful. I
suggest following format:
</small><hr></blockquote>

Regards
Thomas

Disclaimer:
Because of heavy processing requirements, we are currently using some of your unused brain capacity for backup processing. Please ignore any hallucinations, voices or unusual dreams you may experience. Please avoid concentration-intensive tasks until further notice. Thank you.

Michael P Butler8-Nov-01 2:01

Michael P Butler

8-Nov-01 2:01

I don't know if that is a good thing. Having it quote the entire message would lead to a lot of having to read through the same comments a lot of times in the different messages. I prefer just to quote the relevant part I'm replying to. Imagine the last message in a thread having the entire message made up of the entire thread plus a me too response.

Michael Smile | :)

Thomas Freudenberg8-Nov-01 2:31

Thomas Freudenberg

8-Nov-01 2:31

Michael P Butler wrote:
I prefer just to quote the relevant part I'm replying to.

And so I do Wink | ;)

I know that trusting in the user's discipline to quote relevant parts only is too naive. Of course we must find a compromise between easy quoting and completely quoted threads.

Regards
Thomas

Paul Watson11-Nov-01 0:17

11-Nov-01 0:17

Why not have it so that the user has to highlight the text they want to quote and then click a Quote button which inserts the highlighted text with the Quote formatting into the text box.

If they don't highlight any text then nothing happens when they click the button (or it pops up a message saying "Highlight some text, please").

regards,
Paul Watson
Bluegrass
Cape Town, South Africa

Do you Sonork? I do! 100.9903 Stormfront

"The greatest thing you will ever learn is to love, and be loved in return" - Moulin Rouge

Chris Maunder11-Nov-01 21:52

11-Nov-01 21:52

If you can work out the javascript that copies the selected text and pastes it into the edit window then you're a better man than I! (spent many hours trying to do exactly this - am I missing something simple?)

cheers,
Chris Maunder (CodeProject)

Paul Watson11-Nov-01 22:40

11-Nov-01 22:40

If you can work out the javascript that copies the selected text and pastes it into the edit window then you're a better man than I!

You should not set yourself up like that because...
Tada! Get selected text example

The trick is not so simple. Basically you have to create a textRange object and then pull the value from there.

Here is an example (very simple and quick):

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
	<title>Untitled</title>
	<script language="JavaScript">
		function getSel()
		{
			if (document.getSelection) txt = document.getSelection();
			else if (document.selection) txt = document.selection.createRange().text;
			else return;
			if (txt !== ""){
			txtReply.value = "<HR><I>" + txt.replace(new RegExp('([\\f\\n\\r\\t\\v ])+', 'g')," ") + "</I><HR>";
			}
			else
			{
				alert('You must please select some text to quote');
			}
		}
	</script>
</head>

<body>
	<DIV id="divOriginalPost">This is the original post, select some text and then click the quote button</DIV>	
	<TEXTAREA id="txtReply" COLS="40" ROWS="10"></TEXTAREA>
	<INPUT type="Button" onclick="getSel()" id="cmdQuote" value="Quote">

</body>
</html>

It can be made to work in Netscape. We had to do this for an intranet project and it was a pain to figure out. Luckily that link I posted above helped a lot Smile | :)

I still don't feel a better man than you though. Laugh | :laugh:

regards,
Paul Watson
Bluegrass
Cape Town, South Africa

Do you Sonork? I do! 100.9903 Stormfront

"The greatest thing you will ever learn is to love, and be loved in return" - Moulin Rouge

Chris Maunder12-Nov-01 16:22

12-Nov-01 16:22

Thanks Paul, thanks Mike!

The quote button is in.

cheers,
Chris Maunder (CodeProject)

Paul Watson12-Nov-01 18:54

12-Nov-01 18:54

*highlight text*
*click quote*

Chris Maunder wrote:
Thanks Paul, thanks Mike!

The quote button is in.

Ooooohhhhh Smile | :)

Now all we need is a "Generate rational, intelligent and rallying counter arguement" button... Big Grin | :-D

regards,
Paul Watson
Bluegrass
Cape Town, South Africa

Do you Sonork? I do! 100.9903 Stormfront

"The greatest thing you will ever learn is to love, and be loved in return" - Moulin Rouge

Michael Dunn11-Nov-01 22:42

Michael Dunn

11-Nov-01 22:42

Here's code that will append the current selection to the end of the textarea's contents. I couldn't figure out how to insert it at the current caret position (or even how to get the caret position).
Button1 = your Paste button, Text1 = the text box.

function Button1_onclick() {
var seltext = document.selection.createRange().text;
	if ( seltext != "" )
		Text1.value += seltext;
}

--Mike--
http://home.inreach.com/mdunn/
#include "witty_sig.h"
Heart | [heart]

your

with

and

Paul Watson11-Nov-01 23:05

11-Nov-01 23:05

I couldn't figure out how to insert it at the current caret position (or even how to get the caret position).

I noticed that when inserting emoticons on CP it also just puts it at the end of the text, not where the cursor is.

However, seeing as focus is passed to the Quote button would there be a cursor (caret) position to get? I guess onblur of the textbox you could record the last caret position and use that. Then when you click the Quote button it uses the caret variable as the position... hmmm might work.

brb, trying it out Big Grin | :-D

regards,
Paul Watson
Bluegrass
Cape Town, South Africa

Do you Sonork? I do! 100.9903 Stormfront

"The greatest thing you will ever learn is to love, and be loved in return" - Moulin Rouge

Chris Maunder12-Nov-01 16:20

12-Nov-01 16:20

Paul Watson wrote:
I guess onblur of the textbox you could record the last caret position and use that. Then when you click the Quote button it uses the caret variable as the position... hmmm might work.

brb, trying it out

Any luck?

cheers,
Chris Maunder (CodeProject)

Paul Watson12-Nov-01 20:26

12-Nov-01 20:26

Chris Maunder wrote:
Any luck?

Here it is Chris. Once again not all my work, got it from FAQTs - Knowledge Base.

I took your new Quote code and put in the other code.

Once again it uses the TextRange object and then the CharAt method.

You may have to do a few more tests than I did on recording the caret position from the TEXTAREA as I have only covered OnClick and OnKeyPress. (Avoid the OnBlur, something odd happens)

You could also use the functions for inserting the Emoticons! That would be nice Big Grin | :-D

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
	<title>Untitled</title>
</head>
<script language='JavaScript'>
<!--
function QuoteText(author)
{
	var txt = "";
	if (document.getSelection) txt = document.getSelection();
	else if (document.selection) txt = document.selection.createRange().text;
	else return;

	var emph = false;
	emph = true
	var TextArea = txtReply;
	if (txt !== "") {
		var text = "";
		//var text = TextArea.value;
		var length = text.length;
		if (length > 0 && text.charAt(length-1) != "\n") text += "\n\n";
		
		text += (author + " wrote:\n");
		if (emph) text += "<i>";
		text += txt;
		if (emph) text += "</i>";
		text += "\n\n";
		
		insertAtCaret(TextArea, text);
		
		TextArea.focus();
	}
	else
		alert('You did not select any text to quote');
}

function storeCaret (textEl) 
{
	if (textEl.createTextRange) textEl.caretPos = document.selection.createRange().duplicate();
}

function insertAtCaret (textEl, text) 
{
	if (textEl.createTextRange && textEl.caretPos) 
	{
 	var caretPos = textEl.caretPos;
  caretPos.text = caretPos.text.charAt(caretPos.text.length - 1) == ' ' ? text + ' ' : text;
 }
 else textEl.value  = text;
}
//-->
</script>

<body>
	<DIV id="divOriginal" style="padding: 5px; width: 400px; border: 1px solid #cccccc">
		Colin Davies wrote:
		Yeah the quote button is a cool idea<BR><BR>
	
		Thank Paul Watson and Mike Dunn for the kick in the bum to get this feature added.<BR><BR>
	
		cheers,<BR>
		Chris Maunder (CodeProject)
	</DIV>
	<BR><INPUT type="Button" name="cmdQuote" value="Quote that!" onclick="QuoteText('Bob');"><BR><BR>
	<TEXTAREA name="txtReply" id="txtReply" 
		rows="20" cols="47" 
		style="width: 400px;" 
		onclick="storeCaret(this);" 
		onkeypress="storeCaret(this);" ></TEXTAREA>
</body>
</html>

regards,
Paul Watson
Bluegrass
Cape Town, South Africa

Do you Sonork? I do! 100.9903 Stormfront

"The greatest thing you will ever learn is to love, and be loved in return" - Moulin Rouge

Chris Maunder13-Nov-01 0:50

13-Nov-01 0:50

Thanks Paul!

I had a go at this but it didn't seem to be consistently saving the carrot position. I'll have a second attempt later.

cheers,
Chris Maunder (CodeProject)

Paul Watson13-Nov-01 4:33

13-Nov-01 4:33

Hmmm, in what instances doesn't it record the caret position? I will have a look at it and fiddle.

(lame joke alert!) I may call Bugs Bunny, he is good with carrots... Dead | X|

Chris Maunder wrote:
cheers,
Chris Maunder (CodeProject)

Damn I like clicking that button... Big Grin | :-D

regards,
Paul Watson
Bluegrass
Cape Town, South Africa

Do you Sonork? I do! 100.9903 Stormfront

"The greatest thing you will ever learn is to love, and be loved in return" - Moulin Rouge

Chris Maunder15-Nov-01 0:12