Insert information into database from C#

Question

0.00/5 (No votes)

See more:

I am trying to write a code so that if the orderID matches a orderID in the database, the software selects that set of data and changes the 'status' of that line of data to 'in process'. Its a bit confusing but can anyone help? I'm new to C'#

if (result == DialogResult.Yes)
{
    OleDbDataAdapter da = new OleDbDataAdapter("Select * from [Customer Orders] Where [Order ID] = '" + PrdtID.Text + "'", MAcon);
    DataTable dtbl = new DataTable();
    da.Fill(dtbl);

    if (dtbl.Rows.Count == 1)
    {
        OleDbCommand cmd = new OleDbCommand("INSERT * into [Customer Orders]  ([Order Status])  VALUES (@[Order Status])", MAcon);
        cmd.Parameters.AddWithValue("@[Order Status]", Location.Text);

    MAcon.Open();
    cmd.ExecuteNonQuery();
    MAcon.Close();

    }

What I have tried:

if (result == DialogResult.Yes)
{
    OleDbDataAdapter da = new OleDbDataAdapter("Select * from [Customer Orders] Where [Order ID] = '" + PrdtID.Text + "'", MAcon);
    DataTable dtbl = new DataTable();
    da.Fill(dtbl);

    if (dtbl.Rows.Count == 1)
    {
        OleDbCommand cmd = new OleDbCommand("INSERT * into [Customer Orders]  ([Order Status])  VALUES (@[Order Status])", MAcon);
        cmd.Parameters.AddWithValue("@[Order Status]", Location.Text);

    MAcon.Open();
    cmd.ExecuteNonQuery();
    MAcon.Close();

    }

Posted 11-Apr-18 9:57am

Member 13765884

Updated 11-Apr-18 9:59am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Answer 1 · 2018-04-11T10:00:00

One problem you have is that you're concatenating the data from the textbox to the SQL query. This leaves you open to SQL injections and conversion problems. For more information, see SQL injection - Wikipedia[^]

You have used parameters in your INSERT statement so you should do the same with the select.

Another problem is that INSERT syntax does not contain asterisk. So it's simply

SQL

INSERT INTO TableName (column, column, ...) VALUES (value, value, ...).

For further examples, have a look at Properly executing database operations[^]
Even though the examples are using SqlClient, the idea is the same with OleDb... classes.