regex replace method used on dataset index number or datagridveiw index number

Question

0.00/5 (No votes)

See more:

Hi developers,

I want to replace some wildcards in dataset. When I used regex.replace method on all columns and rows that works but If I use it on particular index number, the method does not work.
I can also tell you that I want to apply a regex.replace method on a index number not on a header name.

Please read this code:

C#

foreach (DataRow datarow in dv.Table.Rows)
{
  foreach (DataColumn datacol in dv.Table.Columns)
  {
    datarow[datacol] = System.Text.RegularExpressions.Regex.Replace(datarow[datacol].ToString(), comma.ToString(), slash.ToString());
    datarow[datacol] = System.Text.RegularExpressions.Regex.Replace(datarow[datacol].ToString(), colon.ToString(), Blank.ToString());
  }
}

Please help me.

Posted 20-Dec-10 20:14pm

vishu1999a

Updated 20-Dec-10 20:19pm

JF2015

v2

Add a Solution

Comments

JF2015 21-Dec-10 2:19am

Edited to fix formatting errors.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2010-12-20T22:06:00

That is really quite messy, and inefficient.
1) You don't need to use Regex - string.Replace is simpler.
2) Don't keep converting datatypes - it wastes time, and memory. (I assume "colon", "slash" etc. are char types)
3) Don't keep temporary values in array elements.

C#

string strColon = colon.ToString();
string strBlank = Blank.ToString();
foreach (DataRow datarow in dv.Table.Rows)
   {
   foreach (DataColumn datacol in dv.Table.Columns)
      {
      string s = datarow[datacol].ToString();
      s = s.Replace(comma, slash);
      s = s.Replace(strColon, strBlank);
      datarow[datacol] = s;
      }
   }

You don't need to store the temporary value in a named variable as I have, but it makes it easier to read.

This code (and yours for that matter) should work fine if you use the DataColumn as an index (as you currently do) or an integer index based on the number of rows / columns in the table. If it doesn't, you will have to give us a sample of the non-working code before we could comment. Edit your question to include the non-working version.