Upload function

Question

0.00/5 (No votes)

See more:

Hi,

I have a page. I use to upload images. I want to add function that checks if the image end with asp;.gif or asp;.bmp or asp;.jpg it cannot be upload.
Here is code of the function thats already in the page. It only need some if functions can anyone help me with this:

protected void btnUpload_Click(object sender, System.EventArgs e)
{
        string newDir = "~/" + upfileto.MainClass.CurrentRoom.Folder;
			if(btnUpload.Text !="Edit")
			{				
				if(FileCtrl1.PostedFile.FileName.EndsWith(".bmp")
					||FileCtrl1.PostedFile.FileName.EndsWith(".jpg")
					||FileCtrl1.PostedFile.FileName.EndsWith(".gif"))
				{
                    if (ddlFolder.SelectedItem.Value == "Icons")
                    {
                       FileCtrl1.Value="p"+Convert.ToString(GetImageID())+".gif";
                    }
                    FileCtrl1.SaveAs(Page.Server.MapPath(upfileto.MainClass.CurrentRoom.Folder + @"\" + ddlFolder.SelectedItem.Value + @"\") + FileCtrl1.Value);
					Label1.Text=FileCtrl1.Value;
                  
				}
				else
				{
					Response.Write("<script>alert('File Type is not supported ("+FileCtrl1.PostedFile.FileName+")');history.back()<"+"/script>");
					Response.End();
					
				}
			}
			else
			{
				
				if(FileCtrl1.PostedFile.FileName!="")
				{
					if(FileCtrl1.PostedFile.FileName.EndsWith(".bmp")
						||FileCtrl1.PostedFile.FileName.EndsWith(".jpg")
						||FileCtrl1.PostedFile.FileName.EndsWith(".gif"))
					{
                    
                    FileCtrl1.PostedFile.SaveAs(Page.Server.MapPath(upfileto.MainClass.CurrentRoom.Folder + @"\" + ddlFolder.SelectedItem.Value + @"\") + Request.QueryString["FileName"].ToString() );
                        
                       
					}
					else
					{
						Response.Write("<script>alert('File Type is not supported ("+FileCtrl1.PostedFile.FileName+")');history.back()<"+"/script>");
						Response.End();
					}			
				}
				
			}
			Response.Redirect("Main.aspx?Section=UpFile&i=1&Folder="+ddlFolder.SelectedItem.Value , true);
}

Posted 28-Dec-10 2:56am

akoyoon

Updated 28-Dec-10 3:14am

v4

Add a Solution

Comments

Sandeep Mewara 28-Dec-10 9:05am

Use PRE tags to format code part. It makes the question readable.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Hiren solanki · Answer 1 · 2010-12-28T03:12:00

Solution 1

If you're using same thing in your program more then twice then you should use Function there to reduce code and more clear understanding.

likewise you're using same thing to check the extension of uploaded file, you could use function in space, see following.

public bool ShouldUpload(string filename)
{
if(filename.EndsWith(".jpg") || filename.EndsWith(".png"))
return true;
}

if(ShouldUpload(Fileupload1.postedfile.filename))
{
//upload image here.
}

Posted 28-Dec-10 3:12am

Hiren solanki

Updated 28-Dec-10 3:17am

v2

Comments

akoyoon 28-Dec-10 9:31am

i donot understand what you mean

MrBatra 28-Dec-10 9:40am

What's you're not understanding, be specific.

In case you;re not understanding the code here's what it does;

The above code is checking whether the file or image ends with ".jpg" or ".png" (in your case you can change this to ".bmp") ; If its true then exit from function don't do anything else the function will execute the code to upload the image.

You need to write that code for uploading.

akoyoon 28-Dec-10 9:51am

your code will not be useful in case someone try to upload image with name like hi.asp;.jpg for example

your code do exactly what the code i posted do but it doesn't solve the problem

Hiren solanki 29-Dec-10 0:12am

Dear akoyoon, I've posted code which could help you to make function in checking the file extension, you could add .asp,.jpg and millions of extensions you want, I am not going to include everything for you. Otherwise I might understand you wrong so please make us clear on what you exactly want. ?