creating a timer in windows service

Question

4.00/5 (1 vote)

See more:

i have created a timer in windows service application and it should execute a method every 1 sec but my problem is the timer works for several seconds and then stop automatically
the service should write a line in the text, that line contains the windows date and time,and the windows time should change every 1 sec
i dunno if the timer is stopped or the whole service is stopped
i need someone to explain why is this happening

protected override void OnStart(string[] args)
        {
            // TODO: Add code here to start your service.
            System.Timers.Timer T1 = new System.Timers.Timer();
            T1.Interval = (1000);
            T1.AutoReset = true;
            T1.Enabled = true;
            T1.Start();
            T1.Elapsed += new System.Timers.ElapsedEventHandler(T1_Elapsed);
        }
 
        protected override void OnStop()
        {
            // TODO: Add code here to perform any tear-down necessary to stop your service.
            System.Timers.Timer T1 = new System.Timers.Timer();
            T1.Interval = (1000);
            T1.AutoReset = true;
            T1.Enabled = true;
            T1.Start();
            T1.Elapsed += new System.Timers.ElapsedEventHandler(T1_Elapsed);
        }
        private void T1_Elapsed(object sender, EventArgs e)
        {
            FileStream TS = new FileStream(@"C:\Test.txt", FileMode.OpenOrCreate);
            string lines = "Service has been started at" + DateTime.Now.ToString();
            System.IO.StreamWriter file = new System.IO.StreamWriter(TS);
            file.WriteLine(lines);
            file.Close();
            TS.Close();
        }

Posted 1-May-11 2:36am

snake1

Updated 1-May-11 2:37am

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2011-05-01T02:56:00

That's a terrible design.

0) Why don't you use the system log for that?

1) Why are you causing so much file I/O? the system is going to be spending so much time writing to disk that it won't have much time for anything else. If you absolutely need to write to the disk every second, buffer the text to be written for a minute or two, and then flush the buffer to the file all at once.

2) What happens if your text file manages to fill the disk?

3) The problem is probably that you're trying to handle the timer event while the last time event is still being processed (see item 1 above).

4) Put a try catch block around the code in the T1_Elapsed method that will simply ignore the event if an exception is thrown.

C#

try
{
   do my processing
}
catch (Exception)
{
}

Not Active · Answer 2 · 2011-05-01T02:53:00

You are creating a timer instance both when the service is started and stopped?

You should create the timer in an init method, the constructor would suffice, then start it in the OnStart event handler and stop it in the onStop event handler.

Also, opening and closing FileStream objects is an intensive process, doing it every second won't make your service very performant.

Have you checked the Windows event log for any messages about your service?

Sergey Alexandrovich Kryukov · Answer 3 · 2011-05-01T12:25:00

Solution 3

That's a terrible design.

Avoid using timers. This is exactly a case when a timers can make a lot more harm than help.
Instead, create a thread which will repeat the call, use System.Threading.Thread.Sleep — for required amount of time.

Use logging indeed.

—SA

Posted 1-May-11 12:25pm

Sergey Alexandrovich Kryukov

creating a timer in windows service

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0